Repository navigation
ci: stabilize and scope pull request checks - #20
Merged
Merged
Conversation
2dubu
marked this pull request as ready for review
August 20, 2026 16:38
Select and boot the newest compatible iOS 26 runtime, split async and remaining core suites with step-level timeouts, and preserve xcresult and simulator diagnostics on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutto v6, and make Xcode discoveryactionlint-clean.Background
The loader tests polled
phaseevery 50 milliseconds until a wall-clock deadline. If the loader completed during the final sleep, the loop could cross the deadline and record a timeout without observing the completed state. The failing CI log demonstrated this mismatch: the timeout was recorded while the final phase was already the expected.successor.failurevalue. Repeated polling from@MainActortests also introduced unnecessary executor wake-ups.Separately, the workflow ran both macOS and iOS jobs for documentation-only pull requests and had no explicit job timeouts. One iOS Simulator run remained in
xcodebuild testfor more than 20 minutes. GitHub's default job timeout would otherwise allow a stuck runner to remain active for up to six hours.Solution
AsyncStreamevent against an explicit timeout, suspending instead of polling the main actor.Detect code changesjob. The macOS and iOS jobs run only whenSources,Tests,Examples, package configuration, or CI workflows change.actions/checkoutfrom v4 to v6 and replace the warning-pronels | grepXcode discovery withfind.Related Issue
None. This is CI reliability and maintenance work discovered while validating pull request #19.
Verification
actionlint .github/workflows/ci.ymlswift package resolveswift build -c debugswift test --filter PaletteKitTests --filter PaletteKitInsightsTests— 55 tests, 0 failures.-test-iterations 20— 320 test runs, 0 failures.-test-iterations 10— 1,410 test runs, 0 failures.git diff --checkmacos-15runners.Compatibility and Impact
Checklist