Repository navigation
docs(benchmarks): mark electron bench digests stale after band-bottom changes (#366) - #384
Conversation
…#339/#342 (#366) Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Loom-Story: #366 Loom-Trace-Id: ca7ed8c8abe83ea584817efdd4925df8 Loom-Build: 0.19.1039 e83d19dc0a9b217339ea2f14040c50ad6f46700d clean
|
Judge: approved. Docs-only change in docs/benchmarks.md (12 added lines, outside the generated block). Verified: all six summaries carry date 2026-10-08 and 'lindhard 0.0.1 (0942eb2)'; 0942eb2 is dated 2026-10-08 and is an ancestor of #241 (2caceec, 10-09), #342 (ca50979, 10-10) and #339 (648744d, 10-10), so the stale statement is accurate. The summaries are untouched, and bench_electron.py --update-docs --check exits 0 on the PR head. CSTOOL_SRC is unset on this host, so the 'inputs unavailable, nothing invented' path of issue #366 is correctly taken. No SRIM data or downstream-application text. The validation-table, validation-figure, clean-room, cargo-deny and workflow checks pass; the remaining checks were still pending at review time, so merge only when they are green. |
|
Approval re-queued — it carried no verdict-sha marker; re-review required: |
|
Approved. Docs-only (docs/benchmarks.md, +12). Re-verified at 9629aa9: the six bench-electron summaries are dated 2026-10-08 at 0942eb2 (an ancestor of main); #241 (PR #244, merged 2026-10-09), #339 (#351/#355, 2026-10-10) and #342 (#344, 2026-10-10) landed after, so the stale-status note is accurate. Summaries untouched (only docs/benchmarks.md changed); bench_electron.py --update-docs --check exits 0; all CI checks pass, mergeStateStatus CLEAN, no unresolved reviews or threads. |
Closes #366
Path taken: inputs unavailable.
CSTOOL_SRC(cstool clone, needed byvalidation/oracles/bench_electron.py) is not present on this host, so the six digests were not regenerated and no results were invented.Instead,
docs/benchmarks.md(Caveats, outside the generated block) now carries a dated stale-status note: all six digests date from 2026-10-08 at0942eb2, before #241, #339 and #342, and the pending 'Still to measure' run replaces all six together. The summaries are untouched;bench_electron.py --update-docs --check(the CI check consuming them) passes.🤖 Generated with Claude Code
loom dashboard