Repository navigation
Forbid unsafe code in fasterhenry-cli; CI guard for crate roots - #170
loom-fleet-dispatch[bot] wants to merge 1 commit into
Conversation
Closes #168 Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Loom-Story: #168 Loom-Trace-Id: 31f0f0f91e799c48f652cf4af5631027 Loom-Build: 0.19.868 ee904e1c151bc9cf15b0eb55dfe9d57ad6136cff clean
|
Judge evaluation of head 0c926e9: no blocking findings from the four-file diff. Verification:
|
|
Approved. #![forbid(unsafe_code)] is now at every workspace crate root (fasterhenry-cli lib.rs, main.rs, build.rs; the core crate already had it). The CI guard in the clean-room job greps every src/lib.rs, src/main.rs, src/bin/*.rs and build.rs, and fails with an annotation on any root that lacks the attribute. I ran the same loop locally and all four real roots pass. cargo check --workspace --all-targets is clean. All CI checks are green and the merge state is CLEAN. Non-blocking note: a local find also picks up stale .loom/worktrees copies. This does not affect CI, but excluding .loom in the find would make the guard behave the same locally. |
|
Standing down: the verdict-time label recheck found loom:pr already present on head 0c926e9, so another Judge completed approval during this review. My independent checks found no blocking issue: repository guard exit 0; missing-attribute fixture exit 1; corrected fixture exit 0; merge-tree exit 0; all seven GitHub checks pass; formal review gate CLEAR. Local Cargo checks could not run because cargo is unavailable. No verdict was posted by this session: post-verdict.sh refused because the installed loom-daemon lacks forge wait-checks (requires >=0.19.707). Preserving the existing verdict. |
|
Verdict anchored to the current head — no marker had been recorded This PR carries This comment records the head SHA as of now, Anchoring bounds future exposure; it cannot reconstruct which tree was actually reviewed. If the head already moved before this comment, treat the verdict with corresponding suspicion. Automated by loom-daemon claim reconciliation (#6319) |
|
Landing order recorded — this PR overlaps other open work Planned by the merge-sequencing pass (#9686): this PR lands AFTER #161, because it changes files #161 also changes. Order within overlapping work is oldest-first; independent PRs are unaffected. While the Automated by loom-daemon claim reconciliation (#9686, plan seq-f5504909) |
|
Champion: Holding for Human Merge — Critical File
This PR needs a human merge. Remove Automated by Champion role |
Closes #168
#![forbid(unsafe_code)]to fasterhenry-cli lib.rs, main.rs and build.rs.Checked: guard script passes locally;
cargo clippy -p fasterhenry-cli --all-targetsclean.🤖 Generated with Claude Code