Repository navigation
docs: align benchmark speed summary with table (1k serpentine within noise) - #169
loom-fleet-dispatch[bot] wants to merge 1 commit into
Conversation
…noise) The Speed summary claimed the dense path beats FastHenry on every completed deck, but the 1,000-filament serpentine row is 73 ms vs 69 ms. Note the exception, and narrow '3x at small sizes' to the measured 1.6-3x. Apply the same correction to the README sentence that repeats the summary. Closes #167 Co-Authored-By: Claude Opus 5.5 <[email protected]> Loom-Story: #167 Loom-Trace-Id: cb75ef33a6890b540ff1f237362bd3c4 Loom-Build: 0.19.868 ee904e1c151bc9cf15b0eb55dfe9d57ad6136cff clean
|
Judge: code review of 466cdad is clean (docs-only; figures match the benchmark table, Closes #167 present) and all 7 checks show pass in gh pr checks. However post-verdict.sh's exact-head CI gate refuses the approval because wait-checks cannot read required contexts on main ("Resource not accessible by integration"). Not overriding the gate. Releasing the claim and leaving loom:review-requested for a later pass or an operator. |
|
Judge: code review passed for 466cdad, but approval could not be posted. README.md and docs/benchmarks.md match #167 and the published table. Arithmetic over its rows gives speed ratios 3.100×, 1.615×, 0.945×, 2.194×, and 1.243×. Benchmark timing and variance were not independently rerun; 'within noise' is the operator's characterization.
|
|
Judge: code/doc review passed (figures in README.md and docs/benchmarks.md match the Speed table; all visible CI checks green on 466cdad, merge state CLEAN). Not approving yet: |
|
Judge review completed for 466cdad: the two documentation changes match the benchmark table and #167; diff whitespace and merge-preview checks passed. gh pr checks reported seven passing checks, and check-review-feedback.sh reported CLEAR with no formal reviews or inline comments. Benchmark variability was not independently remeasured; the within-noise characterization comes from the operator in #167. No runtime tests were run for the prose-only diff. Approval remains pending: post-verdict.sh refused with exit 5 because the installed loom-daemon lacks forge wait-checks, so its mandatory exact-head CI gate could not run. No approval was posted. Releasing loom:reviewing and retaining loom:review-requested; update loom-daemon to a compatible version before re-running Judge. |
|
Judge pass: still carries a fresh Stand-down passes against this claim: 1 of 3 before the bounded fallback force-reclaims it. This comment is edited in place on each pass rather than reposted (#5123, #6514). |
|
Judge evaluation complete at 466cdad: the documentation correction matches issue #167 and the benchmark table (31/10=3.1, 21/13=1.62, 4.52/2.06=2.19, 103.7/83.4=1.24). git diff --check passes; gh pr checks reports all seven checks passing; formal/inline feedback gate reports CLEAR with zero reviews/comments. No local functional tests apply to the two Markdown-only changes; timings/noise were not independently rerun. No Test Plan or TDD line is present (advisory for docs). Approval could not be posted: post-verdict.sh refused with exit 5 because installed loom-daemon 0.19.624 lacks forge wait-checks; the gate requires >=0.19.707. Releasing loom:reviewing and leaving loom:review-requested for re-evaluation after the daemon is updated. |
|
Judge: review of the content is complete and clean (figures in README.md / docs/benchmarks.md match the Speed table: 3.1×, 1.6×, 2.19×, 1.24×; 1k serpentine 69 vs 73 ms; no formal reviews outstanding; all 7 checks pass per |
|
Code/documentation review passed at
Releasing |
|
Judge: code review passed. The 7 checks listed by |
|
Judge evaluation of head 466cdad found no blocking documentation issues. The corrected ratios match the committed table; the noise assessment is operator-reported in #167, not independently measured. git diff --check passed, gh pr checks reported all seven checks passing, merge state is CLEAN, and check-review-feedback.sh reported CLEAR. No local Rust tests were run for this two-Markdown-file diff. No TDD declaration was provided (advisory for documentation). Approval remains unposted: post-verdict.sh refused because the installed loom-daemon 0.19.624 does not support forge wait-checks; the approval gate requires 0.19.707 or newer. Releasing loom:reviewing and leaving loom:review-requested for re-evaluation after the daemon is updated. |
|
Judge review of head 466cdad: no blocking findings in the two-file documentation diff. README.md and docs/benchmarks.md now include the 1,000-filament exception requested in #167. Recomputed table ratios with awk: 31/10=3.100, 21/13=1.615, 4.52/2.06=2.194, 103.7/83.4=1.243; these support the rounded speed summaries. The within-noise characterization comes from the operator statement in #167; timing variance was not independently measured. Verification: git diff --check origin/main...HEAD passed; local tests skipped for Markdown-only changes per scoped-test policy. No Test Plan or TDD line is present (advisory only). check-review-feedback.sh returned CLEAR with zero formal reviews and zero inline comments. gh pr checks reports all seven visible checks passing; mergeStateStatus is CLEAN. Approval remains pending: loom-daemon forge wait-checks 169 --timeout 20 returned LOOM-CHECKS-TIMEOUT (required-contexts-unknown), because the branch-protection lookup failed with Resource not accessible by integration. The mandatory approval gate is therefore inconclusive. Releasing loom:reviewing and leaving loom:review-requested for a later pass once the credential can read branch-protection requirements. |
|
Judge: code review passed (docs claims verified against the Speed table; all 7 CI checks pass per |
|
Code review passed for head 466cdad, but approval remains pending because Loom could not verify required CI contexts. Reviewed the complete two-file diff and the benchmark table. The documented ratios agree with its entries: 31/10 = 3.1, 21/13 = 1.62, 4.52/2.06 = 2.19, and 103.7/83.4 = 1.24. Both summaries now acknowledge the 73 ms versus 69 ms exception. The noise characterization is supplied by issue #167; benchmark variance was not independently measured. Validation: Approval gate: |
|
Judge review completed for head 466cdad. The diff updates only README.md and docs/benchmarks.md. Reading the benchmark table and calculating 31/10, 21/13, 4.52/2.06, and 103.7/83.4 gives 3.100x, 1.615x, 2.194x, and 1.243x, consistent with the rounded summaries; both summaries now acknowledge the 73 ms versus 69 ms exception. The noise characterization follows the operator's report in #167; I did not independently measure timing variability. git diff --check passed, and git merge-tree --write-tree origin/main HEAD completed without conflicts. No executable changes, so local Rust tests were not run. No Test Plan or TDD line is present; advisory only. check-review-feedback.sh returned CLEAR, with zero formal reviews and inline comments. gh pr checks reports all seven checks passing, and mergeStateStatus is CLEAN. Approval remains unverified because loom-daemon forge wait-checks returned LOOM-CHECKS-TIMEOUT (required-contexts-unknown), with: required-context lookup for main failed: classic branch-protection lookup failed: gh api graphql failed: gh: Resource not accessible by integration. Waiting cannot resolve this credential permission refusal. Releasing loom:reviewing and retaining loom:review-requested so a later Judge can approve once the required-context read is available. |
|
Judge review could not publish an approval: post-verdict.sh exited 5 because installed loom-daemon 0.19.623 lacks forge wait-checks (gate requires >=0.19.707). gh pr checks 169 reports all seven checks passing; review-feedback gate is CLEAR. Prose matches the table ratios on head 466cdad; original timings/noise characterization were not remeasured. No blocking diff findings. Leaving loom:review-requested and releasing my claim for re-evaluation with a compatible daemon. |
|
Code and documentation evaluation passed, and GitHub reports all seven checks successful on head |
|
Standing down: re-checked labels immediately before writing my verdict and found |
|
Judge: content review passed for head |
|
Code/documentation evaluation passed, and a live Releasing |
|
Standing down: the final live label recheck found |
|
Judge review completed for 466cdad: no blocking findings in the two-file documentation diff. Benchmark ratios checked against the table (3.10, 1.62, 2.19, 1.24); git diff --check passed; gh pr checks reported seven passing checks; formal-review gate returned CLEAR. Approval was not posted: post-verdict.sh refused because installed loom-daemon 0.19.623 lacks forge wait-checks (required floor 0.19.707). Releasing my claim and leaving loom:review-requested for a host with an updated daemon. This comment is not a workflow approval. |
|
Code and documentation evaluation passed on head |
|
Judge evaluation completed cleanly on head |
|
Judge review completed successfully on head |
|
Judge review completed for head |
|
Judge review completed for head Approval was not posted because the mandatory exact-head CI gate in |
|
Documentation review passed for head 466cdad; approval remains pending CI verification. Reviewed both changed files against issue #167 and the existing benchmark table. The 1,000-filament exception matches the recorded 73 ms versus 69 ms. Calculated table ratios with awk: 31/10 = 3.100, 21/13 = 1.615, 4.52/2.06 = 2.194, and 103.7/83.4 = 1.243, consistent with the rounded summary. The within-noise characterization is supplied by the issue author; benchmark variability was not independently remeasured. Verification: the isolated worktree HEAD matches the PR head and its working tree is clean; git diff --check origin/main...HEAD passes. Paginated changed-files API lists only README.md and docs/benchmarks.md. No executable changes require local runtime tests. No Test Plan or TDD line is present (advisory only). check-review-feedback.sh reports CLEAR, with zero formal reviews and inline comments. gh pr checks reports all seven checks passing; merge state is CLEAN. Approval gate limitation: loom-daemon forge wait-checks 169 --timeout 20 returned LOOM-CHECKS-TIMEOUT (required-contexts-unknown), with: "required-context lookup for main failed: classic branch-protection lookup failed: gh api graphql failed: gh: Resource not accessible by integration". Required-check coverage therefore remains unverified despite the visible green checks. Releasing loom:reviewing and retaining loom:review-requested for a later verification pass. |
|
Judge evaluation completed successfully, but no approval verdict was posted: this host's Review evidence on head
Releasing |
|
Code review passed: the revised prose matches the benchmark table, the documented ratios were independently re-derived, all seven GitHub CI checks are green on head I could not post the approval verdict because this host's installed |
|
Judge evaluation completed successfully for head I am not issuing an approval label because the mandatory exact-head CI gate in |
|
Code and documentation evaluation passed for head |
|
Code and documentation evaluation passed, and Releasing |
|
Review completed for head 466cdad; no blocking documentation findings. The paginated files API lists only README.md and docs/benchmarks.md. Reading the Speed table against the diff confirms the 73 ms versus 69 ms exception and the rounded speed ratios (31/10 = 3.10, 21/13 = 1.62, 4.52/2.06 = 2.19, 103.7/83.4 = 1.24). The noise characterization follows the operator's statement in #167; I did not rerun benchmarks.
Approval remains conditional: |
|
Code review passed for head |
|
Judge review completed successfully for head |
|
Code and documentation evaluation passed on head |
|
Judge review passed for head |
|
Code/documentation evaluation passed, and |
|
Judge review completed for head Reviewed the two-file diff against the benchmark table. Both summaries now except the 1,000-filament row (73 ms versus 69 ms), and the rounded speedup figures agree with the table. The within-noise characterization comes from issue #167; variability was not independently measured. No blocking content findings. Verification: Loom's required approval gate returned |
Summary
Docs-only; no code or tests touched.
Closes #167
🤖 Generated with Claude Code
loom dashboard