Skip to content

Compat: approximate diagonal contact trace by padded bounding box (#157) - #163

Merged
rjwalters merged 2 commits into
mainfrom
feature/issue-157
Oct 6, 2026
Merged

rjwalters merged 2 commits into
mainfrom
feature/issue-157

Conversation

@loom-fleet-dispatch

@loom-fleet-dispatch loom-fleet-dispatch Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Closes #157

Under --fasthenry-compat, a diagonal contact trace is accepted and refined as its bounding box padded by 3w/2 (a decay_rect/contact rect, no outward limit) with cells (w/2)·s^min(|tan θ|,|cot θ|) (cell capped at half the box's narrower width). A line-numbered warning names the staircase approximation. Native mode keeps the rejection (message reworded). Docs table row, decision section, module docs and CHANGELOG updated.

Tests: 30°/60° mirror images and 45° equal the explicit contact rect; warning text/line; native rejection unchanged. fmt, clippy -D warnings, fasterhenry-cli tests pass.

🤖 Generated with Claude Code

loom dashboard


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

rjwalters and others added 2 commits October 5, 2026 17:44
…ox (#157)

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Loom-Story: #157
Loom-Trace-Id: edbaff573863d5e39afbe7ede1134fc7
Loom-Build: 0.19.732 c1ef52e4d1926fd6f224abe962829326121161da clean
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Loom-Story: #157
Loom-Trace-Id: edbaff573863d5e39afbe7ede1134fc7
Loom-Build: 0.19.732 c1ef52e4d1926fd6f224abe962829326121161da clean
@loom-fleet-dispatch loom-fleet-dispatch Bot added loom:review-requested PR ready for Judge to review. Applied by: Builder when opening PR. loom:reviewing Judge is reviewing this PR. Applied by: Judge only. Stale after LOOM_STALE_REVIEWING_MINUTES (30m). labels Oct 6, 2026
@loom-fleet-dispatch

loom-fleet-dispatch Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Judge pass: still carries a fresh loom:reviewing claim (claimed 2026-10-06T00:47:44Z, idle 11m) — standing down without reclaiming. Not stomping.

Stand-down passes against this claim: 4 of 3 before the bounded fallback force-reclaims it. This comment is edited in place on each pass rather than reposted (#5123, #6514).

@loom-fleet-dispatch

Copy link
Copy Markdown
Contributor Author

Judge review (explicit request): approved.

Acceptance criteria for #157:

  • Compat 30/45/60 deg parse; compat_diagonal_contact_trace_is_its_padded_bounding_box asserts the mesh equals the explicit padded-bbox contact rect with cells (w/2)*s^min(|tan|,|cot|). Met.
  • Symmetry: the test covers both [4,a] and [a,4] spans (30/60 mirror) with the same cell, since ratio = min/max of spans. Met.
  • Warning names the approximation (on the clause's own line); native rejection unchanged, message reworded, test asserts it. Met.
  • Compat-table row, decision section, module docs and CHANGELOG updated. Met.

Checks: inp tests 121 pass locally (private target dir); all CI checks pass (incl. clean-room), merge state CLEAN. Curator guidance followed; the half-narrower-width cell cap is a reasonable documented safeguard.

Non-blocking nits: the old decision section's body still opens with native-only text (fine, now labelled), and there is a stray double blank line after the new compat paragraph in docs/fasthenry-compat.md.

loom dashboard

@loom-fleet-dispatch loom-fleet-dispatch Bot added loom:pr PR approved by Judge, ready for Champion auto-merge. Applied by: Judge. and removed loom:reviewing Judge is reviewing this PR. Applied by: Judge only. Stale after LOOM_STALE_REVIEWING_MINUTES (30m). loom:review-requested PR ready for Judge to review. Applied by: Builder when opening PR. labels Oct 6, 2026
@loom-fleet-dispatch

Copy link
Copy Markdown
Contributor Author

Landing order recorded — this PR overlaps other open work

Planned by the merge-sequencing pass (#9686): this PR lands AFTER #162, because it changes files #162 also changes. Order within overlapping work is oldest-first; independent PRs are unaffected.

While the loom:sequenced label is present, merge-pr.sh refuses to merge this PR (the #9378 gate). The label clears mechanically when #162 lands at the recorded head — or by re-evaluation if it closes or moves. This is a scheduling preference: it suppresses only redundant base-conflict repairs while #162 is in flight, never a genuine review finding.


Automated by loom-daemon claim reconciliation (#9686, plan seq-2c17c32b)

@rjwalters
rjwalters merged commit a2f43ca into main Oct 6, 2026
8 checks passed
@rjwalters
rjwalters deleted the feature/issue-157 branch October 6, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loom:pr PR approved by Judge, ready for Champion auto-merge. Applied by: Judge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compat: approximate a diagonal contact trace by refining its bounding box

1 participant