fix(templates): remove obsolete Vite React configuration - #37
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical code-splitting configuration issues remain in the React template and dashboard Vite configs.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates React/Rolldown Vite configurations, preserves generated package.json formatting, and adds localized hk repair guidance.
Changes:
- Migrates Vite tooling and code-splitting configuration.
- Adds formatting-preserving JSON updates and tests.
- Adds hook guidance, localization, documentation, and formatting fixes.
File summaries
| File | Summary |
|---|---|
packages/templates/react-spa/vite.config.ts |
Updates React build configuration; code-splitting groups need correction. |
packages/templates/react-spa/package.json |
Replaces the obsolete React plugin dependency. |
packages/templates/expo-mobile/src/app/(tabs)/index.tsx |
Applies JSX formatting changes. |
packages/cli/internal/transport/cobra/hooks/cmd.go |
Adds failed-check repair guidance. |
packages/cli/internal/transport/cobra/hooks/cmd_test.go |
Tests hook failure hints. |
packages/cli/internal/platform/i18n/locales/zh-CN.json |
Adds Chinese localized guidance. |
packages/cli/internal/platform/i18n/locales/en-US.json |
Adds English localized guidance. |
packages/cli/internal/modules/creation/workspace_content.go |
Adjusts generated package ordering. |
packages/cli/internal/modules/creation/package_format_test.go |
Tests generated project formatting. |
packages/cli/internal/modules/creation/ordered_json.go |
Uses shared ordered JSON encoding. |
packages/cli/internal/modules/creation/languages.go |
Preserves package formatting during updates. |
packages/cli/internal/modules/creation/json_fields.go |
Adds targeted JSON field editing. |
packages/cli/internal/modules/creation/json_fields_test.go |
Tests formatting preservation and validation. |
docs/plans/2026-09-18-generated-project-formatting.md |
Documents implementation and validation. |
apps/docs/content/docs/zh/hk.md |
Documents hk repair and mise usage. |
apps/dashboard/vite.config.ts |
Migrates dashboard chunk configuration; code-splitting groups need correction. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.