feat(docs): add logo intro and optimize hero animation - #29
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are concrete runtime/UX and performance issues (indefinite loading fallback on init failure, and shader-recompile churn from transparency toggling) that should be addressed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the docs home hero WebGL animation to add a brand “arc reunite” intro sequence and improve runtime efficiency by modularizing the workspace scene and optimizing render scheduling/interaction handling.
Changes:
- Extracts the workspace scene construction + animation logic into a dedicated
hero-workspace.tsmodule. - Adds procedural brand arc geometry (
hero-brand-geometry.ts) and renders it as an intro element before handing off to the printed SVG mark. - Updates the hero canvas controller to dynamically import Three.js + RoomEnvironment, render on-demand (viewport/visibility-aware), and improve pointer interaction handling.
File summaries
| File | Description |
|---|---|
| apps/docs/src/app/(home)/hero-workspace.ts | New shared workspace scene builder/animator (modules, board, printed logo, spotlight panels). |
| apps/docs/src/app/(home)/hero-canvas.tsx | Reworked hero controller: dynamic imports, intro brand arcs, on-demand RAF loop, improved cleanup + interaction. |
| apps/docs/src/app/(home)/hero-brand-geometry.ts | New procedural extruded arc geometry with analytic normals for smooth highlights. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.