Repository navigation
Separate core responsibilities and add an experimental Linux client - #1
Merged
Merged
Conversation
|
Sorry @0Fox2Give, your pull request is larger than the review limit of 150,000 diff characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core mixed settings, catalog lookup, storage and worker messages in one file, while the desktop and capture entry points assumed Windows. Split those responsibilities into focused files and add an experimental native Linux client without replacing the Windows WPF UI.
The Linux client shares collection, Recent/Nearby, merchant feedback, finder, pins and family logic. Capture admits only sockets owned by the configured game process; missing ownership does not fall back to all Wine/TCP traffic. Linux builds have separate dependency notices, packaging and CI. Live AION 2/Wine and compositor compatibility remain unverified. Windows release and updater delivery remain at 0.1.51.
Validation: both jobs passed in CI run 39356095332 for head 5af7f26. Windows regression suites include 245 WPF and 61 updater checks, followed by an unsigned developer-package build. Ubuntu checks include 92 portable/procfs checks, 11 rendered UI checks and 95 checks with packaged libpcap capture, same-user IPC and orderly exit. Rendered merchant updates and finder layout inspected; an ownership-filter mutation failed the regression suite as expected.
Formatting preserved syntax tokens; moved types were compared by name against the base revision. Only the six intended family/platform adaptations change existing production type tokens. Secret scan of the staged source snapshot found no leaks using the two existing exact synthetic-fixture exclusions. NuGet auditing is enabled for direct and transitive packages. Shutdown fixture tests now use a readiness handshake and actual process-exit observation instead of assuming cold PowerShell startup finishes in five seconds.