Repository navigation
Accept normalized CLA signature comments - #30
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the workflow condition and its interaction with the CLA action. The change is narrowly scoped, preserves exact recheck handling, and allows normalized signature comments to reach the action without treating quoted or instructional text as signatures. Validation scope is appropriate. LGTM.
|
🎉 This PR was successfully merged—thank you, @glenn-jocher, for improving the CLA workflow gate in PR #30!
The updated |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx [email protected] --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to pass comments containing the standard signature text to the normalized action matcher, allowing valid signatures with trailing whitespace or surrounding Markdown to be evaluated.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand’s exact-match behavior unchanged.actionlintand Prettier for the workflow file.🎯 Purpose & Impact
CLA signature comments that include formatting around the standard text can now reach the matcher, while
recheckremains exact and the action continues to determine whether the normalized comment is a valid signature.