diff --git a/package.json b/package.json index bb5fd08..8e0e5aa 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "github-html-preview", "description": "Safely preview public HTML files and pull-request changes on GitHub", "private": true, - "version": "0.6.8", + "version": "0.6.9", "type": "module", "scripts": { "dev": "wxt", diff --git a/smoke/live.spec.ts b/smoke/live.spec.ts index 5f59503..8f7f31c 100644 --- a/smoke/live.spec.ts +++ b/smoke/live.spec.ts @@ -86,7 +86,9 @@ test('current GitHub blob UI renders repository CSS in a sandboxed preview', asy }); await expect(nextFile).toBeVisible({ timeout: liveTimeout }); await nextFile.click(); - await expect(page).toHaveURL(/\/getting-started\/index\.html$/); + await expect(page).toHaveURL(/\/getting-started\/index\.html$/, { + timeout: liveTimeout, + }); const refreshedFrame = page .locator( diff --git a/wisdom/live-smoke-github-outage.md b/wisdom/live-smoke-github-outage.md new file mode 100644 index 0000000..fa2af4f --- /dev/null +++ b/wisdom/live-smoke-github-outage.md @@ -0,0 +1,8 @@ +# Live blob smoke: GitHub 504s and slow soft navigation + +Run [42047432893](https://github.com/tnfssc/github-html-preview/actions/runs/42047432893) failed all three attempts of the blob test during GitHub degradation, not an extension defect. + +- Attempts 1–2: error context shows GitHub's "504 Gateway Time-out" page, so no Preview tab existed. No test change can help; retries already cover this. +- Retry 2: every Preview assertion passed. After clicking `getting-started/index.html` in the file tree, GitHub's `_file_tree`/`_layout` calls returned but the blob request was still pending, so the SPA URL had not changed when `toHaveURL` hit Playwright's 5s default. + +Fix: `toHaveURL` now uses `liveTimeout` (30s) like every other live wait. Assertions, retries and product behavior unchanged. When a live smoke fails, read each attempt's `error-context.md` snapshot first: a GitHub error page means outage, not regression.