Skip to content

PS2_KEY_LANG4 + 1 is not PS2_KEY_LANG5 #34

Description

@ludolpif

Hi,

By writing a function to test some PS2KeyMap mapping like:

  for ( uint16_t code = PS2_KEY_NUM; code <= PS2_KEY_LANG5; code++ ) {
    remapped = keymap.remapKey(code);
    printRemapped(code, remapped);
  }

I found a weird definition of PS_KEY_LANG5. 0x99 + 1 is 0x9A and not 0xA0.

#define PS2_KEY_LANG4       0X99
#define PS2_KEY_LANG5       0xA0

And "0x9A" isn't anywhere in PS2KeyAdvanced.h. Is it a mistake ?

Thanks for the great work on this lib !

Regards,
Ludovic

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions