This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Repository navigation
Fix: nav bar doesn't turn to light mode in light mode! - #8333
Merged
Merged
Conversation
jobelenus
force-pushed
the
jobelenus/nav-bar-light-mode-fix
branch
from
January 22, 2026 23:54
8c6f69b to
b88cbc0
Compare
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
wendybujalski
approved these changes
Jan 23, 2026
wendybujalski
left a comment
wendybujalski
left a comment
Contributor
There was a problem hiding this comment.
While I'd personally prefer useThemeContainer("dark") as the solution to this problem to avoid adding another button tone, this solution works just fine 👍
Contributor
Author
|
Yea, I'm not sure about a reasonable way to drill that down into a "force" for the themeClass evaluation
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we need an "exception" tone for "dont do themeClass"
