Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Add label for actions panel toggle - #8328

Merged
jobelenus merged 1 commit into
mainfrom
jobelenus/label-action-toggle
Jan 22, 2026
Merged

jobelenus merged 1 commit into
mainfrom
jobelenus/label-action-toggle

Conversation

@jobelenus

@jobelenus jobelenus commented Jan 22, 2026 •

Copy link
Copy Markdown
Contributor

This shows in both the component page, and action page. Toggles without labels are unchanged in their display

image

@github-actions

github-actions Bot commented Jan 22, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the A-web label Jan 22, 2026
This shows in both the component page, and action page. Toggles without labels are unchanged in their display

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good UX if the label can take up the same amount of width in both states so that the toggle doesn't move around when you click on it. A simple way to achieve that would be to just have a prop for adding classes to the label itself, then giving it the appropriate fixed width class to fit both label texts.

@jobelenus
jobelenus force-pushed the jobelenus/label-action-toggle branch from d43b0ff to 48413f5 Compare January 22, 2026 19:01
@wendybujalski
wendybujalski self-requested a review January 22, 2026 19:02
@jobelenus
jobelenus added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 25969a4 Jan 22, 2026
11 checks passed
@jobelenus
jobelenus deleted the jobelenus/label-action-toggle branch January 22, 2026 19:08
@VictoriaMolgado

Copy link
Copy Markdown

A few tweaks:

  • The label comes before the toggle because it changes length. Placing the label after the toggle creates a case where sometimes there's a space after queued but there's never a space after unqueued
  • Space between the toggle and label can be slightly bigger, something equivalent to 8px
  • We can label it "Unqueued" instead of "UnQueued"

On Figma, there was a color difference between queued and unqueued actions. This is a nice-to-have; we can proceed without it.

image

This branch was previously deployed

1 inactive deployment
build-only — 48413f5f Deployed Jan 22, 2026 by jobelenus via validate-build / Deploy Service #23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants