This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Repository navigation
feat: add func runs and func run logs migration to sdf - #8322
Merged
vbustamante merged 5 commits intoJan 23, 2026
Merged
vbustamante merged 5 commits into
vbustamante merged 5 commits into
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
github-actions
Bot
added
A-si-settings
|
There are luminork endpoint changes on this branch that do not appear to have associated tests. Please ensure you add or update tests under |
vbustamante
changed the title
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
2 times, most recently
from
January 22, 2026 17:59
5df62de to
302eaad
Compare
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
jhelwig
reviewed
Jan 22, 2026
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
from
January 23, 2026 00:10
302eaad to
c40d4df
Compare
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
from
January 23, 2026 00:12
c40d4df to
4017dad
Compare
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
from
January 23, 2026 12:21
8f35f6e to
5890561
Compare
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
from
January 23, 2026 12:35
5890561 to
e91df4c
Compare
vbustamante
force-pushed
the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
from
January 23, 2026 12:43
e91df4c to
e4d015a
Compare
Contributor
Author
|
/try |
|
Okay, starting a try! I'll update this comment once it's running... |
jhelwig
approved these changes
Jan 23, 2026
vbustamante
added this pull request to the merge queue
Jan 23, 2026
vbustamante
deleted the
victor/eng-3338-migrate-func-runs-and-func-run-logs-back-to-the-si-database
branch
January 23, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
The migration is inspired by the layer-db -> S3 backfill by has some key differences:
Like it's predecessor, it checks that the entries have already been copied before inserting, and every 10 seconds it'll print out the latest ID it has inserted so we can easily pick up on failed jobs.
to run the migration mode do
The usages have been updated, but the new client uses a fallback strategy so we can migrate with as few access errors as possible. it will right to both databases, and read on the layerdb if it fails to find data on the si-db.
How was it tested?
Does it require a docs change?