Repository navigation
parser: fix Base.parse and add errors and diagnostics - #1103
Merged
Merged
Conversation
Parser::Base.parse and parse_with_comments are class methods taking a String; the instance methods take a Source::Buffer. CurrentRuby is a class, so declare it as singleton(Parser::Base). Add Parser::SyntaxError, UnknownEncodingInMagicComment, Diagnostic, Diagnostic::Engine, Base#diagnostics and Base#version, checked against parser v3.3.12.0. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01GgkyXKEZWpEFXo6ceA5MSw
apiology
marked this pull request as ready for review
October 16, 2026 22:12
|
@apiology Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Claude: This PR was written by Claude Code on behalf of @apiology.
Problem:
Steep rejects documented parser calls:
Code that builds its own parser, configures diagnostics or rescues syntax errors cannot be type-checked.
Solution:
Declare
CurrentRubyassingleton(Parser::Base), makeBase.parse/parse_with_commentsclass methods taking aStringand the instance versions take aSource::Buffer, and addSyntaxError,UnknownEncodingInMagicComment,Diagnostic,Diagnostic::Engine,Base#diagnosticsandBase#version, each matching parser v3.3.12.0.Base#versionis defined in eachRubyNNparser, not inbase.rb;Base#initializecalls it, so it is declared onBase.