From 319343d2d2df4dfa4788380826d0642c094b2575 Mon Sep 17 00:00:00 2001 From: ronzim Date: Thu, 8 Oct 2026 17:44:14 +0200 Subject: [PATCH] ci: run on master, build core before typecheck, require Node 20 - Trigger CI on push and pull requests to master (the default branch), instead of main/refactoring. - Type Check job: build mappit-core before type-checking the app, which imports its declarations from dist/. - Drop Node 18 from the test matrix: Vite 7 and electron-vite 5 require Node >= 20.19. Update engines and README accordingly. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yml | 7 ++++--- README.md | 4 ++-- packages/core/package.json | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f935bb1..4d7a2e1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,9 @@ name: CI on: push: - branches: [main, refactoring] + branches: [master] pull_request: - branches: [main] + branches: [master] jobs: lint: @@ -24,7 +24,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [18, 20, 22] + node-version: [20, 22] steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 @@ -45,6 +45,7 @@ jobs: node-version: 20 cache: npm - run: npm ci + - run: npm run build --workspace=packages/core - run: npm run typecheck --workspace=packages/core - run: npm run typecheck --workspace=packages/app diff --git a/README.md b/README.md index 7ea2478..a13b02f 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ > Supports all export formats (Records.json, Timeline.json, Semantic Location History), handles files > 500 MB, and keeps your data 100 % local. [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](LICENSE) -[![Node.js](https://img.shields.io/badge/node-%3E%3D18-brightgreen)](https://nodejs.org/) +[![Node.js](https://img.shields.io/badge/node-%3E%3D20-brightgreen)](https://nodejs.org/) **Keywords:** google location history viewer, google takeout visualization, google maps timeline viewer, google location history map, location history export tool, GPS data visualization, google timeline data explorer @@ -40,7 +40,7 @@ Il repository è un **monorepo npm workspaces** composto da due package: ## Prerequisiti -- Node.js ≥ 18 +- Node.js ≥ 20.19 (richiesto da Vite 7 ed electron-vite 5) - npm ≥ 10 --- diff --git a/packages/core/package.json b/packages/core/package.json index e0a2b68..51ca3b2 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -28,7 +28,7 @@ "privacy" ], "engines": { - "node": ">=18" + "node": ">=20" }, "main": "./dist/index.js", "types": "./dist/index.d.ts",