Skip to content

Commit 8539248

Browse files
thboileauclaude
andcommitted
Treat compiler warnings as errors
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
1 parent 861a635 commit 8539248

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎changes.md‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ Changes log
1212
- `ObjectRepresentation.VARIANT_OBJECT_XML_SUPPORTED` and
1313
`ObjectRepresentation.VARIANT_OBJECT_BINARY_SUPPORTED` are now `final`. They can only be
1414
enabled with the system properties of the same names, and no longer at runtime.
15+
- The `TaskService` methods `invokeAll` and `invokeAny` now have the generic signatures of
16+
`ExecutorService` instead of raw types.
17+
- The `ImmutableDate` setters, which always throw, are now marked as `@Deprecated`.
1518
- Bugs fixed
1619
- `Resource.isConfidential()` and `Resource.isLoggable()` threw a `NullPointerException`
1720
when the resource had no request. They now return `false`.
@@ -20,6 +23,8 @@ Changes log
2023
- Misc
2124
- Upgraded Jackson extension to Jackson 3.2.3. The OpenAPI extension remains on Jackson 2
2225
(2.22.3), as required by swagger-core.
26+
- Replaced the deprecated Jetty `ConnectionLimit` with `NetworkConnectionLimit` and Spring's
27+
deprecated `@NonNull`/`@Nullable` with the JSpecify ones.
2328
- Upgraded JUnit library to 6.1.3.
2429
- Upgraded Hamcrest library to 3.0 (`hamcrest` replaces `hamcrest-all`).
2530
- Upgraded OSGi core library to 8.0.0 (`osgi.core` replaces `org.osgi.core`).
@@ -28,6 +33,6 @@ Changes log
2833
- Upgraded Maven to 3.9.16 (also in the Maven wrapper).
2934
- Upgraded all Maven plugins (compiler, surefire, bundle, javadoc, enforcer, spotless, ...).
3035
- The build now enforces Maven 3.9+, Java 21+ and dependency convergence, compiles with
31-
`-Xlint:all` and runs SpotBugs on `verify`.
36+
`-Xlint:all -Werror` (no warnings left) and runs SpotBugs on `verify`.
3237
- CI runs `verify` (Spotless, JaCoCo coverage and SpotBugs checks), fails when tests fail,
3338
publishes coverage reports. GitHub Actions are updated by Dependabot.

‎pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,7 @@
468468
<showWarnings>true</showWarnings>
469469
<compilerArgs>
470470
<arg>-Xlint:all,-this-escape</arg>
471+
<arg>-Werror</arg>
471472
</compilerArgs>
472473
</configuration>
473474
</plugin>

0 commit comments

Comments
 (0)