Add missing 'auto' value for overflow in StyleSheets#57568
Conversation
'auto' is a valid option distinct from all other options and currently requires to do `overflow: 'auto' as any` to avoid a Typescript error
|
Hi @JFs743! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
'auto' is a valid option distinct from all other options and currently requires to do
overflow: 'auto' as anyto avoid a Typescript errorChangelog:
GENERAL ADDED - Add 'auto' as a valid option to StyleSheet's overflow in types (already supported by CSS)
Test Plan:
Have an item with overflow set to 'auto' in a StyleSheet:
Before the fix:
StyleSheetTypes.d.ts(98, 3): The expected type comes from property 'overflow' which is declared here on type 'ViewStyle | TextStyle | ImageStyle'
After the fix: