From 6ef61898040ce38782f685547d7e9c17fbc254c8 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sat, 22 Aug 2026 01:34:46 +0000
Subject: [PATCH] fix: repair failing tests and type errors across monorepo

- bunfig.toml: use valid [test] preload key so happy-dom registers the
  DOM for @testing-library/react (fixes "document is not defined")
- tsconfig.json: add bun-types so `bun:test` imports type-check
- apps/web/src/lib/api.ts: update import/usage of the renamed hook
  useThrottle -> useDebounce
- packages/utils date.ts: formatDate now reassembles via Intl
  formatToParts to emit un-padded day/month with a 4-digit year (1/3/2024)
- packages/ui Button.tsx: apply aria-label to the button, fall back to a
  default for icon-only buttons with no label, and dev-warn on the fallback
---
 apps/web/src/lib/api.ts                      | 13 ++------
 bunfig.toml                                  |  2 +-
 packages/ui/src/components/Button/Button.tsx | 29 ++++++++++++------
 packages/utils/src/format/date.ts            | 32 +++++++++++++-------
 tsconfig.json                                |  1 +
 5 files changed, 46 insertions(+), 31 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..8a635e5 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..0b64f7c 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..1f0bddc 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -14,16 +14,17 @@ type Props = {
   "aria-label"?: string
 }
 
+/** Fallback accessible name used when an icon-only button is missing an `aria-label`. */
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button renders no visible text, so it must carry an `aria-label`
+ * to expose an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value). Callers
+ * should always pass one; when they don't we apply a generic fallback so the
+ * control is never nameless, and warn in development so the omission is fixed
+ * at the call site.
  */
 export function Button({
   children,
@@ -34,13 +35,23 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const missingIconOnlyLabel = iconOnly && !ariaLabel
+
+  if (missingIconOnlyLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      "Button: an icon-only button requires an `aria-label` so screen readers can " +
+        `announce it (WCAG 2.2 SC 4.1.2). Falling back to "${ICON_ONLY_FALLBACK_LABEL}".`,
+    )
+  }
+
+  const accessibleLabel = iconOnly ? ariaLabel ?? ICON_ONLY_FALLBACK_LABEL : ariaLabel
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..7c093d7 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,31 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Formats a date as Australian `D/M/YYYY` — day first, no zero padding on the
+ * day or month, four-digit year (e.g. `1/3/2024`).
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `Intl.DateTimeFormat('en-AU')` cannot produce this directly: requesting a
+ * four-digit numeric year makes ICU select a pattern that zero-pads the day and
+ * month (`01/03/2024`). Formatting to parts and reassembling keeps the
+ * locale-correct day-first ordering while dropping the padding and preserving
+ * the full year.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "numeric",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+
+  const value = (type: Intl.DateTimeFormatPartTypes): string =>
+    parts.find((part) => part.type === type)?.value ?? ""
+
+  const unpadded = (type: Intl.DateTimeFormatPartTypes): string =>
+    String(Number(value(type)))
+
+  return `${unpadded("day")}/${unpadded("month")}/${value("year")}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]