Repository navigation
Conversation
…ff_resonance apps.buda stacks one CartesianSense under FieldCorrected per shot, each at its own sample times and, optionally, its own low-resolution phase (apps.shot_phase), and solves the joint data consistency with the iteration pics would choose. tools.displacement_off_resonance turns a SusceptibilityCorrection's edge-sampled displacement into Hz at the cell centres, f = -b / (n dt); the sign, centring and units are tested against an EPI pair encoded line by line at a known field. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for the 7 T EPI work (exam 5190). Adds two public functions:
apps.buda: blip-up/blip-down EPI solved jointly. Each shot is encoded byCartesianSenseunderFieldCorrectedat its own sample times and, optionally, with its own low-resolution phase (apps.shot_phase). The solve uses the iterationpicswould choose for the regularizers, after a data scaling taken from the adjoint image. This is not a BART command.tools.displacement_off_resonance: turns aSusceptibilityCorrection's displacement (cell edges,voxel_sizeunits) into Hz at the cell centres,f = -b / (n dt). The sign, centring and units are tested against an EPI pair encoded line by line throughCartesianSenseat a known field (test_the_off_resonance_of_a_corrected_epi_pair_is_the_one_that_displaced_it, needs PyHySCO).Validation
Simulation: 8 coils, 128², Ry 2, 0.492 ms per line (series 31 timing), field up to 120 Hz. NRMSE against the truth, within the object:
So the joint model is right, and the field map limits it.
Scanner data, exam 5190 series 32 (192², Ry 2, PF 0.75, GRE maps, 6 virtual coils): BUDA does not work yet. The joint data residual is 0.67 to 0.72 for every field scale tried (0, 0.5, 1, -1 times the HySCO field). Single-shot SENSE residuals are 0.29 per set. The up/down data are therefore inconsistent beyond the field model, and single-shot SENSE with GRE maps already misfits. While doing this I found that the reference volume's k-space was placed 23 rows off. That is fixed in pypulseqpp #230 (27783f9eb), but it does not explain the residuals. Figures:
build/scanner-2026-11-12/epi-fleet-buda/real_fixed_s32.pngandsim_fleet_buda.png(local).Do not wire BUDA into the pulserver EPI recon until a scan shows consistent up/down data.
Cost (one 192² slice, 6 coils, 2 shots, CPU, 8 threads; no CUDA device here)
phase="estimate": 46 s.segments=8with phase estimation: 34 s.Tests
tests/test_apps_buda.py(3) andtests/test_correct_susceptibility.py(13, including 2 new): 16 passed.test_namespace,test_docstrings,test_docsandtest_appstogether with those: 216 passed, 3 skipped. Ruff clean; codespell not run (not installed).🤖 Generated with Claude Code