From d99adcdd3db0579de624b5a434be747bd809d5d3 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 20:10:45 -0700 Subject: [PATCH 1/2] Scope the End-to-End Docstring to a Repository Given by Name EndToEndCase's docstring said the script exits before its first gh call, but with no repository argument configure.sh runs gh repo view to resolve a default before the archived check. The case passes the repository by name, so the docstring now says that. Raised by Copilot on the promotion PR #1850. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index 3a19d61e..f9d60764 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -143,7 +143,10 @@ def test_a_trailing_carriage_return_from_jq_is_stripped(self) -> None: class EndToEndCase(unittest.TestCase): - """The real script, copied whole, exits before its first `gh` call, for apply and check alike.""" + """The real script, copied whole, exits before any `gh` call when given the repository by name. + + Both apply and check are covered. + """ def run_configure(self, status: str, cmd: str) -> subprocess.CompletedProcess[str]: bash = require("bash", "jq") From f937ce290d3ab2a904974af2211b14112386986e Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 20:11:52 -0700 Subject: [PATCH 2/2] Name the Archived Condition in the End-to-End Docstring The docstring gave a repository named on the command line as the only condition, but an active entry goes on to call gh. It now says the repository is archived as well. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index f9d60764..6cd76e15 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -143,9 +143,9 @@ def test_a_trailing_carriage_return_from_jq_is_stripped(self) -> None: class EndToEndCase(unittest.TestCase): - """The real script, copied whole, exits before any `gh` call when given the repository by name. + """Run on an archived repository given by name, the real script exits before any `gh` call. - Both apply and check are covered. + The script is copied whole, and both apply and check are covered. """ def run_configure(self, status: str, cmd: str) -> subprocess.CompletedProcess[str]: