From 768f6ba9dcec8f4f933752397a44c1105fdc5ea0 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 19:51:46 -0700 Subject: [PATCH 1/5] Say the Archived-Exemption Region Makes No gh Call of Its Own The test module's docstring said the region under test runs before gh is ever invoked, but configure.sh resolves a default repository with gh repo view before it when no repository argument is given. What lets the test run without a stub is that the region itself calls no gh, so the docstring now says that. Raised by Copilot on the promotion PR #1850. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index e09b7774..df2097c9 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -3,9 +3,9 @@ The shell is lifted out of the file rather than restated here, so an edit that removes the behavior fails these tests instead of leaving a reimplementation to agree with itself. The -region under test runs before `gh` is ever invoked, so no stub is needed: a cataloged or absent -registry falls through to a marker printed just after the lifted region, and an archived one -exits before reaching it. +region under test makes no `gh` call of its own, the repository it reads being resolved before it, +so no stub is needed: a cataloged or absent registry falls through to a marker printed just after +the lifted region, and an archived one exits before reaching it. """ from __future__ import annotations From d4cea9b8382618c33a66f01c86538c1b4fb6c5ba Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 19:52:58 -0700 Subject: [PATCH 2/5] Scope the No-Stub Claim to the Cases Running the Lifted Region The module docstring said no stub is needed, but the end-to-end case stubs gh and the carriage-return case stubs jq. Only the cases running the lifted region need no gh stub, so the sentence now says that. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index df2097c9..3fd737fa 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -4,8 +4,8 @@ The shell is lifted out of the file rather than restated here, so an edit that removes the behavior fails these tests instead of leaving a reimplementation to agree with itself. The region under test makes no `gh` call of its own, the repository it reads being resolved before it, -so no stub is needed: a cataloged or absent registry falls through to a marker printed just after -the lifted region, and an archived one exits before reaching it. +so the cases running it need no `gh` stub: a cataloged or absent registry falls through to a marker +printed just after the lifted region, and an archived one exits before reaching it. """ from __future__ import annotations From 529f3730a05cf79a3f763eec9e9e92cecce80dc4 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 19:56:15 -0700 Subject: [PATCH 3/5] Split the No-gh-Call Sentence and Name What Runs First The docstring joined two claims with a comma splice and referred to the region with an ambiguous "before it". It now states that the region makes no gh call, then that the script resolves the repository before this region runs. Raised by Copilot on #1854. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index 3fd737fa..455935d2 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -3,9 +3,9 @@ The shell is lifted out of the file rather than restated here, so an edit that removes the behavior fails these tests instead of leaving a reimplementation to agree with itself. The -region under test makes no `gh` call of its own, the repository it reads being resolved before it, -so the cases running it need no `gh` stub: a cataloged or absent registry falls through to a marker -printed just after the lifted region, and an archived one exits before reaching it. +region under test makes no `gh` call of its own. The script resolves the repository before this +region runs, so the cases running it need no `gh` stub: a cataloged or absent registry falls through +to a marker printed just after the lifted region, and an archived one exits before reaching it. """ from __future__ import annotations From eeafd9719ee1eab746c6e0f8f17c1f12d770c6d1 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 19:57:08 -0700 Subject: [PATCH 4/5] Give the Harness, Not the Script, as Why No gh Stub Is Needed The previous wording credited configure.sh's own repository resolution, which never runs in the lifted-region cases, and "the cases running it" could bind to the script, whose end-to-end case does stub gh. The docstring now names the real reason, the harness assigning every variable the region reads, and says "the lifted region" outright. Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index 455935d2..6839b0f0 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -3,9 +3,9 @@ The shell is lifted out of the file rather than restated here, so an edit that removes the behavior fails these tests instead of leaving a reimplementation to agree with itself. The -region under test makes no `gh` call of its own. The script resolves the repository before this -region runs, so the cases running it need no `gh` stub: a cataloged or absent registry falls through -to a marker printed just after the lifted region, and an archived one exits before reaching it. +region under test makes no `gh` call of its own, and the harness assigns every variable it reads. +So the cases running the lifted region need no `gh` stub: a cataloged or absent registry falls +through to a marker printed just after that region, and an archived one exits before reaching it. """ from __future__ import annotations From 42da392779046f907c2df8d630a102cb93fd371c Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 25 Sep 2026 20:01:32 -0700 Subject: [PATCH 5/5] Bind the Variables to the Region Rather Than the Harness "The harness assigns every variable it reads" bound "it" to the harness, which reads nothing. The sentence now says "the region reads". Co-Authored-By: Claude Opus 5.5 (1M context) --- scripts/tests/test_configure_archived.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/tests/test_configure_archived.py b/scripts/tests/test_configure_archived.py index 6839b0f0..3a19d61e 100755 --- a/scripts/tests/test_configure_archived.py +++ b/scripts/tests/test_configure_archived.py @@ -3,9 +3,10 @@ The shell is lifted out of the file rather than restated here, so an edit that removes the behavior fails these tests instead of leaving a reimplementation to agree with itself. The -region under test makes no `gh` call of its own, and the harness assigns every variable it reads. -So the cases running the lifted region need no `gh` stub: a cataloged or absent registry falls -through to a marker printed just after that region, and an archived one exits before reaching it. +region under test makes no `gh` call of its own, and the harness assigns every variable the +region reads. So the cases running the lifted region need no `gh` stub: a cataloged or absent +registry falls through to a marker printed just after that region, and an archived one exits +before reaching it. """ from __future__ import annotations