From 63d0ededd004b38b37cb594acb8ad6de7f278fcb Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 15 Aug 2026 18:47:07 +0200 Subject: [PATCH] chore: Remove unnecessary casts --- .../pmd/eclipse/ui/actions/PMDGenerateASTActionTest.java | 2 +- .../pmd/eclipse/runtime/builder/MarkerUtil.java | 2 +- .../sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java | 2 +- .../pmd/eclipse/runtime/cmd/JobCommandProcessor.java | 8 ++------ .../pmd/eclipse/runtime/cmd/ReviewCodeCmd.java | 4 ++-- .../eclipse/runtime/cmd/ReviewResourceForRuleCommand.java | 2 +- .../pmd/eclipse/ui/actions/CPDCheckProjectAction.java | 2 +- .../pmd/eclipse/ui/actions/ClearReviewsAction.java | 2 +- .../pmd/eclipse/ui/actions/GenerateReportAction.java | 3 ++- .../pmd/eclipse/ui/actions/PMDCheckAction.java | 2 +- .../pmd/eclipse/ui/actions/PMDGenerateASTAction.java | 2 +- .../pmd/eclipse/ui/actions/PMDRemoveMarkersAction.java | 2 +- .../pmd/eclipse/ui/actions/ReviewCodeHandler.java | 2 +- .../net/sourceforge/pmd/eclipse/ui/model/FileRecord.java | 2 +- .../sourceforge/pmd/eclipse/ui/model/FolderRecord.java | 2 +- .../ui/preferences/br/AbstractTreeTableManager.java | 2 +- .../pmd/eclipse/ui/preferences/br/BasicTableManager.java | 2 +- .../pmd/eclipse/ui/preferences/br/MarkerColumnsUI.java | 2 +- .../eclipse/ui/preferences/br/TextColumnDescriptor.java | 2 +- .../pmd/eclipse/ui/properties/PMDProjectPropertyPage.java | 2 +- .../pmd/eclipse/ui/views/actions/MarkerMenuFiller.java | 2 +- .../pmd/eclipse/util/UniqueItemsAsShapeBuilder.java | 2 +- .../main/java/net/sourceforge/pmd/eclipse/util/Util.java | 2 +- 23 files changed, 26 insertions(+), 29 deletions(-) diff --git a/net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTActionTest.java b/net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTActionTest.java index eea262d24..e2ca2e421 100644 --- a/net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTActionTest.java +++ b/net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTActionTest.java @@ -86,7 +86,7 @@ public void run() { } while (astFile == null || (System.currentTimeMillis() - start) > 10_000); Assert.assertNotNull("No AST file has been generated", astFile); - IFile adapter = (IFile) astFile.getAdapter(IFile.class); + IFile adapter = astFile.getAdapter(IFile.class); try (InputStream in = adapter.getContents()) { String content = IOUtils.toString(in, adapter.getCharset()); Assert.assertTrue(content.startsWith("")); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/builder/MarkerUtil.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/builder/MarkerUtil.java index 0654ba072..a7135a976 100755 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/builder/MarkerUtil.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/builder/MarkerUtil.java @@ -128,7 +128,7 @@ public static String messageFor(IMarker marker, String defaultValue) { public static Long createdOn(IMarker marker, long onErrorValue) { try { - return (Long) marker.getCreationTime(); + return marker.getCreationTime(); } catch (CoreException ce) { return onErrorValue; } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java index f124d9aab..329d88def 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/BaseVisitor.java @@ -202,7 +202,7 @@ protected final void reviewResource(IResource resource) { return; } - IFile file = (IFile) resource.getAdapter(IFile.class); + IFile file = resource.getAdapter(IFile.class); if (file == null || file.getFileExtension() == null) { return; } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/JobCommandProcessor.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/JobCommandProcessor.java index ef7a82381..17130c4e4 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/JobCommandProcessor.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/JobCommandProcessor.java @@ -53,9 +53,7 @@ public void processCommand(final AbstractDefaultCommand aCommand) { @Override protected IStatus run(IProgressMonitor monitor) { try { - if (aCommand instanceof AbstractDefaultCommand) { - ((AbstractDefaultCommand) aCommand).setMonitor(monitor); - } + aCommand.setMonitor(monitor); long start = System.currentTimeMillis(); aCommand.execute(); long duration = System.currentTimeMillis() - start; @@ -75,9 +73,7 @@ protected IStatus run(IProgressMonitor monitor) { } }; - if (aCommand instanceof AbstractDefaultCommand) { - job.setUser(((AbstractDefaultCommand) aCommand).isUserInitiated()); - } + job.setUser(aCommand.isUserInitiated()); synchronized (outstanding) { if (count.incrementAndGet() > 10) { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java index 66a42bfaa..2db8ee71d 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java @@ -254,7 +254,7 @@ public void run() { LOG.info("Review code command finished. {} rules were executed against {} files.\n" + "Actual PMD duration is about {}ms, that is about {}ms/file, {}ms/rule, {}ms/filerule", ruleCount, fileCount, pmdDuration, (float) pmdDuration / fileCount, - (float) pmdDuration / ruleCount, (float) pmdDuration / ((long) fileCount * (long) ruleCount)); + (float) pmdDuration / ruleCount, (float) pmdDuration / (fileCount * ruleCount)); } else { LOG.info("Review code command finished. {} rules were executed against {} files. " + "PMD has not been executed.", ruleCount, fileCount); @@ -466,7 +466,7 @@ private ISchedulingRule getSchedulingRule() { } else { ISchedulingRule[] rules = new ISchedulingRule[resources.size()]; for (int i = 0; i < rules.length; i++) { - rules[i] = ruleFactory.markerRule((IResource) resources.get(i)); + rules[i] = ruleFactory.markerRule(resources.get(i)); } rule = new MultiRule(resources.toArray(rules)); } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewResourceForRuleCommand.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewResourceForRuleCommand.java index 7217f4676..c888029bc 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewResourceForRuleCommand.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewResourceForRuleCommand.java @@ -80,7 +80,7 @@ public void reset() { @Override public void execute() { - IFile file = (IFile) resource.getAdapter(IFile.class); + IFile file = resource.getAdapter(IFile.class); beginTask("PMD checking for rule: " + rule.getName(), 1); if (file != null) { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java index d67835e36..e5af201b3 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/CPDCheckProjectAction.java @@ -74,7 +74,7 @@ public void run(final IAction action) { final Object obj = i.next(); if (obj instanceof IAdaptable) { final IAdaptable adaptable = (IAdaptable) obj; - final IProject project = (IProject) adaptable.getAdapter(IProject.class); + final IProject project = adaptable.getAdapter(IProject.class); if (project == null) { LOG.warn("The selected object cannot adapt to a project"); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ClearReviewsAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ClearReviewsAction.java index 4946977a4..4f97e7d7a 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ClearReviewsAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ClearReviewsAction.java @@ -132,7 +132,7 @@ protected void clearReviews() { resource = ((IMarker) object).getResource(); } else if (object instanceof IAdaptable) { IAdaptable adaptable = (IAdaptable) object; - resource = (IResource) adaptable.getAdapter(IResource.class); + resource = adaptable.getAdapter(IResource.class); } else { LOG.warn("The selected object is not adaptable"); LOG.debug(" -> selected object = " + object); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java index a91a467b5..6812a9bf8 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java @@ -105,7 +105,8 @@ public final void run(final IAction action) { private static IProject getProject(IStructuredSelection selection) { Object object = selection.getFirstElement(); if (object instanceof IAdaptable) { - final IResource resource = (IResource) ((IAdaptable) object).getAdapter(IResource.class); + final IAdaptable adaptable = (IAdaptable) object; + final IResource resource = adaptable.getAdapter(IResource.class); if (resource != null) { return resource.getProject(); } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDCheckAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDCheckAction.java index f959e42fd..6e7ef223d 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDCheckAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDCheckAction.java @@ -103,7 +103,7 @@ private void reviewSelectedResources(IStructuredSelection selection) { } private void addAdaptable(ReviewCodeCmd cmd, IAdaptable adaptable) { - IResource resource = (IResource) adaptable.getAdapter(IResource.class); + IResource resource = adaptable.getAdapter(IResource.class); if (resource != null) { cmd.addResource(resource); } else { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTAction.java index 7034f16a2..ec30394ba 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDGenerateASTAction.java @@ -146,7 +146,7 @@ public void run(IProgressMonitor monitor) throws InvocationTargetException, Inte Object element = i.next(); if (element instanceof IAdaptable) { IAdaptable adaptable = (IAdaptable) element; - IResource resource = (IResource) adaptable.getAdapter(IResource.class); + IResource resource = adaptable.getAdapter(IResource.class); if (resource != null) { monitor.subTask(resource.getName()); generateAST((IFile) resource); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDRemoveMarkersAction.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDRemoveMarkersAction.java index f8f0de7d8..dfba1ccc0 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDRemoveMarkersAction.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/PMDRemoveMarkersAction.java @@ -93,7 +93,7 @@ private void processElement(Object element) throws CoreException { LOG.debug("Remove markers on resource " + resource.getName()); } else if (element instanceof IAdaptable) { final IAdaptable adaptable = (IAdaptable) element; - final IResource resource = (IResource) adaptable.getAdapter(IResource.class); + final IResource resource = adaptable.getAdapter(IResource.class); if (resource == null) { LOG.warn("The selected object cannot adapt to a resource"); LOG.debug(" -> selected object : " + element); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ReviewCodeHandler.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ReviewCodeHandler.java index ee7fe8aeb..b63584961 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ReviewCodeHandler.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/actions/ReviewCodeHandler.java @@ -125,7 +125,7 @@ protected final void computeSelectedResources() { } if (!resources.isEmpty()) { - fResources = (IResource[]) resources.toArray(new IResource[0]); + fResources = resources.toArray(new IResource[0]); } } else if (selection instanceof ITextSelection) { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java index 09ace9795..c4d971768 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java @@ -332,7 +332,7 @@ public int getLOC() { */ protected String resourceToString(IResource resource) { final StringBuilder fileContents = new StringBuilder(); - IFile file = (IFile) resource.getAdapter(IFile.class); + IFile file = resource.getAdapter(IFile.class); try (BufferedReader bReader = new BufferedReader(new InputStreamReader(file.getContents(), file.getCharset()))) { // ... and read the File line by line while (bReader.ready()) { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java index 6d362f0d8..f26743b0f 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/model/FolderRecord.java @@ -47,7 +47,7 @@ public AbstractPMDRecord[] getChildren() { @Override public IResource getResource() { - return (IResource) folder; + return folder; } /** diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/AbstractTreeTableManager.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/AbstractTreeTableManager.java index 70734afa9..7c7b964df 100755 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/AbstractTreeTableManager.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/AbstractTreeTableManager.java @@ -372,7 +372,7 @@ protected int headerHeightFor(Control control) { @Override protected void setMenu(Control control, Menu menu) { - ((Tree) control).setMenu(menu); + control.setMenu(menu); } @Override diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/BasicTableManager.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/BasicTableManager.java index 4b8269e03..a5ff2a257 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/BasicTableManager.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/BasicTableManager.java @@ -227,7 +227,7 @@ protected int headerHeightFor(Control control) { @Override protected void setMenu(Control control, Menu menu) { - ((Table) control).setMenu(menu); + control.setMenu(menu); } @Override diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/MarkerColumnsUI.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/MarkerColumnsUI.java index e69db6234..68f3b5a29 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/MarkerColumnsUI.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/MarkerColumnsUI.java @@ -57,7 +57,7 @@ public Image imageFor(IMarker marker) { Util.COMP_INT) { @Override public Integer valueFor(IMarker marker) { - return (Integer) marker.getAttribute(IMarker.LINE_NUMBER, 0); + return marker.getAttribute(IMarker.LINE_NUMBER, 0); } }; diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/TextColumnDescriptor.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/TextColumnDescriptor.java index 73d2e5b70..2a61d0597 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/TextColumnDescriptor.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/TextColumnDescriptor.java @@ -101,7 +101,7 @@ public void handleEvent(Event event) { return; } - Object value = ((TreeItem) event.item).getData(); + Object value = event.item.getData(); if (value == null || value instanceof RuleCollection) { return; } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java index fa78f5586..3be49284e 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/properties/PMDProjectPropertyPage.java @@ -91,7 +91,7 @@ public class PMDProjectPropertyPage extends PropertyPage { protected Control createContents(final Composite parent) { LOG.info("PMD properties editing requested"); controller = new PMDPropertyPageController(getShell()); - final IProject project = (IProject) getElement().getAdapter(IProject.class); + final IProject project = getElement().getAdapter(IProject.class); controller.setProject(project); model = controller.getPropertyPageBean(); diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/MarkerMenuFiller.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/MarkerMenuFiller.java index ccd12482b..4ed1be1c2 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/MarkerMenuFiller.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/views/actions/MarkerMenuFiller.java @@ -39,7 +39,7 @@ public MarkerMenuFiller(ITextEditor thEditor) { } private IVerticalRulerInfo getRulerInfo() { - return (IVerticalRulerInfo) editor.getAdapter(IVerticalRulerInfo.class); + return editor.getAdapter(IVerticalRulerInfo.class); } private List getMarkers() { diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/UniqueItemsAsShapeBuilder.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/UniqueItemsAsShapeBuilder.java index d4802b507..1945a94c4 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/UniqueItemsAsShapeBuilder.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/UniqueItemsAsShapeBuilder.java @@ -117,7 +117,7 @@ public void handleEvent(Event event) { return; } - Object item = ((TreeItem) event.item).getData(); + Object item = event.item.getData(); if (item == null) { return; } diff --git a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/Util.java b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/Util.java index 9879a4561..1953afa18 100644 --- a/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/Util.java +++ b/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/util/Util.java @@ -418,7 +418,7 @@ public void handleEvent(Event event) { GC gc = event.gc; Rectangle area = tree.getClientArea(); - Rule rule = (Rule) ((TreeItem) event.item).getData(); + Rule rule = (Rule) event.item.getData(); String text = getter.valueFor(rule).toString(); int columnCount = tree.getColumnCount();