update pnpm min release - #14
Open
spentacular wants to merge 1 commit into
Open
spentacular wants to merge 1 commit into
spentacular wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 35.88% 35.88%
=======================================
Files 27 27
Lines 1956 1956
Branches 159 159
=======================================
Hits 702 702
Misses 1252 1252
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KetanReddy
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
Adds a minimum release age gate to
pnpm-workspace.yamlso newly published versions of third-party dependencies aren't resolved until they've been on the registry for a while:Why
minimumReleaseAgeis pnpm's mitigation for npm supply-chain attacks. Compromised package versions are typically published, detected, and unpublished/patched within hours — so refusing to install anything younger than a cooldown window means the malicious version is usually gone before we'd ever resolve it. This is the same class of defense that blunted the recent Shai-Hulud-style campaigns.4320minutes (3 days) is a deliberately conservative window — longer than pnpm 11's 24-hour default, since this repo's dependency updates aren't time-sensitive.The three excluded scopes are our own first-party packages (
@player-cli/*,@player-lang/*,@xlr-lib/*). Without the exclusion, every Player release would sit behind a 3-day wait before this repo could consume it, which would make canary andnextverification impractical.minimumReleaseAgeExcludesupports glob patterns as of pnpm v10.17.0.Notes for reviewers
Two things worth confirming before merge — neither is addressed by this diff:
pnpm version.
package.jsonpinspackageManager: [email protected](andengines.pnpm: ^10.13.1).minimumReleaseAge/minimumReleaseAgeExcludewere introduced in pnpm v10.16.0, and glob support in the exclude list landed in v10.17.0. On 10.13.1 these keys are simply unknown settings, so the gate won't take effect until the pinned pnpm is bumped to at least v10.17.0.pnpm-workspace.yamlis generated. The file's header says it's auto-generated byscripts/generate-pnpm-workspace.js, and that script writes the whole file from a template containing only thepackages:list — so running it would silently drop these new settings. Nothing in CI, Bazel, orpackage.jsoncurrently invokes it, so this is latent rather than broken, but the script should either be taught to preserve these keys or removed.Also note dependencies in CI are materialized by
rules_jsnpm_translate_lockfrompnpm-lock.yaml, so this setting governs resolution at lockfile-update time (localpnpm install/pnpm update), not the Bazel fetch of an already-pinned lockfile.Relevant PNPM docs
minimumReleaseAge— units (minutes), defaults, version addedminimumReleaseAgeExclude— pattern matching supportChange Type (required)
Indicate the type of change your pull request is:
patchminormajor