Fix GH-22759: Keep Io\Poll watcher registry in sync#22760
Open
LamentXU123 wants to merge 5 commits into
Open
Conversation
Member
|
fix looks correct to me. |
devnexen
reviewed
Jul 17, 2026
|
|
||
| zend_ulong hash_key = php_io_poll_compute_ptr_key(handle); | ||
| zend_hash_index_add(intern->watchers, hash_key, &watcher_zv); | ||
| if (zend_hash_index_add(intern->watchers, hash_key, &watcher_zv) == NULL) { |
Member
There was a problem hiding this comment.
Can zend_hash_index_add actually fail here? i.e. A duplicate handle hits PHP_POLL_ERR_EXISTS at line 751 first.
Member
Author
There was a problem hiding this comment.
It can't. I wrote this as defensive stuff just in case but I don't spot the duplicate handle tho. Thanks.
ndossche
removed their request for review
July 17, 2026 16:59
Member
|
I removed my request for review. |
arnaud-lb
reviewed
Jul 17, 2026
Co-authored-by: Arnaud Le Blanc <[email protected]>
LamentXU123
marked this pull request as draft
July 17, 2026 17:53
Contributor
|
After last set of changes LGTM |
LamentXU123
marked this pull request as ready for review
July 17, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the watcher from the Context registry when it is explicitly removed. and roll back the backend registration on failure.
Fixed #22759