From 711faa2069cabaeb8b5f55ee57373422222d35a9 Mon Sep 17 00:00:00 2001 From: Xenolphthalein <21215869+Xenolphthalein@users.noreply.github.com> Date: Tue, 17 Nov 2026 08:03:28 +0100 Subject: [PATCH] arm64: dts: qcom: sm8250-pico4-phoenix: drop the home, confirm and app keys PICO OS's device tree declares GPIO keys for home, confirm and app besides volume down. The PICO 4 has only the power and volume buttons: pressing each of them on the headset gives KEY_POWER (pon), KEY_VOLUMEUP (resin) and KEY_VOLUMEDOWN (gpio-keys), and nothing else ever reported an event. Drop the three keys and their pin states. --- .../boot/dts/qcom/sm8250-pico4-phoenix.dts | 64 ++----------------- 1 file changed, 5 insertions(+), 59 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250-pico4-phoenix.dts b/arch/arm64/boot/dts/qcom/sm8250-pico4-phoenix.dts index df98793700bb..f1fa0f638941 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-pico4-phoenix.dts +++ b/arch/arm64/boot/dts/qcom/sm8250-pico4-phoenix.dts @@ -52,15 +52,15 @@ }; /* - * The stock tree's GPIO keys, with its labels and codes (its "volume_up" sends - * KEY_VOLUMEDOWN, as on PICO OS). + * The stock tree's GPIO key, with its label and code (its "volume_up" sends + * KEY_VOLUMEDOWN, as on PICO OS). The stock tree also declares home, confirm and + * app keys; the PICO 4 has no such buttons and nothing drives their lines. */ gpio-keys { compatible = "gpio-keys"; label = "gpio-keys"; pinctrl-names = "default"; - pinctrl-0 = <&key_vol_up_default>, <&key_home_default>, <&key_confirm_default>, - <&app_key_default>; + pinctrl-0 = <&key_vol_up_default>; key-volume-up { label = "volume_up"; @@ -71,36 +71,6 @@ debounce-interval = <15>; linux,can-disable; }; - - key-confirm { - label = "confirm_key"; - gpios = <&pm8150_gpios 7 GPIO_ACTIVE_LOW>; - linux,input-type = ; - linux,code = ; - wakeup-source; - debounce-interval = <15>; - linux,can-disable; - }; - - key-home { - label = "home"; - gpios = <&pm8150_gpios 1 GPIO_ACTIVE_LOW>; - linux,input-type = ; - linux,code = ; - wakeup-source; - debounce-interval = <15>; - linux,can-disable; - }; - - key-app { - label = "app_key"; - gpios = <&tlmm 40 GPIO_ACTIVE_LOW>; - linux,input-type = ; - linux,code = ; - wakeup-source; - debounce-interval = <15>; - linux,can-disable; - }; }; reserved-memory { @@ -458,15 +428,7 @@ input-disable; }; - /* The keys' pins as the stock tree configures them. */ - key_home_default: key-home-default-state { - pins = "gpio1"; - function = "normal"; - input-enable; - bias-pull-up; - power-source = <0>; - }; - + /* The key's pin as the stock tree configures it. */ key_vol_up_default: key-vol-up-default-state { pins = "gpio6"; function = "normal"; @@ -474,14 +436,6 @@ bias-pull-up; power-source = <1>; }; - - key_confirm_default: key-confirm-default-state { - pins = "gpio7"; - function = "normal"; - input-enable; - bias-pull-up; - power-source = <1>; - }; }; /* @@ -868,14 +822,6 @@ bias-pull-down; }; - /* The app key's pin as the stock tree configures it. */ - app_key_default: app-key-default-state { - pins = "gpio40"; - function = "gpio"; - drive-strength = <6>; - bias-pull-up; - }; - /* The stock panel pins: the reset (75) and its neighbour 60, driven at 8 mA. */ display_reset_default: display-reset-default-state { pins = "gpio75", "gpio60";