From 83fae4d9ba563ef61e72cb9c59e692e52ad205b3 Mon Sep 17 00:00:00 2001 From: Eric Wei Date: Wed, 2 Sep 2026 23:40:40 +0000 Subject: [PATCH] test(integ-test): stabilize floating window SUM correctness cases The SQL correctness runner compares OpenSearch with H2 and SQLite after rounding floating cells to two decimals with CEILING. The legacy SQL engine keeps SUM(FLOAT) in single precision, so multi-shard merge order can move the result across a cent boundary even though the window is correct. Cast the summed operand to DOUBLE in the two affected window queries. This keeps the tests focused on window behavior without requiring an exact cent from an order-dependent float32 accumulator. The ordered case also had no outer ORDER BY. Its internal window ordering contains 17 FlightDelayMin=0 peers, so the harness compared a shard-dependent physical row order positionally. Add a unique outer ordering using FlightNum without changing the internal RANGE window frame. Signed-off-by: Eric Wei --- integ-test/src/test/resources/correctness/queries/window.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/integ-test/src/test/resources/correctness/queries/window.txt b/integ-test/src/test/resources/correctness/queries/window.txt index 2d0d9d34906..7c56882ce63 100644 --- a/integ-test/src/test/resources/correctness/queries/window.txt +++ b/integ-test/src/test/resources/correctness/queries/window.txt @@ -5,7 +5,7 @@ SELECT DistanceMiles, ROW_NUMBER() OVER (ORDER BY DistanceMiles DESC) AS num FRO SELECT DistanceMiles, RANK() OVER (ORDER BY DistanceMiles DESC) AS rnk FROM opensearch_dashboards_sample_data_flights SELECT DistanceMiles, DENSE_RANK() OVER (ORDER BY DistanceMiles DESC) AS rnk FROM opensearch_dashboards_sample_data_flights SELECT DistanceMiles, COUNT(DistanceMiles) OVER () AS num FROM opensearch_dashboards_sample_data_flights -SELECT DistanceMiles, SUM(DistanceMiles) OVER () AS num FROM opensearch_dashboards_sample_data_flights +SELECT DistanceMiles, SUM(CAST(DistanceMiles AS DOUBLE)) OVER () AS num FROM opensearch_dashboards_sample_data_flights SELECT DistanceMiles, AVG(DistanceMiles) OVER () AS num FROM opensearch_dashboards_sample_data_flights SELECT DistanceMiles, MAX(DistanceMiles) OVER () AS num FROM opensearch_dashboards_sample_data_flights SELECT DistanceMiles, MIN(DistanceMiles) OVER () AS num FROM opensearch_dashboards_sample_data_flights @@ -13,7 +13,7 @@ SELECT AvgTicketPrice, STDDEV_POP(AvgTicketPrice) OVER () AS num FROM opensearch SELECT AvgTicketPrice, STDDEV_SAMP(AvgTicketPrice) OVER () AS num FROM opensearch_dashboards_sample_data_flights SELECT AvgTicketPrice, VAR_POP(AvgTicketPrice) OVER () AS num FROM opensearch_dashboards_sample_data_flights SELECT AvgTicketPrice, VAR_SAMP(AvgTicketPrice) OVER () AS num FROM opensearch_dashboards_sample_data_flights -SELECT FlightDelayMin, DistanceMiles, SUM(DistanceMiles) OVER (ORDER BY FlightDelayMin) AS num FROM opensearch_dashboards_sample_data_flights +SELECT FlightDelayMin, DistanceMiles, SUM(CAST(DistanceMiles AS DOUBLE)) OVER (ORDER BY FlightDelayMin) AS num FROM opensearch_dashboards_sample_data_flights ORDER BY FlightDelayMin, DistanceMiles, FlightNum SELECT FlightDelayMin, DistanceMiles, AVG(DistanceMiles) OVER (ORDER BY FlightDelayMin) AS num FROM opensearch_dashboards_sample_data_flights SELECT FlightDelayMin, DistanceMiles, MAX(DistanceMiles) OVER (ORDER BY FlightDelayMin) AS num FROM opensearch_dashboards_sample_data_flights SELECT FlightDelayMin, DistanceMiles, MIN(DistanceMiles) OVER (ORDER BY FlightDelayMin) AS num FROM opensearch_dashboards_sample_data_flights