Repository navigation
fix(embed): reject unsupported bases in empty repositories - #331
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
embedreports success for unsupported embedding bases when a repository has no embedding tasks.User Impact
Unsupported bases now fail with a diagnostic naming the supported choices, even for empty repositories. All three supported bases still allow successful empty runs. Configuration and clustering continue to accept externally supplied vector bases.
Why This Change Was Made
Use the store's existing supported-basis predicate before API-key resolution and task selection, replacing the legacy-only guard and its obsolete diagnostic. Replace the weak legacy-basis assertion with a focused empty-archive regression. Update the changelog and cleanup ledger.
Evidence