From 935cb7c9099124d8ba6a456a390193d7ae0fdeb4 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Sat, 5 Sep 2026 17:39:44 +0000 Subject: [PATCH] build: fix quiet default for make builds The Makefile documents quiet output unless V=1 and sets `V ?= 0`, but it forwards `V=$(V)` to the gyp-generated makefile, which tests `ifdef V`. "0" is a non-empty value there, so every make build has printed the full compiler command lines regardless. Default V to empty so the sub-make takes its quiet_ rules; `make V=1` and V=1 in the environment stay verbose, and the ninja and cpplint checks already compare against 1. Refs: https://github.com/nodejs/node/pull/26740 Refs: https://github.com/nodejs/build/issues/4419 Signed-off-by: Shelley Vohr --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a354f55ab28e..1d6233f09e47 100644 --- a/Makefile +++ b/Makefile @@ -98,7 +98,7 @@ BUILD_RELEASE_FLAGS ?= $(BUILD_DOWNLOAD_FLAGS) $(BUILD_INTL_FLAGS) # Default to quiet/pretty builds. # To do verbose builds, run `make V=1` or set the V environment variable. -V ?= 0 +V ?= # Use -e to double check in case it's a broken link available-node = \