Skip to content

Segfaults with [await] using within node core #64230

Description

@Renegade334

js_explicit_resource_management is still a flagged feature in V8. We cannot depend on it in core.

Encountering [await] using in core will segfault if running in an environment without js_shipping features.

> out/Release/node --no-js-explicit-resource-management --eval 'diagnostics_channel.tracingChannel("foo").traceSync(() => {})'
[1]    160425 segmentation fault (core dumped)  out/Release/node --no-js-explicit-resource-management --eval

(This only applies to core, not the test suite.)

  • We should convert cases added by diagnostics_channel: add BoundedChannel and scopes #61680 from
    {
      using _ = blah;
      ...
    }
    to
    {
      const _ = blah;
      try {
        ...
      } finally {
        _[Symbol.dispose]();
      }
    }
    (cc @Qard)
  • I'll add an eslint rule to cover it.
  • Should we be doing a GHA CI run with --no-js-shipping in the global test options?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions