feat(deps): Add Nextcloud 36 support on main

[nickvergessen]

Signed-off-by: Joas Schilling [email protected]

[coderabbitai]

Warning

Review limit reached

Next included review available in 11 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c74248b7-0b56-4eeb-8299-239233fddfd3

📥 Commits

Reviewing files that changed from the base of the PR and between bedbcb9 and 8389abe.

📒 Files selected for processing (1)

• lib/Command/ExAppConfig/GetConfig.php

📝 Walkthrough

Walkthrough

The application and package versions now target 36.0.0-dev.0. The application requires Nextcloud 36. Composer and vendor tools now target PHP 8.3, and contributor documentation requires PHP 8.3 or newer. Configuration fallback handling and a daemon deployment migration were updated. Dependabot checks stable35 weekly and ignores major and minor updates. The npm audit workflow now includes stable35.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description contains only a sign-off line and does not describe the Nextcloud 36 support changes.	Add a short summary of the changes, such as the Nextcloud 36 version updates, PHP 8.3 requirement, and related workflow and migration updates.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding Nextcloud 36 support to the main branch.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 17900a69-64d8-4b58-89d6-8a221ada1ec5

📥 Commits

Reviewing files that changed from the base of the PR and between e35decb and 7c45f51.

⛔ Files ignored due to path filters (2)

• composer.lock is excluded by !**/*.lock
• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

• .github/dependabot.yml
• .github/workflows/npm-audit-fix.yml
• appinfo/info.xml
• composer.json
• package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

[kyteinsky]

/compile

[kyteinsky]

Error: lib/Migration/Version2000Date20240120094952.php:48:13: UndefinedInterfaceMethod: Method OCP\DB\Schema\ITable::changeColumn does not exist (see https://psalm.dev/181)

should be fixed with #972

fixed it here since that PR has conflicts anyway

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d7e4c88-4d97-441c-ae4c-3f647fc2eb21

📥 Commits

Reviewing files that changed from the base of the PR and between 7c45f51 and 96e3bc4.

⛔ Files ignored due to path filters (3)

• composer.lock is excluded by !**/*.lock
• vendor-bin/openapi-extractor/composer.lock is excluded by !**/*.lock
• vendor-bin/phpunit/composer.lock is excluded by !**/*.lock

📒 Files selected for processing (7)

• .github/workflows/lint.yml
• AGENTS.md
• composer.json
• js/app_api-adminSettings.js.license
• js/app_api-filesplugin.js.license
• vendor-bin/openapi-extractor/composer.json
• vendor-bin/phpunit/composer.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 329e425f-bdbb-4bc2-8b7d-2105fa89f455

📥 Commits

Reviewing files that changed from the base of the PR and between 96e3bc4 and bedbcb9.

📒 Files selected for processing (4)

• lib/Command/ExAppConfig/GetConfig.php
• lib/Migration/Version2000Date20240120094952.php
• psalm.xml
• tests/psalm-baseline.xml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.