Currently on merge the server takes the state variable, sends emails, does the merge, then updates the state. That can mean there are 5 minutes when the user can visit the web page and it shows the code is not merged, and yet they have an email saying it was merged. Generally, emails should lag the web page.
Solution is probably to replace the emailNotify function in oven with one that queues things up and sends them after. At the same time I can refactor to make emailNotify total and then not worry about error handling.
Currently on merge the server takes the state variable, sends emails, does the merge, then updates the state. That can mean there are 5 minutes when the user can visit the web page and it shows the code is not merged, and yet they have an email saying it was merged. Generally, emails should lag the web page.
Solution is probably to replace the emailNotify function in oven with one that queues things up and sends them after. At the same time I can refactor to make emailNotify total and then not worry about error handling.