Repository navigation
ci: run staged-build e2e without the Vercel bypass secret; skip owner-keyed CLI smokes on service-role - #701
Merged
Merged
Conversation
Preview's LOREKIT_SMOKE_TOKEN is service-role, and protect/pin/unpin/policy/groom refuse a credential with no owner — the same skip the hosted MCP smoke and purge already make. This failed smoke-preview on the #700 deploy run.
Deployment Protection is off for the web project, so the staged URL is public. Drop the bypass-secret gate from e2e-web-staged (it ran unconditionally-skipped) and the bypass header plumbing from packages/web-e2e. Traces stay off for any production-target run.
Contributor
|
Darkplane Automerge did not approve this pull request. It scored 68.02 of 100, and 75 was required.
The other 2 criteria
An AI evaluator produced these scores from the diff, the repository history, and the pull request text. The pull request text is author-controlled, so treat the scores as signals rather than proof. Reviewed for commit 053efa7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deploy run 39121682238 (the #700 merge) showed two problems:
e2e-web-stagedskipped. It waited forVERCEL_AUTOMATION_BYPASS_SECRET. Deployment Protection is now off for the web project, so the staged URL is public and the secret is gone.smoke-previewfailed on the new CLI lane. Preview'sLOREKIT_SMOKE_TOKENis service-role, andprotect/pin/unpin/policy/groomrefuse a credential with no owner. Production was not promoted.What changed
deploy.yml: removes the bypass gate step and the per-step secret env frome2e-web-staged, so the job now always runs.packages/web-e2e: removes the bypass header route,originHeaders()andVERCEL_BYPASS_SECRET. Traces stay off for anyproduction-target run, staged build included.packages/cli/test/smoke/cases.mjs: the owner-keyed cases skip on a service-role token, the same waypurgeand the hosted MCP smoke already do.docs/smoke-tests.md: drops the secret row.How to verify
playwright test --project=publicagainst the live staged buildlorekit-mmha4hvcx…vercel.appwith no bypass header: 34 passed, 1 skipped.pnpm nx typecheck web-e2e,pnpm nx test web-e2e,pnpm nx lint web-e2eandnode --test packages/cli/test/cli-smoke.test.mjs(42/42). All pass.actionlint: no new findings. The two SC2129 style notes are already on main.User-facing docs/llms.txt: none applied, because this changes CI wiring and tests only.