Repository navigation
feature/Errors · L-261028-7b7f90 — vendor registry 8.0.1 titles - #105
Merged
Merged
Conversation
Vendor the registry snapshot from the standard's v8.0.1 release (commit fdfedc5356ea88a9647a262711dd477c4b1c7a71) and regenerate mthds/protocol/problem/registry.py from it. The release rewords the titles of the codes a run can raise, and the next steps they give a reader other than the method's author, for someone following a run of a method they did not write; no code, domain, retry verdict, step kind or status changes. CORE_ERROR_REGISTRY_VERSION moves to 8.0.1, and with it the version pins in tests/unit/test_versions.py and the shared reading cases, none of which uses a reworded code. The docs name the registry 8.0.1. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_019TF9N1QfNEKCTsX1Q6NCf1
MTHDS_STANDARD_VERSION moves to 8.0.1 and PROTOCOL_VERSION to 2.0.1, the numbers the standard's v8.0.1 release states, so a manifest asking for >=8.0.1, as the standard's own examples now do, is satisfied. The pinned native set is unchanged in v8.0.1, so an implementation of 8.0.1 still materializes the set pinned before it. Protocol 2.0.1 states the order of a files map's refusals: a key refused by its name collides with nothing and has no entry checks, and a hash entry's bytes are checked last. read_file_map already ran its checks in that order; the method-tree corpus is vendored again from conformance, whose new map cases pin it, and every one of them passes. The VersionInfo blob_store description, docs/runners.md and docs/method-tree.md take the clarified wording. The vendoring script's --ref example names v8.0.1. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_019TF9N1QfNEKCTsX1Q6NCf1
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
8.0.1, Protocol2.0.1and core error registry8.0.1.mthds_versioncaps the standard at8.0.0(an exact8.0.0, or<=8.0.0) is no longer satisfied;>=8.0.0,^8.0.0and~8.0.0still are.Behaviour changes
pipe.output_invalid's title: "A pipe's output does not fit its concept" → "A step's result does not have the structure the method declares", and likewise for the other codes a run can raise, with theirothersteps naming the step rather than the pipe.MTHDS_STANDARD_VERSION:8.0.0→8.0.1, so a manifest asking>=8.0.1, as the standard's own examples now read, is satisfied.PROTOCOL_VERSION:2.0.0→2.0.1.read_file_mapalready refused a files map in the order Protocol 2.0.1 states, so no code changed for it.Breaking changes
8.0.0, or capped at it, must widen itsmthds_versionconstraint.Changes
Error registry
v8.0.1(commitfdfedc5), with its sidecar, invendor/mthds-error-registry/, and regeneratedmthds/protocol/problem/registry.py.CORE_ERROR_REGISTRY_VERSIONis8.0.1inmthds/protocol/protocol.py, and the sharedtests/data/problem-reading-cases.jsonrecords it.Versions
MTHDS_STANDARD_VERSIONinmthds/package/manifest/schema.pyandPROTOCOL_VERSIONinmthds/protocol/protocol.py, withtests/unit/test_versions.pypinning both and gaining the>=8.0.1and exact8.0.0cases.VersionInfo.blob_store's description inmthds/protocol/models.pyfollows the protocol document's new wording.Method tree
tests/fixtures/method_tree_corpus.json), which brings the three cases pinning the files map's refusal order; all pass.How it was verified
make agent-check: ruff, pyright, mypy andcheck-error-registrygreen.make agent-test: all tests passed.make check-error-registry-upstream MTHDS=… REF=v8.0.1: the vendored registry is the one mthdsv8.0.1publishes./revprofile 2 (cubic, Codex, code-review): clean, converged at round 1.Documentation
docs/versioning.md: the vendoring example namesv8.0.1, and the standard and protocol numbers it quotes are current.docs/runners.md: arequest.blobs_missinganswer comes only for a files map that breaks no other rule.docs/method-tree.md: the order of a files map's checks.Not done
mthdspin onto this package's next release; each is its own item under the same epic.Closes L-261028-7b7f90
🤖 Generated with Claude Code
https://claude.ai/code/session_019TF9N1QfNEKCTsX1Q6NCf1
Summary by cubic
Vendors the MTHDS core error registry v8.0.1 and follows the standard's full v8.0.1 cut, bumping the standard (
8.0.1), protocol (2.0.1), and registry (8.0.1) versions. Error titles and the next steps for someone other than the method's author are reworded, for examplepipe.output_invalidnow reads "A step's result does not have the structure the method declares" and other-reader steps name the step rather than the pipe; no code, domain, retry verdict, step kind, or status changes.Breaking changes
mthds_versionpins exactly8.0.0or caps at<=8.0.0is no longer satisfied;>=8.0.0,^8.0.0, and~8.0.0still pass.Written for commit fe681ef. Summary will update on new commits.