From f31cac5d5508e84c733cb8054e0a201238293894 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 4 Sep 2026 14:41:22 +0100 Subject: [PATCH] feat: generate globalTimeout, drop the job timeout from the workflow References: https://github.com/microsoft/playwright/issues/42533 --- assets/github-actions.yml | 1 - assets/playwright-ct.config.js | 2 ++ assets/playwright-ct.config.ts | 2 ++ assets/playwright.config.js | 2 ++ assets/playwright.config.ts | 2 ++ 5 files changed, 8 insertions(+), 1 deletion(-) diff --git a/assets/github-actions.yml b/assets/github-actions.yml index aff9444..5885ac5 100644 --- a/assets/github-actions.yml +++ b/assets/github-actions.yml @@ -6,7 +6,6 @@ on: branches: [ main, master ] jobs: test: - timeout-minutes: 60 runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 diff --git a/assets/playwright-ct.config.js b/assets/playwright-ct.config.js index 881142e..18fe384 100644 --- a/assets/playwright-ct.config.js +++ b/assets/playwright-ct.config.js @@ -16,6 +16,8 @@ module.exports = defineConfig({ forbidOnly: !!process.env.CI, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, + /* Limit the whole test run, so that it fails with a report instead of hanging. */ + globalTimeout: 60 * 60 * 1000, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ diff --git a/assets/playwright-ct.config.ts b/assets/playwright-ct.config.ts index b89cefa..12937bb 100644 --- a/assets/playwright-ct.config.ts +++ b/assets/playwright-ct.config.ts @@ -15,6 +15,8 @@ export default defineConfig({ forbidOnly: !!process.env.CI, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, + /* Limit the whole test run, so that it fails with a report instead of hanging. */ + globalTimeout: 60 * 60 * 1000, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ diff --git a/assets/playwright.config.js b/assets/playwright.config.js index 3e2be33..c0d0836 100644 --- a/assets/playwright.config.js +++ b/assets/playwright.config.js @@ -20,6 +20,8 @@ export default defineConfig({ forbidOnly: !!process.env.CI, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, + /* Limit the whole test run, so that it fails with a report instead of hanging. */ + globalTimeout: 60 * 60 * 1000, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ diff --git a/assets/playwright.config.ts b/assets/playwright.config.ts index 1977879..19754de 100644 --- a/assets/playwright.config.ts +++ b/assets/playwright.config.ts @@ -19,6 +19,8 @@ export default defineConfig({ forbidOnly: !!process.env.CI, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, + /* Limit the whole test run, so that it fails with a report instead of hanging. */ + globalTimeout: 60 * 60 * 1000, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */