From 08bb24ca4dc3b327d7594f3346ed2b26131ee256 Mon Sep 17 00:00:00 2001 From: Bhagirath Mehta Date: Thu, 19 Nov 2026 12:03:51 -0600 Subject: [PATCH] Restore sanitizer constructor-order diagnostics The pinned sanitizer already initializes members in declaration order, so remove the obsolete suppression and its stale rationale. Files: lib/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7e2f450-c2c4-43c5-9fb1-05fa4f7d8e9e --- lib/CMakeLists.txt | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt index d44de8ab6..40228d206 100644 --- a/lib/CMakeLists.txt +++ b/lib/CMakeLists.txt @@ -154,15 +154,6 @@ if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/modules/sanitizer/" AND MATSDK_BUILD_SANI modules/sanitizer/SanitizerTrie.cpp modules/sanitizer/SanitizerTrieNode.cpp ) - # Suppress -Wreorder for Sanitizer.cpp only: the submodule declares - # m_sanitizerprovider before m_notificationEventName in Sanitizer.hpp - # but the constructor init list reverses that order. The proper fix - # belongs in the lib/modules submodule; this scopes the suppression - # until that is done. - if(NOT MSVC) - set_source_files_properties(modules/sanitizer/Sanitizer.cpp - PROPERTIES COMPILE_FLAGS "-Wno-reorder") - endif() endif() set(MATSDK_OBJC_PRIVACYGUARD_AVAILABLE OFF)