From eefe10ec357ef031882a41686ea7790c48deef9b Mon Sep 17 00:00:00 2001 From: CodemodService CodemodConfigDisabledTests Date: Mon, 16 Nov 2026 11:02:54 -0800 Subject: [PATCH] fbcode/ax/storage/sqa_store/tests (#5320) Summary: Pull Request resolved: https://github.com/meta/Ax/pull/5320 Reviewed By: saitcakmak Differential Revision: D130867536 --- .../tests/test_with_db_settings_base.py | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/ax/storage/sqa_store/tests/test_with_db_settings_base.py b/ax/storage/sqa_store/tests/test_with_db_settings_base.py index 7d13190f9ca..ea312b7e748 100644 --- a/ax/storage/sqa_store/tests/test_with_db_settings_base.py +++ b/ax/storage/sqa_store/tests/test_with_db_settings_base.py @@ -454,23 +454,3 @@ def test_module_level_dbsettings_is_defined(self) -> None: "with_db_settings_base.DBSettings is None -- guard removal regressed", ) self.assertIs(module_dbsettings, DBSettings) - - def test_sa_major_matches_buck_target(self) -> None: - """When the BUCK target sets EXPECTED_SA_MAJOR, assert the runtime - SQLAlchemy major matches. Makes :tests vs :tests_sa2 self-proving. - Skipped when EXPECTED_SA_MAJOR is unset (e.g., local one-off invocations). - """ - expected_major_str = os.environ.get("EXPECTED_SA_MAJOR") - if expected_major_str is None: - self.skipTest( - "EXPECTED_SA_MAJOR not set; only enforced under the dual-version " - "BUCK targets that pin SQLAlchemy via constraint_overrides" - ) - actual_version = sqlalchemy.__version__ - actual_major = int(actual_version.split(".")[0]) - self.assertEqual( - actual_major, - int(expected_major_str), - f"BUCK target expected SQLAlchemy major {expected_major_str}, " - f"got {actual_version}", - )