BaseServer: defensive handling for failed ServerSocket creation — set RUNNING=false in constructors on error and skip run() if SERVER_SOCKET is null to avoid NPE loop\n\nCo-authored-by: Copilot <[email protected]>

Author: mearvk

source/server/base/BaseServer.java

@@ -56,6 +56,8 @@ public BaseServer(String host, Integer PORT)
         {
             e.printStackTrace(System.err);
 
+            this.RUNNING = false;
+
             return;
         }
 
@@ -67,6 +69,9 @@ public BaseServer(String host, Integer PORT)
         {
             e.printStackTrace(System.err);
 
+            // mark as not running so run() will not attempt accept on a null socket
+            this.RUNNING = false;
+
             return;
         }
         finally
@@ -91,6 +96,8 @@ public BaseServer(Integer PORT)
         {
             e.printStackTrace(System.err);
 
+            this.RUNNING = false;
+
             return;
         }
 
@@ -102,11 +109,13 @@ public BaseServer(Integer PORT)
         {
             e.printStackTrace(System.err);
 
+            this.RUNNING = false;
+
             return;
         }
         finally
         {
-            CommonRails.printSystemComponent(this, this.hashCode(), "[WebExpress::BaseServer] [Server created on Port ["+this.PORT +"]]");
+            CommonRails.printSystemComponent(this, this.hashCode(), "[WebExpress::BaseServer] [Server created on Port ["+this.PORT+"]]" );
         }
     }
 
@@ -115,6 +124,14 @@ public void run()
     {
         try
         {
+            // Defensive: if server socket failed to initialize the constructor set RUNNING=false;
+            if (this.SERVER_SOCKET == null)
+            {
+                CommonRails.printSystemComponent(this, this.hashCode(), "[WebExpress::BaseServer] [SERVER_SOCKET is null; server not started]");
+
+                return;
+            }
+
             while(RUNNING)
             {
                 Connection connection;