diff --git a/evals/promises/ledger.json b/evals/promises/ledger.json index c69d1609..6d6313ab 100644 --- a/evals/promises/ledger.json +++ b/evals/promises/ledger.json @@ -437,7 +437,7 @@ }, "babysit-body-only-finding-acknowledged-in-pr-comment": { "check": "script", - "claim": "The watcher stops with the review-findings blocker (exit 8) on a bot review body that reports a finding with no thread, until a PR comment from the author or a maintainer contains that review's URL.", + "claim": "The watcher stops with the review-findings blocker (exit 8) on a bot review body that reports a finding with no thread, until the author or a maintainer posts a PR comment that contains that review's URL and does not open with the pr-recap start marker.", "harness_sensitive": false, "owners": [ "skills/poteto-mode/scripts/watch-pr/policy.ts", diff --git a/evals/promises/test_scripts.py b/evals/promises/test_scripts.py index 679f23be..9803fbeb 100644 --- a/evals/promises/test_scripts.py +++ b/evals/promises/test_scripts.py @@ -756,6 +756,7 @@ def test_babysit_body_only_finding_acknowledged_in_pr_comment(self): "a link from a stranger": self.comment(f"See {REVIEW_URL}", login="mallory", association="NONE", n=2), "a link from a bot": self.comment(f"See {REVIEW_URL}", login="helper-bot", association="MEMBER", kind="Bot", n=2), "a link to a longer review id": self.comment(f"See {REVIEW_URL}9", login="alice", association="NONE", n=2), + "a pr-recap comment from the author": self.comment(f"\n\nSee {REVIEW_URL}.\n", login="alice", association="NONE", n=2), } for label, comment in not_acknowledgments.items(): with self.subTest(label):