diff --git a/CDPIUI.Tests/CDPIUI.Tests.csproj b/CDPIUI.Tests/CDPIUI.Tests.csproj index e578a2e8..3b5adc66 100644 --- a/CDPIUI.Tests/CDPIUI.Tests.csproj +++ b/CDPIUI.Tests/CDPIUI.Tests.csproj @@ -59,6 +59,9 @@ + + + diff --git a/CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs b/CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs new file mode 100644 index 00000000..dfe34a86 --- /dev/null +++ b/CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs @@ -0,0 +1,429 @@ +using CDPIUI.ViewModels.ConfigMaker; + +namespace CDPIUI.Tests.Presentation; + +public sealed class ConfigMakerStatusPresentationTests +{ + private enum Severity { Information = 11, Warning = 27, Error = 49 } + + [Fact] + public void Constructor_keeps_explicit_initial_values_and_does_not_call_ports() + { + var state = new ConfigMakerStatusPresentation(Severity.Information, + _ => throw new InvalidOperationException("title"), + (_, _, _) => throw new InvalidOperationException("notice"), + () => throw new InvalidOperationException("inline")); + + Assert.Equal(string.Empty, state.StatusTitle); + Assert.Equal(string.Empty, state.StatusMessage); + Assert.Equal(Severity.Information, state.StatusSeverity); + Assert.False(state.IsStatusOpen); + } + + [Fact] + public void Constructor_only_stores_even_null_ports() + { + var state = new ConfigMakerStatusPresentation((Severity)863, null!, null!, null!); + Assert.Equal((Severity)863, state.StatusSeverity); + Assert.Equal(string.Empty, state.StatusTitle); + Assert.Equal(string.Empty, state.StatusMessage); + Assert.False(state.IsStatusOpen); + } + + [Fact] + public void Setters_publish_current_values_with_owner_sender_and_suppress_equal_values() + { + var f = new Fixture(); + var seen = new List<(string?, object?)>(); + f.State.PropertyChanged += (sender, e) => + { + Assert.Same(f.State, sender); + seen.Add((e.PropertyName, e.PropertyName switch + { + nameof(f.State.StatusTitle) => f.State.StatusTitle, + nameof(f.State.StatusMessage) => f.State.StatusMessage, + nameof(f.State.StatusSeverity) => f.State.StatusSeverity, + nameof(f.State.IsStatusOpen) => f.State.IsStatusOpen, + _ => throw new InvalidOperationException("Unexpected property") + })); + }; + f.State.StatusTitle = "title"; + f.State.StatusTitle = new string("title".ToCharArray()); + f.State.StatusTitle = null; + f.State.StatusTitle = null; + f.State.StatusMessage = "message"; + f.State.StatusMessage = new string("message".ToCharArray()); + f.State.StatusMessage = null; + f.State.StatusMessage = null; + f.State.StatusSeverity = (Severity)999; + f.State.StatusSeverity = (Severity)999; + f.State.StatusSeverity = Severity.Information; + f.State.IsStatusOpen = true; + f.State.IsStatusOpen = true; + f.State.IsStatusOpen = false; + f.State.IsStatusOpen = false; + + Assert.Equal(new (string?, object?)[] + { + ("StatusTitle", "title"), ("StatusTitle", null), + ("StatusMessage", "message"), ("StatusMessage", null), + ("StatusSeverity", (Severity)999), ("StatusSeverity", Severity.Information), + ("IsStatusOpen", true), ("IsStatusOpen", false) + }, seen); + Assert.Equal(0, f.InlineReads); + Assert.DoesNotContain(f.Trace, item => item is "title" or "notice" or "inline"); + } + + [Theory] + [InlineData(11)] + [InlineData(27)] + [InlineData(49)] + [InlineData(999)] + public void Show_resolves_then_notifies_then_reads_inline_before_ordered_publication(int severityValue) + { + var f = new Fixture(); + var severity = (Severity)severityValue; + f.Notice = (value, title, message) => + { + Assert.Equal(severity, value); + Assert.Equal($"title:{severityValue}", title); + Assert.Equal("message", message); + Assert.Equal((string.Empty, string.Empty, Severity.Information, false), f.Values); + }; + f.State.Show("message", severity); + + var expected = new List { "title", "notice", "inline", "StatusTitle", "StatusMessage" }; + if (severity != Severity.Information) expected.Add("StatusSeverity"); + expected.Add("IsStatusOpen"); + Assert.Equal(expected, f.Trace); + Assert.Equal(($"title:{severityValue}", "message", severity, true), f.Values); + Assert.Equal(1, f.InlineReads); + } + + [Theory] + [InlineData(null, null)] + [InlineData(null, "message")] + [InlineData("title", null)] + [InlineData("", "")] + [InlineData(" title ", " message ")] + public void Raw_title_message_and_unknown_severity_reach_notice_and_inline_without_normalization( + string? title, string? message) + { + var f = new Fixture { Resolve = _ => title }; + var calls = 0; + f.Notice = (severity, actualTitle, actualMessage) => + { + calls++; + Assert.Equal((Severity)(-67), severity); + Assert.Equal(title, actualTitle); + Assert.Equal(message, actualMessage); + }; + f.State.Show(message, (Severity)(-67)); + Assert.Equal((title, message, (Severity)(-67), true), f.Values); + Assert.Equal(1, calls); + } + + [Fact] + public void Repeated_message_still_calls_all_ports_but_emits_no_equal_property_events() + { + var f = new Fixture { Resolve = _ => null }; + f.State.Show(null, Severity.Error); + f.Clear(); + f.State.Show(null, Severity.Error); + Assert.Equal(new[] { "title", "notice", "inline" }, f.Trace); + Assert.Equal((null, null, Severity.Error, true), f.Values); + Assert.Equal(1, f.InlineReads); + } + + [Theory] + [InlineData(false)] + [InlineData(true)] + public void Disabled_inline_only_closes_current_open_and_preserves_other_values(bool initiallyOpen) + { + var f = new Fixture { Inline = false }; + f.Seed(initiallyOpen); + f.Notice = (_, _, _) => Assert.Equal(("old-title", "old-message", Severity.Warning, initiallyOpen), f.Values); + f.State.Show("ignored-inline", Severity.Error); + var expected = new List { "title", "notice", "inline" }; + if (initiallyOpen) expected.Add("IsStatusOpen"); + Assert.Equal(expected, f.Trace); + Assert.Equal(("old-title", "old-message", Severity.Warning, false), f.Values); + } + + [Theory] + [InlineData(true, false)] + [InlineData(false, true)] + [InlineData(true, true)] + [InlineData(false, false)] + public void Notice_can_change_inline_before_its_single_current_read(bool initial, bool afterNotice) + { + var f = new Fixture { Inline = initial }; + f.Seed(true); + f.Notice = (_, _, _) => f.Inline = afterNotice; + f.State.Show("outer", Severity.Error); + Assert.Equal(afterNotice + ? ("title:49", "outer", Severity.Error, true) + : ("old-title", "old-message", Severity.Warning, false), f.Values); + Assert.Equal(new[] { "title", "notice", "inline" }, f.Trace.Take(3)); + Assert.Equal(1, f.InlineReads); + } + + [Fact] + public void Later_property_callback_changing_inline_does_not_interrupt_the_outer_sequence() + { + var f = new Fixture(); + f.Property = name => { if (name == "StatusTitle") f.Inline = false; }; + f.State.Show("outer", Severity.Error); + Assert.False(f.Inline); + Assert.Equal(("title:49", "outer", Severity.Error, true), f.Values); + Assert.Equal(1, f.InlineReads); + Assert.Equal(new[] { "title", "notice", "inline", "StatusTitle", "StatusMessage", "StatusSeverity", "IsStatusOpen" }, f.Trace); + } + + [Fact] + public void Title_resolution_can_replace_the_current_notice_subscriber_before_publication() + { + var f = new Fixture(); + var oldCalls = 0; + var newCalls = 0; + f.Notice = (_, _, _) => oldCalls++; + f.Resolve = _ => + { + f.Notice = (_, title, _) => { newCalls++; Assert.Equal("resolved", title); }; + return "resolved"; + }; + f.State.Show("message", Severity.Warning); + Assert.Equal(0, oldCalls); + Assert.Equal(1, newCalls); + Assert.Equal("resolved", f.State.StatusTitle); + } + + [Fact] + public void Nested_notice_finishes_then_outer_publication_uses_its_own_arguments() + { + var f = new Fixture(); + f.Notice = (_, _, message) => + { + if (message != "outer") return; + f.State.Show("inner", Severity.Warning); + Assert.Equal(("title:27", "inner", Severity.Warning, true), f.Values); + }; + f.State.Show("outer", Severity.Error); + Assert.Equal(("title:49", "outer", Severity.Error, true), f.Values); + Assert.Equal(2, f.InlineReads); + Assert.Equal(2, f.Trace.Count(item => item == "StatusTitle")); + Assert.Equal(1, f.Trace.Count(item => item == "IsStatusOpen")); + } + + [Fact] + public void Equality_after_nested_notice_compares_with_current_inner_values() + { + var f = new Fixture { Resolve = _ => "shared-title" }; + f.Notice = (_, _, message) => + { + if (message == "outer") f.State.Show("inner", Severity.Warning); + }; + f.State.Show("outer", Severity.Error); + Assert.Equal(1, f.Trace.Count(item => item == "StatusTitle")); + Assert.Equal(2, f.Trace.Count(item => item == "StatusMessage")); + Assert.Equal(2, f.Trace.Count(item => item == "StatusSeverity")); + Assert.Equal(1, f.Trace.Count(item => item == "IsStatusOpen")); + Assert.Equal(("shared-title", "outer", Severity.Error, true), f.Values); + } + + [Fact] + public void Nested_title_observer_can_overwrite_title_while_outer_later_arguments_continue() + { + var f = new Fixture(); + var nested = false; + f.Property = name => + { + if (nested || name != "StatusTitle") return; + nested = true; + Assert.Equal("title:49", f.State.StatusTitle); + Assert.Equal(string.Empty, f.State.StatusMessage); + f.State.Show("inner", Severity.Warning); + }; + f.State.Show("outer", Severity.Error); + Assert.Equal(("title:27", "outer", Severity.Error, true), f.Values); + Assert.Equal(2, f.InlineReads); + } + + [Fact] + public void Nested_title_resolution_finishes_before_outer_notice_and_keeps_outer_local_title() + { + var f = new Fixture(); + f.Resolve = severity => + { + if (severity == Severity.Error) f.State.Show("inner", Severity.Warning); + return $"resolved:{(int)severity}"; + }; + f.Notice = (_, title, message) => + { + if (message != "outer") return; + Assert.Equal("resolved:49", title); + Assert.Equal(("resolved:27", "inner", Severity.Warning, true), f.Values); + }; + f.State.Show("outer", Severity.Error); + Assert.Equal(("resolved:49", "outer", Severity.Error, true), f.Values); + } + + [Theory] + [InlineData("title")] + [InlineData("notice")] + [InlineData("inline")] + public void Port_failure_preserves_identity_and_prevents_later_ports_and_field_assignments(string failing) + { + var f = new Fixture(); + f.Seed(false); + var failure = new InvalidOperationException(failing); + if (failing == "title") f.Resolve = _ => throw failure; + if (failing == "notice") f.Notice = (_, _, _) => throw failure; + if (failing == "inline") f.ReadInline = () => throw failure; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.Equal(("old-title", "old-message", Severity.Warning, false), f.Values); + Assert.Equal(new[] { "title", "notice", "inline" }.Take(Array.IndexOf(new[] { "title", "notice", "inline" }, failing) + 1), f.Trace); + f.Resolve = severity => $"title:{(int)severity}"; + f.Notice = null; + f.ReadInline = null; + f.State.Show("retry", Severity.Error); + Assert.Equal(("title:49", "retry", Severity.Error, true), f.Values); + } + + [Theory] + [InlineData(0)] + [InlineData(1)] + [InlineData(2)] + [InlineData(3)] + public void Each_property_failure_leaves_its_assigned_value_and_retry_resumes_from_partial_state(int index) + { + var names = new[] { "StatusTitle", "StatusMessage", "StatusSeverity", "IsStatusOpen" }; + var f = new Fixture(); + f.Seed(false); + var failure = new InvalidOperationException(names[index]); + f.Property = name => { if (name == names[index]) throw failure; }; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.Equal(("title:49", index >= 1 ? "outer" : "old-message", + index >= 2 ? Severity.Error : Severity.Warning, index >= 3), f.Values); + Assert.Equal(new[] { "title", "notice", "inline" }.Concat(names.Take(index + 1)), f.Trace); + f.Property = null; + f.Clear(); + f.State.Show("outer", Severity.Error); + Assert.Equal(("title:49", "outer", Severity.Error, true), f.Values); + Assert.Equal(new[] { "title", "notice", "inline" }.Concat(names.Skip(index + 1)), f.Trace); + } + + [Fact] + public void Disabled_close_observer_failure_keeps_closed_value_and_equal_retry_does_not_notify() + { + var f = new Fixture { Inline = false }; + f.Seed(true); + var failure = new InvalidOperationException("close"); + f.Property = _ => throw failure; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.Equal(("old-title", "old-message", Severity.Warning, false), f.Values); + f.Clear(); + f.State.Show("outer", Severity.Error); + Assert.Equal(new[] { "title", "notice", "inline" }, f.Trace); + } + + [Fact] + public void Notice_failure_prevents_even_a_disabled_close() + { + var f = new Fixture { Inline = false }; + f.Seed(true); + var failure = new InvalidOperationException("notice"); + f.Notice = (_, _, _) => throw failure; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.True(f.State.IsStatusOpen); + Assert.Equal(0, f.InlineReads); + } + + [Fact] + public void Notice_failure_after_nested_show_keeps_inner_effects_without_outer_flag_read() + { + var f = new Fixture(); + var failure = new InvalidOperationException("outer-notice"); + f.Notice = (_, _, message) => + { + if (message != "outer") return; + f.State.Show("inner", Severity.Warning); + throw failure; + }; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.Equal(("title:27", "inner", Severity.Warning, true), f.Values); + Assert.Equal(1, f.InlineReads); + } + + [Fact] + public void Property_failure_after_nested_show_preserves_inner_changes_and_stops_outer_tail() + { + var f = new Fixture(); + var failure = new InvalidOperationException("outer-message"); + var nested = false; + f.Property = name => + { + if (nested || name != "StatusMessage") return; + nested = true; + f.State.Show("inner", Severity.Warning); + throw failure; + }; + Assert.Same(failure, Assert.Throws(() => f.State.Show("outer", Severity.Error))); + Assert.Equal(("title:27", "inner", Severity.Warning, true), f.Values); + Assert.Equal(2, f.InlineReads); + } + + [Fact] + public void Instances_have_independent_values_ports_flags_and_events() + { + var first = new Fixture(); + var second = new Fixture { Inline = false }; + first.State.Show("one", Severity.Error); + Assert.Empty(second.Trace); + Assert.Equal((string.Empty, string.Empty, Severity.Information, false), second.Values); + second.State.Show("two", Severity.Warning); + Assert.Equal(("title:49", "one", Severity.Error, true), first.Values); + Assert.Equal((string.Empty, string.Empty, Severity.Information, false), second.Values); + Assert.Equal(1, first.InlineReads); + Assert.Equal(1, second.InlineReads); + } + + private sealed class Fixture + { + internal readonly ConfigMakerStatusPresentation State; + internal readonly List Trace = []; + internal Func Resolve = severity => $"title:{(int)severity}"; + internal Action? Notice; + internal Func? ReadInline; + internal Action? Property; + internal bool Inline = true; + internal int InlineReads; + internal (string?, string?, Severity, bool) Values => + (State.StatusTitle, State.StatusMessage, State.StatusSeverity, State.IsStatusOpen); + + internal Fixture() + { + State = new(Severity.Information, + severity => { Trace.Add("title"); return Resolve(severity); }, + (severity, title, message) => { Trace.Add("notice"); Notice?.Invoke(severity, title, message); }, + () => { Trace.Add("inline"); InlineReads++; return ReadInline is null ? Inline : ReadInline(); }); + State.PropertyChanged += (sender, e) => + { + Assert.Same(State, sender); + Trace.Add(e.PropertyName!); + Property?.Invoke(e.PropertyName!); + }; + } + + internal void Seed(bool open) + { + State.StatusTitle = "old-title"; + State.StatusMessage = "old-message"; + State.StatusSeverity = Severity.Warning; + State.IsStatusOpen = open; + Clear(); + } + + internal void Clear() { Trace.Clear(); InlineReads = 0; } + } +} diff --git a/CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs b/CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs new file mode 100644 index 00000000..db42c3d5 --- /dev/null +++ b/CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs @@ -0,0 +1,430 @@ +using CDPIUI.ViewModels.Welcome; + +namespace CDPIUI.Tests.Presentation; + +public sealed class WelcomeMigrationPresentationTests +{ + private enum Severity { Initial = 41, Error = 73, Other = 99 } + + [Fact] + public void NineDefaultsAndExplicitSeveritiesAreCold() + { + var owner = new WelcomeMigrationPresentation(Severity.Initial, Severity.Error, null!); + Assert.False(owner.IsMigrationMode); + Assert.True(owner.IsReadyBundlesContentVisible); + Assert.Equal(string.Empty, owner.MigrationStatusTitle); + Assert.Equal(string.Empty, owner.MigrationStatusMessage); + Assert.Equal(Severity.Initial, owner.MigrationStatusSeverity); + Assert.Equal(0, owner.MigrationProgress); + Assert.Null(owner.MigrationComponentItems); + Assert.True(owner.IsMigrationComponentsListVisible); + Assert.Equal(string.Empty, owner.MigrationSummaryText); + Assert.False(owner.IsRetryMigrationVisible); + } + + private sealed class Sentinel : Exception; + + private sealed class Subject + { + internal readonly WelcomeMigrationPresentation State; + internal readonly List Trace = []; + internal readonly Sentinel Failure = new(); + internal Func Resolve = key => key; + internal Action? Observe; + internal string? Fault; + + internal Subject() + { + State = new(Severity.Initial, Severity.Error, key => + { + Record("text:" + key); + return Resolve(key); + }); + State.PropertyChanged += (sender, args) => + { + Assert.Same(State, sender); + string name = args.PropertyName!; + Record("event:" + name); + Observe?.Invoke(name); + }; + } + + private void Record(string token) + { + Trace.Add(token); + if (Fault == token) throw Failure; + } + } + + [Theory] + [InlineData("IsMigrationMode")] + [InlineData("MigrationStatusTitle")] + [InlineData("MigrationStatusMessage")] + [InlineData("MigrationStatusSeverity")] + [InlineData("MigrationProgress")] + [InlineData("MigrationComponentItems")] + [InlineData("IsMigrationComponentsListVisible")] + [InlineData("MigrationSummaryText")] + [InlineData("IsRetryMigrationVisible")] + public void EachSetterKeepsValueAndSuppressesEquality(string name) + { + var s = new Subject(); + IReadOnlyList items = [new() { StoreId = "one" }]; + Action assign = name switch + { + "IsMigrationMode" => () => s.State.IsMigrationMode = true, + "MigrationStatusTitle" => () => s.State.MigrationStatusTitle = "title", + "MigrationStatusMessage" => () => s.State.MigrationStatusMessage = "message", + "MigrationStatusSeverity" => () => s.State.MigrationStatusSeverity = (Severity)(-7), + "MigrationProgress" => () => s.State.MigrationProgress = -12.5, + "MigrationComponentItems" => () => s.State.MigrationComponentItems = items, + "IsMigrationComponentsListVisible" => () => s.State.IsMigrationComponentsListVisible = false, + "MigrationSummaryText" => () => s.State.MigrationSummaryText = "summary", + "IsRetryMigrationVisible" => () => s.State.IsRetryMigrationVisible = true, + _ => throw new InvalidOperationException(name) + }; + assign(); + object? first = s.State.GetType().GetProperty(name)!.GetValue(s.State); + Assert.NotNull(first); + Assert.Equal(name == "IsMigrationMode" + ? ["event:IsMigrationMode", "event:IsReadyBundlesContentVisible"] + : new[] { "event:" + name }, s.Trace); + s.Trace.Clear(); + assign(); + Assert.Empty(s.Trace); + Assert.Equal(first, s.State.GetType().GetProperty(name)!.GetValue(s.State)); + if (name == "MigrationComponentItems") Assert.Same(items, first); + } + + [Theory] + [InlineData("MigrationStatusTitle")] + [InlineData("MigrationStatusMessage")] + [InlineData("MigrationSummaryText")] + public void StringSettersKeepRawNullAndEquality(string name) + { + var s = new Subject(); + Action assign = name switch + { + "MigrationStatusTitle" => () => s.State.MigrationStatusTitle = null, + "MigrationStatusMessage" => () => s.State.MigrationStatusMessage = null, + _ => () => s.State.MigrationSummaryText = null + }; + assign(); assign(); + Assert.Null(s.State.GetType().GetProperty(name)!.GetValue(s.State)); + Assert.Equal(new[] { "event:" + name }, s.Trace); + } + + private sealed class EqualItems : List + { + public override bool Equals(object? obj) => obj is EqualItems; + public override int GetHashCode() => 0; + } + + [Fact] + public void ComponentListKeepsReferenceNullAndDefaultCustomEquality() + { + var s = new Subject(); + var first = new EqualItems(); + s.State.MigrationComponentItems = first; + s.State.MigrationComponentItems = new EqualItems(); + Assert.Same(first, s.State.MigrationComponentItems); + Assert.Single(s.Trace); + IReadOnlyList different = []; + s.State.MigrationComponentItems = different; + Assert.Same(different, s.State.MigrationComponentItems); + s.State.MigrationComponentItems = null; + s.State.MigrationComponentItems = null; + Assert.Null(s.State.MigrationComponentItems); + Assert.Equal(3, s.Trace.Count); + } + + [Fact] + public void ProgressRetainsNonfiniteValuesAndEqualValueBits() + { + var s = new Subject(); + s.State.MigrationProgress = -0d; + Assert.Empty(s.Trace); + Assert.Equal(0L, BitConverter.DoubleToInt64Bits(s.State.MigrationProgress)); + const long firstBits = 0x7ff8000000000011; + s.State.MigrationProgress = BitConverter.Int64BitsToDouble(firstBits); + s.State.MigrationProgress = BitConverter.Int64BitsToDouble(0x7ff8000000000022); + Assert.Equal(firstBits, BitConverter.DoubleToInt64Bits(s.State.MigrationProgress)); + Assert.Single(s.Trace); + s.State.MigrationProgress = double.PositiveInfinity; + s.State.MigrationProgress = double.PositiveInfinity; + Assert.Equal(double.PositiveInfinity, s.State.MigrationProgress); + s.State.MigrationProgress = double.NegativeInfinity; + Assert.Equal(double.NegativeInfinity, s.State.MigrationProgress); + Assert.Equal(3, s.Trace.Count); + } + + [Fact] + public void ModeNotifiesPrimaryThenDerivedWithCurrentSnapshots() + { + var s = new Subject(); + var snapshots = new List<(string, bool, bool)>(); + s.Observe = name => snapshots.Add((name, s.State.IsMigrationMode, s.State.IsReadyBundlesContentVisible)); + s.State.IsMigrationMode = true; + s.State.IsMigrationMode = true; + s.State.IsMigrationMode = false; + Assert.Equal(new[] + { + ("IsMigrationMode", true, false), ("IsReadyBundlesContentVisible", true, false), + ("IsMigrationMode", false, true), ("IsReadyBundlesContentVisible", false, true) + }, snapshots); + } + + [Fact] + public void NestedModeReversalStillLeavesOuterDerived() + { + var s = new Subject(); + var derived = new List(); + s.Observe = name => + { + if (name == "IsMigrationMode" && s.State.IsMigrationMode) s.State.IsMigrationMode = false; + if (name == "IsReadyBundlesContentVisible") derived.Add(s.State.IsReadyBundlesContentVisible); + }; + s.State.IsMigrationMode = true; + Assert.Equal(new[] { "event:IsMigrationMode", "event:IsMigrationMode", + "event:IsReadyBundlesContentVisible", "event:IsReadyBundlesContentVisible" }, s.Trace); + Assert.Equal(new[] { true, true }, derived); + Assert.False(s.State.IsMigrationMode); + } + + [Fact] + public void ModeObserverFailureStopsDerivedAndEqualRetryStaysSilent() + { + var s = new Subject { Fault = "event:IsMigrationMode" }; + Assert.Same(s.Failure, Assert.Throws(() => s.State.IsMigrationMode = true)); + Assert.True(s.State.IsMigrationMode); + Assert.False(s.State.IsReadyBundlesContentVisible); + Assert.Equal(new[] { "event:IsMigrationMode" }, s.Trace); + s.Fault = null; s.Trace.Clear(); + s.State.IsMigrationMode = true; + Assert.Empty(s.Trace); + s.State.IsMigrationMode = false; + Assert.Equal(new[] { "event:IsMigrationMode", "event:IsReadyBundlesContentVisible" }, s.Trace); + } + + [Fact] + public void StatusAssignsTitleBeforeResolvingMessage() + { + var s = new Subject(); + string message = "before"; + s.Resolve = key => key.EndsWith("/message", StringComparison.Ordinal) ? message : "title"; + s.Observe = name => { if (name == "MigrationStatusTitle") message = "after title observer"; }; + s.State.ShowStatus("title", "message", Severity.Other); + Assert.Equal("after title observer", s.State.MigrationStatusMessage); + Assert.Equal(new[] { "text:/WelcomeWizard/title", "event:MigrationStatusTitle", + "text:/WelcomeWizard/message", "event:MigrationStatusMessage", "event:MigrationStatusSeverity" }, s.Trace); + } + + [Fact] + public void StatusKeepsRawKeysNullValuesAndUnknownSeverity() + { + var s = new Subject { Resolve = _ => null }; + s.State.ShowStatus(null, "/raw/key", (Severity)(-7)); + Assert.Null(s.State.MigrationStatusTitle); + Assert.Null(s.State.MigrationStatusMessage); + Assert.Equal((Severity)(-7), s.State.MigrationStatusSeverity); + Assert.Equal(new[] { "text:/WelcomeWizard/", "event:MigrationStatusTitle", + "text:/WelcomeWizard//raw/key", "event:MigrationStatusMessage", "event:MigrationStatusSeverity" }, s.Trace); + } + + [Fact] + public void RepeatedStatusStillLooksUpBothTextsWhileEqualPropertiesStaySilent() + { + var s = new Subject(); + s.State.ShowStatus("title", "message", Severity.Other); + s.Trace.Clear(); + s.State.ShowStatus("title", "message", Severity.Other); + Assert.Equal(new[] { "text:/WelcomeWizard/title", "text:/WelcomeWizard/message" }, s.Trace); + } + + [Theory] + [InlineData(false)] + [InlineData(true)] + public void NestedStatusFromLookupOrTitleKeepsOuterArgumentsAndCurrentEquality(bool fromLookup) + { + var s = new Subject(); + bool nested = false; + void Inner() + { + if (nested) return; + nested = true; + s.State.ShowStatus("inner-title", "outer-message", Severity.Other); + } + s.Resolve = key => { if (fromLookup && key == "/WelcomeWizard/outer-title") Inner(); return key; }; + s.Observe = name => { if (!fromLookup && name == "MigrationStatusTitle") Inner(); }; + s.State.ShowStatus("outer-title", "outer-message", Severity.Other); + Assert.Equal(fromLookup ? "/WelcomeWizard/outer-title" : "/WelcomeWizard/inner-title", s.State.MigrationStatusTitle); + Assert.Equal("/WelcomeWizard/outer-message", s.State.MigrationStatusMessage); + Assert.Equal(Severity.Other, s.State.MigrationStatusSeverity); + Assert.Equal(1, s.Trace.Count(x => x == "event:MigrationStatusMessage")); + Assert.Equal(1, s.Trace.Count(x => x == "event:MigrationStatusSeverity")); + Assert.Equal(2, s.Trace.Count(x => x == "text:/WelcomeWizard/outer-message")); + } + + [Theory] + [InlineData(0)] [InlineData(1)] [InlineData(2)] [InlineData(3)] [InlineData(4)] + public void StatusFaultAtEachBoundaryKeepsPartialStateAndRetries(int at) + { + string[] steps = ["text:/WelcomeWizard/title", "event:MigrationStatusTitle", + "text:/WelcomeWizard/message", "event:MigrationStatusMessage", "event:MigrationStatusSeverity"]; + var s = new Subject { Fault = steps[at] }; + Assert.Same(s.Failure, Assert.Throws(() => s.State.ShowStatus("title", "message", Severity.Other))); + Assert.Equal(steps.Take(at + 1), s.Trace); + Assert.Equal(at >= 1 ? "/WelcomeWizard/title" : "", s.State.MigrationStatusTitle); + Assert.Equal(at >= 3 ? "/WelcomeWizard/message" : "", s.State.MigrationStatusMessage); + Assert.Equal(at >= 4 ? Severity.Other : Severity.Initial, s.State.MigrationStatusSeverity); + s.Fault = null; s.Trace.Clear(); + s.State.ShowStatus("title", "message", Severity.Other); + Assert.Equal("/WelcomeWizard/title", s.State.MigrationStatusTitle); + Assert.Equal("/WelcomeWizard/message", s.State.MigrationStatusMessage); + Assert.Equal(Severity.Other, s.State.MigrationStatusSeverity); + Assert.Equal(steps.Where((_, i) => i is 0 or 2 || i > at), s.Trace); + } + + [Theory] + [InlineData(null, "caller\n\nCODE")] + [InlineData("", "caller\n\nCODE")] + [InlineData(" \t\r\n", "caller\n\nCODE")] + [InlineData("translated", "translated\n\nCODE")] + public void ErrorChoosesOnlyNonWhitespaceLocalizedMessage(string? localized, string expected) + { + var s = new Subject { Resolve = key => key.Contains("MigrationError_", StringComparison.Ordinal) ? localized : "failed-title" }; + s.State.ShowError("caller", "CODE"); + Assert.Equal(expected, s.State.MigrationStatusMessage); + Assert.Equal("failed-title", s.State.MigrationStatusTitle); + Assert.Equal(Severity.Error, s.State.MigrationStatusSeverity); + Assert.True(s.State.IsRetryMigrationVisible); + Assert.Equal(new[] { "text:/WelcomeWizard/MigrationError_CODE", "text:/WelcomeWizard/MigrationFailedTitle", + "event:MigrationStatusTitle", "event:MigrationStatusMessage", "event:MigrationStatusSeverity", "event:IsRetryMigrationVisible" }, s.Trace); + } + + [Theory] + [InlineData(null, null, "\n\n")] + [InlineData(null, "CODE", "\n\nCODE")] + [InlineData("caller", null, "caller\n\n")] + [InlineData("a\nb", " c ", "a\nb\n\n c ")] + public void ErrorKeepsRawArgumentsAndLiteralTwoNewlines(string? message, string? code, string expected) + { + var s = new Subject { Resolve = _ => null }; + s.State.ShowError(message, code); + Assert.Null(s.State.MigrationStatusTitle); + Assert.Equal(expected, s.State.MigrationStatusMessage); + Assert.Equal("text:/WelcomeWizard/MigrationError_" + code, s.Trace[0]); + } + + [Fact] + public void ErrorUsesExplicitErrorSeverityRatherThanDefaultOrNumericMapping() + { + var state = new WelcomeMigrationPresentation(Severity.Other, (Severity)(-99), _ => "text"); + state.ShowError("caller", "code"); + Assert.Equal((Severity)(-99), state.MigrationStatusSeverity); + } + + [Fact] + public void NestedErrorDuringTitleKeepsOuterLocalMessageAndCurrentEquality() + { + var s = new Subject { Resolve = key => key.EndsWith("_OUTER", StringComparison.Ordinal) ? "outer-local" : + key.EndsWith("_INNER", StringComparison.Ordinal) ? "" : "failed-title" }; + bool nested = false; + s.Observe = name => + { + if (name != "MigrationStatusTitle" || nested) return; + nested = true; s.State.ShowError("inner", "INNER"); + }; + s.State.ShowError("outer-caller", "OUTER"); + Assert.Equal("outer-local\n\nOUTER", s.State.MigrationStatusMessage); + Assert.Equal(new[] { "text:/WelcomeWizard/MigrationError_OUTER", "text:/WelcomeWizard/MigrationFailedTitle", + "event:MigrationStatusTitle", "text:/WelcomeWizard/MigrationError_INNER", "text:/WelcomeWizard/MigrationFailedTitle", + "event:MigrationStatusMessage", "event:MigrationStatusSeverity", "event:IsRetryMigrationVisible", + "event:MigrationStatusMessage" }, s.Trace); + } + + [Fact] + public void NestedStatusFromErrorLookupPrecedesOuterTitleAndDoesNotReplaceOuterLocal() + { + var s = new Subject(); + bool nested = false; + s.Resolve = key => + { + if (!nested && key == "/WelcomeWizard/MigrationError_CODE") + { + nested = true; s.State.ShowStatus("inner-title", "inner-message", Severity.Other); + return "outer-local"; + } + return key; + }; + s.State.ShowError("caller", "CODE"); + Assert.Equal("/WelcomeWizard/MigrationFailedTitle", s.State.MigrationStatusTitle); + Assert.Equal("outer-local\n\nCODE", s.State.MigrationStatusMessage); + Assert.Equal(Severity.Error, s.State.MigrationStatusSeverity); + Assert.True(s.State.IsRetryMigrationVisible); + Assert.Equal(2, s.Trace.Count(x => x == "event:MigrationStatusTitle")); + Assert.Equal(2, s.Trace.Count(x => x == "event:MigrationStatusMessage")); + Assert.Equal(2, s.Trace.Count(x => x == "event:MigrationStatusSeverity")); + } + + [Theory] + [InlineData(0)] [InlineData(1)] [InlineData(2)] [InlineData(3)] [InlineData(4)] [InlineData(5)] + public void ErrorFaultAtEachBoundaryKeepsPartialStateAndRetries(int at) + { + string[] steps = ["text:/WelcomeWizard/MigrationError_CODE", "text:/WelcomeWizard/MigrationFailedTitle", + "event:MigrationStatusTitle", "event:MigrationStatusMessage", "event:MigrationStatusSeverity", "event:IsRetryMigrationVisible"]; + var s = new Subject { Resolve = key => key.EndsWith("_CODE", StringComparison.Ordinal) ? "localized" : "failed-title", Fault = steps[at] }; + Assert.Same(s.Failure, Assert.Throws(() => s.State.ShowError("caller", "CODE"))); + Assert.Equal(steps.Take(at + 1), s.Trace); + Assert.Equal(at >= 2 ? "failed-title" : "", s.State.MigrationStatusTitle); + Assert.Equal(at >= 3 ? "localized\n\nCODE" : "", s.State.MigrationStatusMessage); + Assert.Equal(at >= 4 ? Severity.Error : Severity.Initial, s.State.MigrationStatusSeverity); + Assert.Equal(at >= 5, s.State.IsRetryMigrationVisible); + s.Fault = null; s.Trace.Clear(); + s.State.ShowError("caller", "CODE"); + Assert.Equal("failed-title", s.State.MigrationStatusTitle); + Assert.Equal("localized\n\nCODE", s.State.MigrationStatusMessage); + Assert.Equal(Severity.Error, s.State.MigrationStatusSeverity); + Assert.True(s.State.IsRetryMigrationVisible); + Assert.Equal(steps.Where((_, i) => i < 2 || i > at), s.Trace); + } + + [Fact] + public void NestedErrorFailureRetainsInnerEffectsAndStopsOuterMessageLookup() + { + var s = new Subject { Fault = "event:MigrationStatusSeverity" }; + bool nested = false; + s.Observe = name => + { + if (name != "MigrationStatusTitle" || nested) return; + nested = true; s.State.ShowError("inner", "INNER"); + }; + Assert.Same(s.Failure, Assert.Throws(() => s.State.ShowStatus("outer-title", "outer-message", Severity.Other))); + Assert.Equal("/WelcomeWizard/MigrationFailedTitle", s.State.MigrationStatusTitle); + Assert.Equal("/WelcomeWizard/MigrationError_INNER\n\nINNER", s.State.MigrationStatusMessage); + Assert.Equal(Severity.Error, s.State.MigrationStatusSeverity); + Assert.False(s.State.IsRetryMigrationVisible); + Assert.DoesNotContain("text:/WelcomeWizard/outer-message", s.Trace); + s.Fault = null; s.Observe = null; + s.State.ShowStatus("outer-title", "outer-message", Severity.Other); + Assert.Equal("/WelcomeWizard/outer-message", s.State.MigrationStatusMessage); + } + + [Fact] + public void IndependentOwnersDoNotShareValuesCallbacksOrLists() + { + var first = new Subject { Resolve = _ => "first" }; + var second = new Subject { Resolve = _ => "second" }; + first.State.ShowError("caller", "CODE"); + first.State.IsMigrationMode = true; + first.State.MigrationComponentItems = [new()]; + Assert.Empty(second.Trace); + Assert.Equal(string.Empty, second.State.MigrationStatusTitle); + Assert.Null(second.State.MigrationComponentItems); + Assert.False(second.State.IsMigrationMode); + Assert.False(second.State.IsRetryMigrationVisible); + second.State.ShowStatus("title", "message", Severity.Other); + Assert.Equal("second", second.State.MigrationStatusTitle); + Assert.Equal("first", first.State.MigrationStatusTitle); + } +} diff --git a/CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs b/CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs new file mode 100644 index 00000000..5f34bc81 --- /dev/null +++ b/CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs @@ -0,0 +1,68 @@ +#nullable enable + +using System; + +namespace CDPIUI.ViewModels.ConfigMaker; + +internal sealed class ConfigMakerStatusPresentation : ObservableObject +{ + private readonly Func _resolveTitle; + private readonly Action _raiseNotice; + private readonly Func _getInline; + private string? _statusTitle = string.Empty; + private string? _statusMessage = string.Empty; + private TSeverity _statusSeverity; + private bool _isStatusOpen; + + public ConfigMakerStatusPresentation( + TSeverity initialSeverity, + Func resolveTitle, + Action raiseNotice, + Func getInline) + { + _statusSeverity = initialSeverity; + _resolveTitle = resolveTitle; + _raiseNotice = raiseNotice; + _getInline = getInline; + } + + public string? StatusTitle + { + get => _statusTitle; + set => SetProperty(ref _statusTitle, value); + } + + public string? StatusMessage + { + get => _statusMessage; + set => SetProperty(ref _statusMessage, value); + } + + public TSeverity StatusSeverity + { + get => _statusSeverity; + set => SetProperty(ref _statusSeverity, value); + } + + public bool IsStatusOpen + { + get => _isStatusOpen; + set => SetProperty(ref _isStatusOpen, value); + } + + public void Show(string? message, TSeverity severity) + { + string? title = _resolveTitle(severity); + _raiseNotice(severity, title, message); + if (!_getInline()) + { + IsStatusOpen = false; + return; + } + + StatusTitle = title; + StatusMessage = message; + StatusSeverity = severity; + IsStatusOpen = true; + } +} diff --git a/CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs b/CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs index 0108eec5..c1d063eb 100644 --- a/CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs +++ b/CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs @@ -40,15 +40,23 @@ public sealed partial class ConfigMakerViewModel : ObservableObject, IConfigMake private bool _isEditorReadOnly; private bool _updatingComponent; private string _editorBackground = BlackBackground; - private string _statusTitle = string.Empty; - private string _statusMessage = string.Empty; - private InfoBarSeverity _statusSeverity = InfoBarSeverity.Informational; - private bool _isStatusOpen; + private readonly ConfigMakerStatusPresentation _statusPresentation; public ConfigMakerViewModel(IConfigMakerView view, DispatcherQueue dispatcherQueue) { _view = view ?? throw new ArgumentNullException(nameof(view)); _dispatcherQueue = dispatcherQueue ?? throw new ArgumentNullException(nameof(dispatcherQueue)); + _statusPresentation = new(InfoBarSeverity.Informational, + severity => severity switch + { + InfoBarSeverity.Error => _localizer.GetLocalizedString("SomethingWentWrong"), + InfoBarSeverity.Warning => _localizer.GetLocalizedString("Attention"), + _ => _localizer.GetLocalizedString("Information"), + }, + (severity, title, message) => StatusNotificationRequested?.Invoke( + this, new StatusNotificationRequestedEventArgs(severity, title, message)), + () => UseInlineStatusMessages); + _statusPresentation.PropertyChanged += (_, args) => OnPropertyChanged(args.PropertyName); _textChanges = new TextChangeRelay( () => IsEditorReadOnly, () => CommandText, text => CommandText = text, _view.ReplaceEditorText, @@ -193,26 +201,26 @@ public bool IsEditorReadOnly public string StatusTitle { - get => _statusTitle; - private set => SetProperty(ref _statusTitle, value); + get => _statusPresentation.StatusTitle; + private set => _statusPresentation.StatusTitle = value; } public string StatusMessage { - get => _statusMessage; - private set => SetProperty(ref _statusMessage, value); + get => _statusPresentation.StatusMessage; + private set => _statusPresentation.StatusMessage = value; } public InfoBarSeverity StatusSeverity { - get => _statusSeverity; - private set => SetProperty(ref _statusSeverity, value); + get => _statusPresentation.StatusSeverity; + private set => _statusPresentation.StatusSeverity = value; } public bool IsStatusOpen { - get => _isStatusOpen; - set => SetProperty(ref _isStatusOpen, value); + get => _statusPresentation.IsStatusOpen; + set => _statusPresentation.IsStatusOpen = value; } public string EditorBackground => _editorBackground; @@ -293,28 +301,8 @@ public void LoadEditorBackground() RaiseEditorBackgroundChanged(); } - public void ShowEditorMessage(string message, InfoBarSeverity severity) - { - string title = severity switch - { - InfoBarSeverity.Error => _localizer.GetLocalizedString("SomethingWentWrong"), - InfoBarSeverity.Warning => _localizer.GetLocalizedString("Attention"), - _ => _localizer.GetLocalizedString("Information"), - }; - StatusNotificationRequested?.Invoke( - this, - new StatusNotificationRequestedEventArgs(severity, title, message)); - if (!UseInlineStatusMessages) - { - IsStatusOpen = false; - return; - } - - StatusTitle = title; - StatusMessage = message; - StatusSeverity = severity; - IsStatusOpen = true; - } + public void ShowEditorMessage(string message, InfoBarSeverity severity) => + _statusPresentation.Show(message, severity); // An exception must not leave an async void event handler: it would reach the global handler. public void ReportHandlerError(Exception exception) diff --git a/CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs b/CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs new file mode 100644 index 00000000..98039432 --- /dev/null +++ b/CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs @@ -0,0 +1,108 @@ +#nullable enable + +using System; +using System.Collections.Generic; + +namespace CDPIUI.ViewModels.Welcome; + +internal sealed class WelcomeMigrationPresentation : ObservableObject +{ + private readonly TSeverity _errorSeverity; + private readonly Func _text; + private bool _isMigrationMode; + private string? _migrationStatusTitle = string.Empty; + private string? _migrationStatusMessage = string.Empty; + private TSeverity _migrationStatusSeverity; + private double _migrationProgress; + private IReadOnlyList? _migrationComponentItems; + private bool _isMigrationComponentsListVisible = true; + private string? _migrationSummaryText = string.Empty; + private bool _isRetryMigrationVisible; + + public WelcomeMigrationPresentation(TSeverity initialSeverity, TSeverity errorSeverity, + Func text) + { + _migrationStatusSeverity = initialSeverity; + _errorSeverity = errorSeverity; + _text = text; + } + + public bool IsMigrationMode + { + get => _isMigrationMode; + set + { + if (SetProperty(ref _isMigrationMode, value)) + OnPropertyChanged(nameof(IsReadyBundlesContentVisible)); + } + } + + public bool IsReadyBundlesContentVisible => !_isMigrationMode; + + public string? MigrationStatusTitle + { + get => _migrationStatusTitle; + set => SetProperty(ref _migrationStatusTitle, value); + } + + public string? MigrationStatusMessage + { + get => _migrationStatusMessage; + set => SetProperty(ref _migrationStatusMessage, value); + } + + public TSeverity MigrationStatusSeverity + { + get => _migrationStatusSeverity; + set => SetProperty(ref _migrationStatusSeverity, value); + } + + public double MigrationProgress + { + get => _migrationProgress; + set => SetProperty(ref _migrationProgress, value); + } + + public IReadOnlyList? MigrationComponentItems + { + get => _migrationComponentItems; + set => SetProperty(ref _migrationComponentItems, value); + } + + public bool IsMigrationComponentsListVisible + { + get => _isMigrationComponentsListVisible; + set => SetProperty(ref _isMigrationComponentsListVisible, value); + } + + public string? MigrationSummaryText + { + get => _migrationSummaryText; + set => SetProperty(ref _migrationSummaryText, value); + } + + public bool IsRetryMigrationVisible + { + get => _isRetryMigrationVisible; + set => SetProperty(ref _isRetryMigrationVisible, value); + } + + public void ShowStatus(string? titleKey, string? messageKey, TSeverity severity) + { + MigrationStatusTitle = _text($"/WelcomeWizard/{titleKey}"); + MigrationStatusMessage = _text($"/WelcomeWizard/{messageKey}"); + MigrationStatusSeverity = severity; + } + + public void ShowError(string? message, string? errorCode) + { + // The migration session reports some failures with an English message; the code selects the localized text. + string? localizedMessage = _text($"/WelcomeWizard/MigrationError_{errorCode}"); + if (!string.IsNullOrWhiteSpace(localizedMessage)) + message = localizedMessage; + MigrationStatusTitle = _text("/WelcomeWizard/MigrationFailedTitle"); + MigrationStatusMessage = $"{message}\n\n{errorCode}"; + MigrationStatusSeverity = _errorSeverity; + IsRetryMigrationVisible = true; + } +} diff --git a/CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs b/CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs index 1ca7d289..635bc565 100644 --- a/CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs +++ b/CDPIUI/ViewModels/Welcome/WelcomeViewModel.Migration.cs @@ -24,78 +24,66 @@ public sealed partial class WelcomeViewModel private bool _migrationImportInProgress; private bool _migrationReadyToContinue; - private bool _isMigrationMode; - private string _migrationStatusTitle = string.Empty; - private string _migrationStatusMessage = string.Empty; - private InfoBarSeverity _migrationStatusSeverity = InfoBarSeverity.Informational; - private double _migrationProgress; - private IReadOnlyList? _migrationComponentItems; - private bool _isMigrationComponentsListVisible = true; - private string _migrationSummaryText = string.Empty; - private bool _isRetryMigrationVisible; + private readonly WelcomeMigrationPresentation _migrationPresentation; /// True when the wizard runs the GoodbyeDPI migration instead of the ready kits. public bool IsMigrationMode { - get => _isMigrationMode; - private set - { - if (SetProperty(ref _isMigrationMode, value)) - OnPropertyChanged(nameof(IsReadyBundlesContentVisible)); - } + get => _migrationPresentation.IsMigrationMode; + private set => _migrationPresentation.IsMigrationMode = value; } - public bool IsReadyBundlesContentVisible => !_isMigrationMode; + public bool IsReadyBundlesContentVisible => _migrationPresentation.IsReadyBundlesContentVisible; public bool IsMigrationReadyToContinue => _migrationReadyToContinue; public string MigrationStatusTitle { - get => _migrationStatusTitle; - private set => SetProperty(ref _migrationStatusTitle, value); + get => _migrationPresentation.MigrationStatusTitle; + private set => _migrationPresentation.MigrationStatusTitle = value; } public string MigrationStatusMessage { - get => _migrationStatusMessage; - private set => SetProperty(ref _migrationStatusMessage, value); + get => _migrationPresentation.MigrationStatusMessage; + private set => _migrationPresentation.MigrationStatusMessage = value; } public InfoBarSeverity MigrationStatusSeverity { - get => _migrationStatusSeverity; - private set => SetProperty(ref _migrationStatusSeverity, value); + get => _migrationPresentation.MigrationStatusSeverity; + private set => _migrationPresentation.MigrationStatusSeverity = value; } /// Overall migration progress from 0 to 100. public double MigrationProgress { - get => _migrationProgress; - private set => SetProperty(ref _migrationProgress, value); + get => _migrationPresentation.MigrationProgress; + private set => _migrationPresentation.MigrationProgress = value; } public IReadOnlyList? MigrationComponentItems { - get => _migrationComponentItems; - private set => SetProperty(ref _migrationComponentItems, value); + get => _migrationPresentation.MigrationComponentItems; + private set => _migrationPresentation.MigrationComponentItems = value; } public bool IsMigrationComponentsListVisible { - get => _isMigrationComponentsListVisible; - private set => SetProperty(ref _isMigrationComponentsListVisible, value); + get => _migrationPresentation.IsMigrationComponentsListVisible; + private set => _migrationPresentation.IsMigrationComponentsListVisible = value; } public string MigrationSummaryText { - get => _migrationSummaryText; - private set => SetProperty(ref _migrationSummaryText, value); + get => _migrationPresentation.MigrationSummaryText; + private set => _migrationPresentation.MigrationSummaryText = value; } public bool IsRetryMigrationVisible { - get => _isRetryMigrationVisible; - private set => SetProperty(ref _isRetryMigrationVisible, value); + get => _migrationPresentation.IsRetryMigrationVisible; + private set => _migrationPresentation.IsRetryMigrationVisible = value; } /// @@ -386,22 +374,11 @@ private void ShowMigrationStatus( string titleKey, string messageKey, InfoBarSeverity severity) - { - MigrationStatusTitle = Localized(titleKey); - MigrationStatusMessage = Localized(messageKey); - MigrationStatusSeverity = severity; - } + => _migrationPresentation.ShowStatus(titleKey, messageKey, severity); private void ShowMigrationError(string message, string errorCode) { - // The migration session reports some failures with an English message; the code selects the localized text. - string localizedMessage = _localizer.GetLocalizedString($"/WelcomeWizard/MigrationError_{errorCode}"); - if (!string.IsNullOrWhiteSpace(localizedMessage)) - message = localizedMessage; - MigrationStatusTitle = Localized("MigrationFailedTitle"); - MigrationStatusMessage = $"{message}\n\n{errorCode}"; - MigrationStatusSeverity = InfoBarSeverity.Error; - IsRetryMigrationVisible = true; + _migrationPresentation.ShowError(message, errorCode); IsNextEnabled = false; } } diff --git a/CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs b/CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs index 1bda330b..d130c2a3 100644 --- a/CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs +++ b/CDPIUI/ViewModels/Welcome/WelcomeViewModel.cs @@ -16,6 +16,7 @@ using CDPIUI.Helper; using CDPIUI.Helper.Items; using Microsoft.UI.Dispatching; +using Microsoft.UI.Xaml.Controls; using WinUI3Localizer; namespace CDPIUI.ViewModels.Welcome; @@ -48,6 +49,9 @@ public WelcomeViewModel(IWelcomeView view, DispatcherQueue dispatcherQueue) { _view = view; _dispatcherQueue = dispatcherQueue; + _migrationPresentation = new(InfoBarSeverity.Informational, InfoBarSeverity.Error, + key => _localizer.GetLocalizedString(key)); + _migrationPresentation.PropertyChanged += (_, args) => OnPropertyChanged(args.PropertyName); CheckStoreStatusCommand = new RelayCommand( () => _ = CheckStoreStatusAsync(), // CheckStoreStatusAsync catches and logs its own errors. () => _isStoreStatusCheckIdle); diff --git a/docs/governance/document-inventory.json b/docs/governance/document-inventory.json index 5fdd07a6..c1dfac63 100644 --- a/docs/governance/document-inventory.json +++ b/docs/governance/document-inventory.json @@ -1575,6 +1575,66 @@ "policy": "ASD-STE100 principles for English", "language": "en", "changes": "Record nested-latch clarification, observed TDD/mutation/full managed evidence, exact compatibility guards and bounded native delivery gates." + }, + { + "path": "docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md", + "firstIntroduction": "e57f825854c078112b159490b530fa2d080ef64e\tleather147\tRecord ConfigMaker status presentation design and implementation plan", + "first_commit": "e57f825854c078112b159490b530fa2d080ef64e", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Define four-value status ownership, cold typed ports, dynamic notice lookup, one late inline flag, distinct raw/normalized null channels and bounded qualification." + }, + { + "path": "docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md", + "firstIntroduction": "e57f825854c078112b159490b530fa2d080ef64e\tleather147\tRecord ConfigMaker status presentation design and implementation plan", + "first_commit": "e57f825854c078112b159490b530fa2d080ef64e", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Define four-value status ownership, cold typed ports, dynamic notice lookup, one late inline flag, distinct raw/normalized null channels and bounded qualification." + }, + { + "path": "docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md", + "firstIntroduction": "05e00619c256ebde45b79f4688154d4aa33b9876\tleather147\tExtract ConfigMaker status presentation into a typed owner", + "first_commit": "05e00619c256ebde45b79f4688154d4aa33b9876", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Record observed status pipeline TDD, exact mutation restoration, full managed/build/contract checks, accepted native184 composition, retained harness failures, independent reviews and pending draft/CI/local acceptance." + }, + { + "path": "docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md", + "firstIntroduction": "2c1c71a80ad4fa953f09e14130e541e64adba49f\tleather147\tRecord Welcome migration presentation ownership design", + "first_commit": "2c1c71a80ad4fa953f09e14130e541e64adba49f", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Define nine-value Welcome display ownership, interleaved localization, mode-derived reentry, retained host eligibility tail and bounded local/native qualification." + }, + { + "path": "docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md", + "firstIntroduction": "2c1c71a80ad4fa953f09e14130e541e64adba49f\tleather147\tRecord Welcome migration presentation ownership design", + "first_commit": "2c1c71a80ad4fa953f09e14130e541e64adba49f", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Define nine-value Welcome display ownership, interleaved localization, mode-derived reentry, retained host eligibility tail and bounded local/native qualification." + }, + { + "path": "docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md", + "firstIntroduction": "be8808356fd7846ffc9b8bf297b042aa72705fe3\tleather147\tExtract Welcome migration display state into a typed owner", + "first_commit": "be8808356fd7846ffc9b8bf297b042aa72705fe3", + "first_author": "leather147", + "upstream_path_present": false, + "policy": "ASD-STE100 principles for English", + "language": "en", + "changes": "Record observed47case TDD/mutation/full2672, normal/API preservation, technical190fixture compilation and pins, external USERSTOP interlocks, unexecuted runtime boundaries and source-draft/CI ordering." } ], "current_history_base": "7ead95f7756057f67cd113671a7f84cf422e8d32", diff --git a/docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md b/docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md new file mode 100644 index 00000000..190dbc3b --- /dev/null +++ b/docs/superpowers/plans/2026-11-11-configmaker-status-presentation.md @@ -0,0 +1,108 @@ +# ConfigMaker Status Presentation Implementation Plan + +> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:executing-plans inline, task-by-task, with a fresh final independent reviewer. + +**Goal:** Give ConfigMaker's four status values and ordered message publication one focused owner. + +**Architecture:** One internal ConfigMakerStatusPresentation stores explicit initial severity +and three cold title/notice/inline ports. Host public properties/ShowEditorMessage forward, retaining +literal InfoBarSeverity/localizer/EventArgs adapters, one synchronous host bridge and the current flag. + +**Tech Stack:** C#/.NET8.0.427, linked-source xUnit, WinUI3, bounded public inventories, immutable native +corpus and the shared exclusive UI queue. + +**Spec:** [status presentation design](../specs/2026-11-11-configmaker-status-presentation-design.md). + +## Global constraints + +- Issue #228 actual intake149/release150 and accepted225/frozenPR227/3afa precede implementation. +- Use dev/configmaker-status-presentation in Root's existing isolated checkout; retain every old ref. +- Owner <160lines, exactly four values, explicit initial severity and three cold stored ports. +- No constructor invocation/validation; four original equality rules and public/private host accessors. +- Resolve title, dynamically raise host notice, read current inline flag ONCE, then ordered assignment. +- EventArgs normalizes null to empty; inline strings remain raw null. Unknown severity stays raw. +- Preserve callback sender/order, current nested equality, outer locals, exceptions, partial state/retry. +- Existing product edits only main ConfigMakerViewModel.cs; all other partials and operating source exact. +- No XAML/resources/packages/framework/platform stubs/IO/cuts/lifetime/security or other worktree change. +- Every native process and UI call needs owned current lease, reviewed pins and complete postchecks. + +## Review Focus + +- Localization can replace the event subscriber before notice: native real localizer, managed dynamic-port test and literal host adapter guard. +- A notice changes the flag before its one read; a later property callback changes it after that read without stopping the outer publication. +- Nested calls change current equality comparisons while the outer sequence retains its local arguments. +- Existing EventArgs null-to-empty differs from inline raw null; unknown severity uses the default title without enum validation. +- Every port/observer failure preserves identity and completed effects; native auto-property getter/title-null limitations stay explicit. +- Host construction remains cold, all previous composition order stays intact, and the UserControl's second sender bridge remains unchanged source. + +### Task 1: Extract the owned pipeline with portable characterization + +**Files:** create CDPIUI/ViewModels/ConfigMaker/ConfigMakerStatusPresentation.cs and +CDPIUI.Tests/Presentation/ConfigMakerStatusPresentationTests.cs; modify only existing product main +CDPIUI/ViewModels/ConfigMaker/ConfigMakerViewModel.cs and one CDPIUI.Tests.csproj source link; +dedicated design/plan/report plus additive document inventory. + +**Interfaces:** constructor `(TSeverity initialSeverity, Func resolveTitle, +Action raiseNotice, Func getInline)`; method +`Show(string? message, TSeverity severity)`; four owner properties with original names. Host consumes +InfoBarSeverity, preserves its current auto-property and original optional EventArgs publication. + +- [x] Read brief/spec/intake; save normal/source/compiled baselines and original host/partial hashes. + Obtain fresh builder verdict before product code. Inspect accepted178 cases for old-field dependence. +- [x] Write cold test first, run filtered test before owner/source link exists. + Run: `dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore --filter FullyQualifiedName~ConfigMakerStatusPresentationTests`. + Expected: missing-owner CS0246, not a passing placeholder. Then write all behavior cases before implementation. +- [x] Cover explicit nonzero initial severity; null stored callbacks cold; empty/default fields; all setter + equal/null/raw severity rules; title/notice/one-flag/setter trace; disabled-open closure retaining other + values; notice changes flag in both directions; title observer changes flag without stopping; + localization swaps notice subscriber; nested notice/property/outer locals/current equality; + each of three port and four property faults, identity/partial state/retry; repeated/independent models. +- [x] Implement the specified owner and run the same focused command. Expected: all cases pass, zero warnings. + Wire four host properties, public method, explicit initial severity/three cold adapters and one bridge; + preserve all other host statements and partial bytes. +- [x] Controlled mutant: read getInline before raiseNotice, use that value later. Run the focused command. + Expected: meaningful notice/ordering/late-flag failures, no compile failure. Restore exact bytes/hash in finally. + Rerun focused then full `dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore`. + Expected: all pass, no failures/skips, actual counts recorded. +- [x] Run normal GUI `dotnet build CDPIUI/CDPIUI.csproj -c Release -p:Platform=x64 --no-restore` sequentially. + Expected: zero warnings/errors. Verify source451/compiled452GUI88Core retained signatures/shapes, + whole-host/literal adapters/four defaults/property accessors/bridge/cold constructor/partial/footprint + guards, owner line bound, `python .github/scripts/check_governance.py`, whitespace and redacted scans. + Expected: no drift/errors/out-of-scope change. Record failures and checkpoint product commit. + +### Task 2: Qualify actual composition and close the local stage + +**Files:** NEW source-pinned F:/cdpiui-verify fixture and archive, this plan's ignored build/pin/run/ +postcheck evidence, dedicated verification report and additive document inventory. + +**Interfaces:** consumes Task1 product pin and accepted Store178 R2, every old raw case and21cutpaths. +Produces actual ConfigMaker host/private property/public Show/EventArgs/localizer/current-dispatcher +evidence, six new groups, a stacked draft and qualified LOCAL acceptance. Derive every physical count. + +- [x] Read Task1 brief/evidence; retain old178 labels/cases/cuts. Add six actual-composition groups before + build: cold defaults/accessors/closed owner; severity titles/unknown/null event versus field; notice + flips flag/disabled-open carryover/direct setter; nested notice/property/outer arguments/current + equality; each four observer boundaries and notice exception/identity/partial retry; independent + instances/raw setters/equality. Use the actual cold model and a view that rejects operating endpoints. +- [x] Independently review source/case/corpus/scope before build. Build the NEW fixture. + Expected: zero warnings/errors. Pin actual binaries/resources/source/runner/verifier/full prior output + filenames/hashes. Require independent prelaunch READY, no pending pins/process/output and actual PE scope. +- [x] Request a NEW exclusive lease after all peers idle; run one exact owned process. + Expected: exactly184uniquePASS=178+6, all prior prefixes, oneCOMPLETE/0FAIL/exit0/empty streams. + Verify all pins/prior output hashes/resources/source/corpus, exact new names/golden reports/inputs/ + forbidden absence and normal GUI unchanged; exact owned process absence, idle/requestfalse/release. +- [x] Update report; obtain fresh whole-branch independent review on the most capable available model. + Expected: no unresolved Critical/Important. Resolve through observed RED to GREEN/full suite in one + fix pass; ledger every ruling and deferred Minor. Retain all failed attempts/artifacts. +- [ ] Publish draft stacked on frozen dev/store-download-presentation/3afa with Refs #14 and Refs #228. + Expected: exact final-head required checks success and actual PR metadata/Project readback, no merge. +- [ ] Match six criteria to evidence and post six-section LOCAL acceptance. Immediately completed/actual + Done/readback all criteria and metadata. Expected: correct closure reason/labels/assignee/G2/Project + fields, post-edit metadata success and parents13/14/15/earlier drafts open/unmerged. + +## Limits and recovery + +Native actual title-null/localization-subscriber mutation/arbitrary flag-getter faults are not promised; +portable tests and exact source adapters cover their respective boundaries. No loaded UserControl/Page, +visual/accessibility/EN-RU, operating workflow, GC/thread extension, full ABI, installed product/G1/ +integration/release result is implied. Retain every ref and evidence file; use additive corrections. diff --git a/docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md b/docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md new file mode 100644 index 00000000..3d0d53eb --- /dev/null +++ b/docs/superpowers/plans/2026-11-11-welcome-migration-presentation.md @@ -0,0 +1,157 @@ +# Welcome Migration Presentation Implementation Plan + +> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this +> plan task-by-task. Steps use checkbox syntax. Actual Project admission163 and fresh builder verdict are recorded in the spec. + +**Goal:** Give the Welcome migration display cohort one owner while preserving every observable +host value, lookup/notification/assignment order, nested effect and exception boundary. + +**Architecture:** One internal typed nine-value owner with one cold raw-resource callback and +explicit initial/error severities. The host retains public private-set facades, one synchronous +sender bridge, eligibility tail and every session/queue/import/lifecycle responsibility. + +**Tech Stack:** Existing C#/WinUI/.NET8.0.427, ObservableObject, xUnit source links; no new package. + +**Spec:** docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md + +## Global constraints + +- Issue231 actual Project In progress/P2/Architecture/Low/G2/lumenpearson/exact2labels and fresh + builder verdict must precede branch/product/test/fixture implementation. Both admission gates are satisfied before implementation. +- Frozen parent PR230/b0f2c93d66000eb02cd963cf4421173980686e95, existing isolated Root checkout; + new dev/welcome-migration-presentation preserves every old ref/artifact and foreign worktree. +- Only existing main WelcomeViewModel.cs and Migration.cs may change; operating methods and two + other partials/window/XAML/resources/Core/AddOns/Shared/G1 stay unchanged. No new host partial. +- Owner below200lines, exact9values/derivedvisibility, one cold text port, explicit severities, + raw current equality/reentry/partial effects; original host IsNextEnabled=false remains last. +- Serial managed tests then normal GUI build. New immutable native fixture,21inherited cuts, + retained184prefixes+six=190; exact count/pins before independent READY and NEWexclusivegrant. +- Local closure only after independent review, final-head checks, actual PR Project readback, + six-section acceptance and immediate completed/Done/readback; parents13/14/15/drafts stay open. + +## Review focus + +1. A real localizer returns null or mutates state between lookups: portable raw-port cases and + literal adapter prove the specified ordering, while arbitrary native localizer injection is absent. +2. A loaded wizard observer reenters a mode/status/error setter or throws: portable snapshots plus + actual cold-host observer groups preserve partial effects; loaded XAML/layout remains unqualified. +3. A consumer supplies a custom equality list, null or raw non-finite progress: portable and actual + setter composition must retain original EqualityComparer semantics, identity and lack of clamps. +4. An error occurs after retry but during host Next observer: native private-helper reflection + reports its wrapper separately; owner direct exception identity does not imply direct public API. +5. Migration lifecycle or external subscribers change during real work: exact source guards keep + session/CTS/queue/import/projection/readiness unchanged; no actual operating/G1 scenario is claimed. + +--- + +### Task1: Extract the nine-value display owner with characterization + +**Files:** NEW CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs; +MODIFY main WelcomeViewModel.cs and Migration.cs only; NEW +CDPIUI.Tests/Presentation/WelcomeMigrationPresentationTests.cs and additive CDPIUI.Tests.csproj links +for the owner plus MigrationComponentDisplayItem if not already linked. NEW dedicated verification +report and additive docs/governance/document-inventory.json record. +Ignored baseline/source/hash/mutation/review evidence stays in this issue workspace. + +**Interfaces:** owner constructor(TSeverity initialSeverity,TSeverity errorSeverity, +Func text), nine properties with exact host names/types, read-only +IsReadyBundlesContentVisible, ShowStatus(string? titleKey,string? messageKey,TSeverity severity), +ShowError(string? message,string? errorCode). The baseline source and executable normal GUI/Core +composition snapshots are immutable inputs; Task2 consumes the resulting product commit and logs. + +- [x] Read brief/spec; capture original normalized whole main/Migration and raw other2partial/window + hashes; baseline451source/452GUI88Core contracts and adjacent normal GUI/Core binaries. Preserve + any unrelated Core output separately. Expected: exactb0 clean named branch after actual admission. +- [x] Add DefaultsAreCold before owner/link. Run focused command: + C:/Users/lumen/.dotnet/dotnet.exe test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore + --filter FullyQualifiedName~WelcomeMigrationPresentationTests. + Expected: CS0246 missing WelcomeMigrationPresentation, not a platform-stub/dependency failure. +- [x] Write all behavior cases before implementation. Required names/assertions include: + NineDefaultsAndExplicitSeveritiesAreCold (null port not invoked), + EachSetterKeepsRawValueAndEquality (all9/progressNaN,Infinity,signedzero/unknown enum/null), + ComponentListKeepsReferenceAndDefaultCustomEquality (same,distinct,equal-override,null), + ModeNotifiesDerivedAfterPrimary (snapshots/order/equal suppression), + NestedModeReversalStillLeavesOuterDerived (current getter and both inner/outer derived events), + ModeObserverFailureStopsDerivedAndRetryUsesCurrentValue (sentinel/changed field/no extraevent), + StatusAssignsTitleBeforeResolvingMessage (observer changes subsequent resolver result), + StatusUsesRawKeysNullsAndUnknownSeverity (literal prefixes/interpolation/raw values), + NestedStatusFromLookupOrPropertyKeepsOuterLocalsAndCurrentEquality, + StatusFaultAtEachLookupAndPropertyKeepsExactPartialStateAndRetry, + ErrorChoosesOnlyNonWhitespaceLocalizedMessage (null/empty/white/nonempty), + ErrorKeepsRawNullArgumentsAndLiteralTwoNewlines, + ErrorOrdersLookupTitleMessageSeverityRetry, + NestedStatusOrErrorDuringErrorKeepsOuterLocalMessageAndCurrentEquality, + ErrorFaultAtEachLookupAndPropertyKeepsPartialStateAndRetry, + IndependentOwnersDoNotShareValuesCallbacksOrLists. + Expected: explicit traces/current-state snapshots and same sentinel object; no implementation mirror. +- [x] Implement exact owner, then run focused command. Expected: all cases pass,0warnings. + Wire nine private-set facades/derived getter/two wrappers and one cold constructor bridge. + Preserve every original operating statement; no host Next port/value or command side effect. +- [x] Controlled mutant: eagerly store message text before assigning title. Run same focused command; + expected meaningful ordering/reentry/fault FAIL with successful compilation. Save exit/log and + restore exact owner bytes/hash in finally. Rerun restored focused then full dotnet test. + Expected: all pass, actual counts/failures/skips/timing recorded, no hardcoded count borrowed. +- [x] Build normal GUI Release -p:Platform=x64 --no-restore after tests, expected0warnings/errors. + Run source451/compiled452GUI88Core bounded inventories, exact normalized host reconstruction, + literal moved status/error bodies under only stated lookup/errorseverity substitutions, nine + defaults/SetProperty setters/mode-derived/host-tail/accessors/onebridge/ctororder/otherpartial/ + window/footprint/source-link guards, governance, whitespace and redacted changed-file scans. + Expected: no drift/unexpected product path/new resource/package/cut; record actual line counts. +- [x] Update report/inventory and checkpoint product. Expected: named product SHA with source/test + and exact managed/normal evidence; no native acceptance inferred. Preserve all failed harness attempts. + +### Task2: Qualify actual Welcome composition and close the local stage + +**Current resumption and tool correction:** the later explicit human231 UI/native message was +verified through its thread user-message record. Historical Esc evidence and the original blocked +packet remain intact. An additive operationalr2 rejects optimized Python and removes all queue +mutation entrypoints; isolated RED2failures→GREEN4groups preserves competing writes. A separately +acknowledged sole Root coordinator serializes owner grants/releases under a named mutex. No source +or compiled case changed. Fresh operational/prelaunch review, peer idle and an exact new native +grant remain mandatory; prior167 and technical readiness cannot authorize execution. + +**Historical external-stop ordering amendment:** physical user Esc167 held UI/native execution and queue +handoffs. After technical compilation/pinning and independent whole-range SOURCE review, a clearly +incomplete stacked draft and hosted final-head CI may precede runtime execution. Keep native and +actual PR Project checks outstanding. The run, retained-runtime review, case-specific acceptance +and completed/Done steps below remain required; this amendment does not complete Task2 or waive +the user stop. Later changed source needs new verification, and a new user UI/native scope plus +fresh prelaunch/peer idle/grant must precede any native GUI launch. + +**Files:** NEW F:/cdpiui-verify source-pinned fixture/archive, ignored case/bootstrap/source/pin/ +run/resource/corpus/process/queue evidence, dedicated report and additive inventory. + +**Interfaces:** consumes Task1 product pin and immutable ConfigMaker184 fixture/corpus; produces +six new actual cold Welcome composition groups,190exact corpus, independent review, stacked draft, +final-head CI/actual metadata and case-specific local acceptance. No new operating boundary. + +- [x] Read Task1 brief/evidence, retain every184label/rawcase/21cut. Add six groups from the design + before build. Actual cold WelcomeViewModel/currentdispatcher/typedowner/privateprops/helpers, + rejecting view endpoints, no commands/session/queue/import/lifecycle; detach test observers and + dispose only each own CTS. Expected: full source/cuts/corpus reconstruction; raw reflection + exceptions distinguished; no new endpoint cut or forbidden operation. +- [x] Independent pre-build source/case/corpus/containment review, then build NEW fixture. + Expected0warnings/errors. Derive/pin actual binaries/resources/source/runner/verifier/old outputs; + verify JSON/generated resource parity, actual PE/nonadmin/absence. Independent prelaunch READY. +- [x] Request NEWexclusivegrant after peers idle; recheck actualowner/pins/absence, run one owned + process. Expected190uniquePASS/all184olderprefixes/COMPLETE1/FAIL0/exit0/streams0, allsource/ + resources/input/prioroutput/newnames/goldens/forbidden/currentnormal identities preserved. + Check separate PID/exactEXE absence, idle/requestfalse/pendingfalse/guardrelease/readback. +- [x] Update report, fresh whole-range independent review on most capable available explicit model. + Expected0unresolvedCritical/Important. Fix through observed RED→GREEN/fullverification as needed; + record every ruling/deferredMinor with costs. Documentation-only corrections retain artifact identity. +- [ ] Publish draft stacked on frozen dev/configmaker-status-presentation/b0 with Refs#231 and#14. + Expected exactfinalHEAD checks success, hosted count observed, actual PR labels/owner/G2 and + Project Inprogress/P2/Architecture/Low verifiedafterfreshnavigation; no parent/main merge. +- [ ] Match six criteria, post six-section LOCAL acceptance, immediately closecompleted/actualDone/ + readback all criteria/metadata and post-edit authoritative status; parents13/14/15open/drafts unmerged. + Expected source/currentpins/retainedruntime/closure/readback final check passes without relaunch + of immutable accepted fixture; finalledger records precise execution boundaries. + +## Recovery and limits + +Use additive corrections and preserve all refs/evidence/worktrees. No deletion/reset/clean/force. +Source-only policy guards do not replace the named native host groups; those do not replace loaded +wizard, operating/G1, installed-product, integration or release acceptance. Keep original task2 +publication checklist snapshot frozen at reviewed HEAD; current ignored ledger/brief/issue receipt +record subsequent metadata closeout without moving an already verified source revision. diff --git a/docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md b/docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md new file mode 100644 index 00000000..19183afd --- /dev/null +++ b/docs/superpowers/reports/2026-11-11-configmaker-status-presentation-verification.md @@ -0,0 +1,194 @@ +# ConfigMaker Status Presentation Verification + +## Revision and local boundary + +Issue #228, Root-owned dev/configmaker-status-presentation, existing isolated +`C:/Users/lumen/.codex/worktrees/audit-class-decomposition/cdpiui`. +Frozen parent: PR #227/`3afa82e3f4947ce4bef38b14d86c642c93ddbe90`. +Design checkpoint: `e57f825854c078112b159490b530fa2d080ef64e`. +Fresh builder configmaker_status_design_check read the design/plan/source and reported +"nothing important left" before product or test implementation. This is not final code acceptance. + +Actual issue Project intake149 was verified through a fresh browser navigation: In progress/P2/ +Architecture/Low/G2/lumenpearson, exactly type:refactor and area:architecture. The original reload +left a blank Project body; a new tab in the same selected browser loaded persisted fields, without +repeating field mutations. A diff-only AX proof assertion failed before evidence writes; a full +tree then supplied the record. Two owned tabs closed, requestfalse/idle149/release150.previous149/ +all six paused were verified. Parent local #225 is completed/all six criteria/actual Done147; +final receipt6803654520 and post-criterion metadata43075493266 succeeded on its own frozen head. + +## Ownership and preserved behavior + +One internal ConfigMakerStatusPresentation owns four observable values and the original +message sequence through three cold ports. Initial severity is explicit; production uses the +original InfoBarSeverity.Informational. Its title/notice/inline callbacks are stored without calls +or validation. Main source381 becomes369; the nine-partial sum986 becomes974. The owner has68lines. +These counts supplement the responsibility boundary rather than define acceptance. + +Four host properties keep their public/private accessor visibility, including public IsStatusOpen. +Public ShowEditorMessage forwards. One synchronous bridge publishes the VM sender. The host retains +the original literal severity/localizer adapter, optional current event lookup, existing EventArgs +construction and current UseInlineStatusMessages. Other eight partials, UserControl/second sender +bridge, EventArgs, XAML/resources/packages and all operating source remain unchanged. + +Show resolves a local title, raises the notice, reads inline once and then publishes title/message/ +severity/open, or only closes open when disabled. Nested effects stay current while outer local +arguments continue. Later property callbacks changing inline do not stop the outer sequence. +Each equality comparison uses the current value. Exceptions keep identity and completed partial +effects without catches, rollback or snapshots. Existing EventArgs converts null strings to empty; +inline strings stay raw null. Unknown severity keeps its raw value and original default title. + +## Managed execution and controlled mutation + +Windows/.NET8.0.427. The first cold test ran before the owner/source link and observed CS0246. +All subsequent behavior cases were written before implementation. First owner run passed37/37 in +30ms with zero warnings. The initial atomic source patch used an incorrect Link path anchor and +failed before any write; the actual existing Linked convention was then read and used. + +The controlled mutant read inline before notice. It produced21behavior failures/16passes/37total +in40ms, with no compilation error. The wrapper then failed to print a Unicode arrow through cp1251, +after saving the actual test log/exit1. Its finally block restored exact owner bytes and SHA256: +`E6F6A012E6DF7C31EEFDF58B83DC07CDE9A652517B6B824F976F5C56E3EC5BD9`. +Root separately validated the retained FAIL markers, subprocess exit and restored hash; no identical +mutant rerun was used to replace that history. Restored focused37/37 passed in27ms. + +`dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore` passed2625/2625 in10s, +zero failures or skips. The focused set covers cold ports/nonzero severity, four setters/equality, +raw null/unknown values, ordered callbacks, late flag, disabled carryover, current subscriber changes, +nested notice/property/title resolution, current equality/outer locals, three port/four observer +failures, disabled close/retry, nested partial failure and independent instances. + +Sequential normal GUI command: +`dotnet build CDPIUI/CDPIUI.csproj -c Release -p:Platform=x64 --no-restore`. +Result: zero warnings/errors,45.10s. Normal GUI SHA256: +`950A924D49B387DE0355CE4BB39680AA343D4DC731ADFF7859160280E9A4D3D8`. + +## Source and compiled contracts + +Whole-host reconstruction permits exactly four fields-to-owner, four facade properties, cold +composition/bridge and public method substitutions. The original Show body reconstructs exactly +under three declared port substitutions. Four defaults/equality/accessors, explicit severity, +dynamic event/unchanged EventArgs, one late flag, cold constructor/prior order, eight partial hashes, +existing product footprint and one linked test source pass. The first adapter guard incorrectly +compared a statement semicolon with a constructor-argument expression; the pre-fix guard is retained. +Removing only that terminator from the comparison passed without a product correction. + +Source comparison:451 original exported types across621 to622 GUI C# files, zero removed/changed +signatures. This syntax inventory does not semantically compare all inheritance/inferred types. +Compiled comparison:452 GUI and88 Core exported type shapes, zero removed/changed or retained-type +additions. This excludes a full attribute/annotation/forwarding/interop/behavioral/native ABI claim. + +Baselines were copied before builds. GUI baseline SHA78D188F6 is the frozen Store normal artifact. +The initially selected Core/bin/Release/net8.0 output C0DCC92C is retained separately and was not used +for a claimed comparison. The actual GUI composition baseline uses its adjacent Core artifact, +SHA F6DA49E4E197888ED53901722E6A8E4C0381A2F04B5FBE8BAE565BF72BA9CC41. +Core source is unchanged; its physical rebuild identity is separate from older stage artifacts. + +## Native actual-composition qualification + +A NEW immutable fixture is `F:/cdpiui-verify/cdpiui-configmaker-status-05e0061-20261111`, +archived from product pin `05e00619c256ebde45b79f4688154d4aa33b9876`. The archive SHA256 is +`09726670606010D085870CC24412DD41CBFD2F0AC16DA6C0DA7F8015DF2D1F78`. +The archived report retains the initial 69-line prose; this later evidence commit corrects the +physical count to 68. Product and managed-test bytes remain the executed checkpoint. + +Source reconstruction verifies all 1608 Git inputs after declared CRLF normalization, exact 21 cuts, +20 whole cut files raw-byte identical to accepted Store178 R2, and only the Directories EXE literal +changed in the remaining cut. All 35 old scenario partials are raw-byte identical. There are 37 +bootstrap files, 41 allowed extras and no reparse entries. The exact 178-label prefix plus six new +unique labels forms 184. No operating cut or IO boundary was added. + +The explicitly authorized independent peer completed read-only source/test/log/API/hash review +without actionable source findings. Its separate pre-build READY reconstructed the archive/fixture, +case and recipes. Roslyn 4.8 AST inspection found zero syntax diagnostics, 25 local declarations +and zero ancestor-block conflicts; lambda/catch/foreach scopes were also inspected. This was not +compilation. Its initial raw-archive comparison and Strings.json assumption were corrected in its +own reads only. SDK 4.11 Add-Type did not load; the inspection used actual built-in Roslyn 4.8. +PowerShell and Python parsing passed. No review call built, launched, mutated source or used UI. + +The native build then passed with zero warnings/errors in 78.00 s. Pinning produced 77 actual +inputs: 5 binaries, 20 resources and 52 source/evidence files, including host/owner/EventArgs and +unchanged UserControl source. All 522 prior output filenames/hashes are recorded. Twenty packaged +resources equal generated bytes, all 5206 entries equal source JSON, and 54 keys satisfy their +English checks. Attention/Information can legitimately equal their keys; actual cases assert the +three exact text values. All recipe PENDING markers were filled before prelaunch review. + +Independent prelaunch READY rehashed all 77 inputs and 522 prior files and reconstructed sources, +resources and corpus. It parsed the actual EXE: AMD64 PE32+, Windows GUI, one embedded manifest, +asInvoker and uiAccess=false. The current token was non-admin; the exact process and future outputs, +seven forbidden paths, custom markers and readiness request were absent. Parsing again had no errors. +Root immediately repeated packet/artifact/baseline hashes, process absence and non-admin checks. + +| Artifact | SHA256 | +| --- | --- | +| Native GUI DLL | `530AD45FEDF3085EC2B5F864618126A8BF54901A1C439B990C64221475E75648` | +| Status case | `17F0FF20CE9CB1B5A4EE66263AE435E33EC21805E0BB4EF47819C2A70E87B4BF` | +| Runner | `58112DC687F58C3E9D4BFAB85780A248C70656EE1D9120DA4F1940F29A5EDE51` | +| Runtime verifier | `2F4016E7816187B1C2CD7D476753EF565CB71FC0201E235E5A9CDCA23C72650C` | +| Full output baseline | `B865E7553E0E4F1F846BB0CDB74D02751A1D2F04681EF00889DC656197CD4AEA` | +| Corpus | `E61E9C08008C5E89625E0F7C78AC10CDBEAC165678A81F087A8A82CC30BA87C2` | + +After fresh queue150 owner-null/released/all six paused/no other ready request, Root obtained +NEW explicit151 with byte/hash guards and an actual readback. Lessons confirmed no ready/pending +UI/ADB and localization confirmed none, with #226 still Ready. One exact owned PID89224 ran from +2026-11-11T19:02:26.2190286Z to 2026-11-11T19:02:32.4840147+00:00. All 184 unique groups passed, +including exact 178/172/166/160/154/149/137 prefixes and peer141 projection, one COMPLETE, zero FAIL, +exit0 and empty stdout/stderr. No second launch was used. + +After exit, all77 inputs/all522 prior hashes, full source/cuts and resources passed. Exactly six new +names made528 files. Three literal inputs retain16/16/15bytes; two real serializer outputs retain +354/260byte golden contents and current model fields. Seven forbidden paths/custom markers remain +absent and normalGUI950A stays unchanged. Root separately checked owned PID/exact EXE absence, +read-only retained-evidence verification, idle151/requestfalse/pendingfalse and guarded release152 +with previousVersion151, owner null and all six participants paused. + +The six new groups qualify actual cold ConfigMakerViewModel/closed owner/current dispatcher, +public/private setter access/equality/VM sender; real severity text/raw unknown values/normalized +EventArgs versus raw inline null; notice changes before the late inline read/disabled carryover; +nested notice/property effects/current equality/outer locals/one flag decision; four observer fault +boundaries, notice/nested identity/partial effects/retry; and independent models/raw setters/repeat. +The view rejects operating endpoints. Public ShowEditorMessage is called directly for fault cases; +reflection only supports private setter/accessor characterization, with its wrapper handled separately. +All external handlers detach in finally through the case host's disposal. The new six status groups +add no OnViewLoaded, help/document/test workflow, file operation, desktop input, UAC or operating +endpoint. Inherited owned inputs and serializer IO retain their declared older boundaries. +The coordinated independent retained-runtime review accepted this bounded result with no actionable +findings. It independently rehashed77/all522, reconstructed source/cuts/resources/corpus, checked +literal inputs/reports/new names/forbidden absence and read frozen grant151/release152/idle/request. +A separate current CLI read confirmed PID89224 absent and exact fixture processes zero. It executed +no product, build, tests, writers or UI and does not replace the fresh whole-range review. + +## Fresh whole-change review + +Fresh reviewer configmaker_status_final_review used explicit gpt-6-astra/xhigh on the complete +`3afa82e3f4947ce4bef38b14d86c642c93ddbe90` through +`a3b7252e49cbda8fb8e1b11738fe315c52875ba3` range: three commits, eight files. +Findings: zero Critical, zero Important and one Minor concerning two stale documentation phrases. +The caller-null test is now described as executed; the inventory summary now includes completed +bounded native qualification and keeps only delivery acceptance pending. These record corrections +implement the user's current-evidence rule, without changing product/test/native bytes or rerunning +accepted execution. The Minor is addressed; no code correction was requested. + +The reviewer independently reconstructed the host, cold ports, properties, current flag/event and +nested partial-effect semantics; read the managed RED/mutation/restoration/full/build evidence; +and verified source/compiled/hash records. It separately reconstructed native source/cuts/cases/ +resources/corpus and rehashed all77/all522, inputs/reports/output names and lease/process evidence. +It executed no tests, build, application, verification writer or UI. The earlier coordinated reviews +and this fresh whole-range review have distinct attribution. Every behavior declined by the fresh +reviewer has an executor ruling and cost in the ledger. The scoped verdict supports a stacked draft, +contingent on final-head CI, actual PR Project fields and immediate local issue acceptance/readback. + +## Pending delivery gates and limits + +Native actual title-null/localization-subscriber mutation/arbitrary inline-port failures remain +managed/source boundaries where uncut production adapters cannot produce them safely. The native +caller-null case proved EventArgs.Message empty versus inline StatusMessage null. Actual VM +sender evidence does not certify the unchanged UserControl's second sender bridge at runtime. +Full loaded Page/UserControl, visuals/accessibility/EN-RU, operating workflows, GC/concurrency, +all metadata/native ABI, installed product/G1/integration/release remain separate. + +Draft publication/final-head CI, actual PR Project fields, six-criterion +local acceptance and immediate completed/Done/readback remain pending. Retain all refs/worktrees/ +archives/accepted or rejected evidence. Raw evidence belongs to this plan's ignored +`.superpowers/sdd/2026-11-11-configmaker-status-presentation/` directory. +Refs #14 and Refs #228. Parents13/14/15 and the earlier draft stack remain open/unmerged. diff --git a/docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md b/docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md new file mode 100644 index 00000000..1e077aee --- /dev/null +++ b/docs/superpowers/reports/2026-11-11-welcome-migration-presentation-verification.md @@ -0,0 +1,263 @@ +# Welcome Migration Presentation Verification + +## Scope and source identity + +Issue #231 accepts a LOCAL nine-value/two-policy display extraction. Frozen parent is draftPR230 +at b0f2c93d66000eb02cd963cf4421173980686e95; design checkpoint is +2c1c71a80ad4fa953f09e14130e541e64adba49f. Product checkpoint is +be8808356fd7846ffc9b8bf297b042aa72705fe3; later evidence changes are documentation only. +Root owns the isolated audit-class-decomposition checkout on +dev/welcome-migration-presentation. Windows/.NET8.0.427 is the execution environment. + +Actual Project intake163 was read after fresh navigation: one matching open issue231 row, +In progress/P2/Architecture/Low/G2/lumenpearson/exactly area:architecture+type:refactor. +FullAX/JPG/JSON/item+viewURL are retained in the shared issue231-project-intake directory. +Root closed tabs6/7, recorded idle/requestfalse/pendingfalse and guarded release164/all six paused. +Fresh builder welcome_migration_design_check read the written proposal/current source and returned +"nothing important left". A coordinated peer independently checked the issue/admission and proposed +boundary; this is distinct from the future whole-range implementation review. + +Live main advanced separately from6c00 to21555a29ce9fba98c678c445d04ee9f6ce3c85ba through +language-selector PR229, six localization/test paths with no Welcome change. This stage keeps +the named frozen b0 inputs and does not borrow229 installed results or claim whole-main equivalence. +Another explicitly assigned owner now integrates the earlier stack through227 in a separate +checkout under14; Root230/231 remain outside that integration scope and all original refs/artifacts are preserved. + +## Characterization and controlled mutation + +The first cold-default test and a link to the actual eight-line MigrationComponentDisplayItem +preceded the new owner/owner link/host changes. The focused command observed CS0246 for missing +WelcomeMigrationPresentation, exit1. All47 characterization cases were then written before product +implementation. They use actual ObservableObject/actual display-item source and an owned severity +enum, without WinUI stubs. + +Cases cover nine defaults/setters/equality/raw null, explicit initial/error severity/unknown values, +mode then derived snapshots, nested reversal and observer-failure/equal-retry behavior, list +reference/null/custom Equals retention, NaN payload/signed-zero/Infinity equality semantics, raw +resource keys and lookup interleaving, nested lookup/property/status/error effects and outer locals, +each owned lookup/property failure boundary with exact sentinel identity/partial effects/retry, +error whitespace fallback/literal double-newline and independent instances. Equal signed-zero or +NaN assignments can retain existing bits, as original SetProperty requires. + +`dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore --filter +FullyQualifiedName~WelcomeMigrationPresentationTests` first passed47/47/30ms,0warnings. + +A controlled mutant resolved the message before assigning title. The same command compiled and +failed9cases, passed38, skipped0, total47,40ms, exit1. The failed traces include the title observer's +effect on the subsequent lookup and fault/reentry ordering. The one-shot wrapper saved the real +log/exit and restored the owner bytes in finally. Restored SHA256: +8B5311A75216851D72BEC72D3D401547B630E4D7DE1640DF2CE30551F0AA14EE. +The restored focused run passed47/47/24ms,0fail/skip/warnings. + +The full `dotnet test CDPIUI.Tests/CDPIUI.Tests.csproj -c Release --no-restore` then passed +2672/2672 in10s, zero failures/skips. These counts belong to this frozen-branch composition, +including its47new cases; no separately integrated229 tests are counted. + +## Normal build and preservation guards + +After tests, normal `dotnet build CDPIUI/CDPIUI.csproj -c Release -p:Platform=x64 --no-restore` +succeeded with zero warnings/errors in45.22s. Normal GUI SHA256: +8D46633D07827850E8ECCF69D99A1402B3502203F6419C9B8DE3A6A0DF0E3A65. +Its adjacent Core SHA256: +264B96B45E6EAB6FA66863C725CBA5C04388A55BE3A1F6253D3CA4EA8CE975C3. + +Before product compilation, the current normal baseline pair was retained: +GUI `950A924D49B387DE0355CE4BB39680AA343D4DC731ADFF7859160280E9A4D3D8`; +adjacent Core `8079F71D001046BB10E24A1A43433BE2A12E158901C65827FECB3A0D03973FE1`. +Self-inventories show452GUI/88Core exported shapes. Candidate +comparisons show zero removed/changed shapes and zero retained-type additions for452GUI/88Core. +Assembly versions/compiler attributes and full annotation/interop/forwarding/native ABI are outside +this inventory. Source syntax comparison shows451exported types across622→623GUI C# files with +zero removed/changed original signatures; base/interface semantics and inferred types remain limited. + +The whole normalized original main and Migration host reconstruct exactly under15declared +substitutions. Literal moved status/error bodies match under only raw-resource/error-severity +substitutions. Guards verify nine defaults/SetProperty equality, mode-derived sequence, explicit +severities, one cold resource port, original private-set facades, host Next tail after owner return, +one synchronous VM-sender bridge and original constructor statement order. The two other migration +partials and WelcomeWindow XAML/code-behind have identical raw hashes. Only the two existing +Welcome host files plus one new internal owner change in product; Core/AddOns/Shared and all +other product files are unchanged. The tests add only the two declared actual-source links. + +Owner108physical lines; main279→283, Migration407→384; four-partial Welcome sum983→964. +The helper is a separate owned responsibility; partial sums and public compatibility facades are +reported separately from a file-length threshold. + +## Retained preparation failures and decisions + +The initial baseline preparation used the prior228 BEFORE-stage Core hashF6DA49 as an expected +current hash. Its assertion stopped after writing inventory/host snapshots/GUIcopy, before Core +copy/baselineJSON/commit message/product execution. The enclosing PowerShell shell continued +documentation checks; their exit0 was not Python success. The partial writer was not rerun. +Targeted completion retained the actual current adjacent8079Core with950GUI, leaving the old F6 +artifact intact in228. Current source/compiled compatibility remains separately checked. Subsequent +dependent commands check their own exit code before progress or publication. + +An exploratory read mistakenly printed a large prior source-input JSON. Future reads use metadata +or bounded summaries; no such input/log is published as a complete issue attachment. Several path +lookup attempts failed before finding the existing analyzer subdirectory; no execution result was +inferred from those reads. Failed attempts and corrections remain in ignored local evidence. + +Executor decisions: one domain owner with a cold callback/explicit severities; preserve host +eligibility, session/CTS/queue/import/projection/aggregate/readiness/lifecycle literally; prepare +ignored design proposals during UI wait but admit actual metadata before implementation; keep frozen +parent despite live-main movement; retain artifacts instead of destructive cleanup. These are +executor choices under autonomous authorization, not additional user design approvals. + +## Technical native preparation and initially held runtime + +NEW fixture F:/cdpiui-verify/cdpiui-welcome-display-be88083-20261111 comes from productbe880. +Archive SHA256 DD03B4024F006B443E65FFD3E10CCFB352511E412DADEDC2DCFEF1578F2505A8. +All1613Git inputs match after CRLF normalization; exactly21inherited cuts remain,20raw identical +plus one Directories EXE literal. All36old case partials are raw-identical;38bootstraps/42allowed +extras/no reparse are reconstructed. The retained184log/hash/corpus plus six unique new labels +define190expected groups with all older prefixes. Those are prepared scenarios, not passed runs. + +The coordinated independent peer returned READY FOR TECHNICAL COMPILATION ONLY,0actionable +findings: all13frozen inputs/archive/source/corpus/containment, actual rejecting IWelcomeView and +cold session/readiness/latches/collections/owned CTS were checked. Roslyn4.8 found0syntax errors +and0nested-name conflicts in78local/parameter/lambda/catch/foreach declarations; PythonAST/PSparse0. +This was no compile/runtime verdict. A precompile wrong model namespace was corrected to actual +Core.Store.ViewModels before the packet; no test result was inferred from that edit. + +The NEW fixture then compiled with0warnings/0errors in77.61s. Post-build source/cuts/old-case +reconstruction passes. Actual pins are86inputs:5binaries,20resources and61source/evidence files; +all522prior output filenames/hashes are recorded. All20packaged resources equal generated bytes +and5206sourceJSON entries;60known keys are nonempty, two expected unknown error keys are absent. +Actual PE is AMD64/PE32+/WindowsGUI with one embedded asInvoker/uiAccessfalse manifest. +Native DLL SHA256 7E6FD2BBB9623CDF0C9BDD26AF7CC69854E83FDBD5762E226368CEBBE6FFAD99. +Runner SHA25645B490C7BC5599B761AD28F28A78F462E14C69FA5C3037B1E1D696AE2D42A588; +runtime verifier SHA256A9F14C1F08EC2C2EFA9796B7F20A7B211C30A1E93EA56B7EE8D7181F8D910CF1. +At the technical checkpoint, the normal GUI remained8D4663 and no new native run/output existed. Post-build technical peer review was +requested separately and cannot grant execution. No accepted old fixture was modified or rerun. + +Six groups are written for actual cold composition/accessors/closed owner/dispatcher/VM sender, raw values/ +list equality/NaN/mode reentry and primary plus derived observer faults, real status resources and +nested continuation, error localization/fallback/Next tail, private status faults and error/Next +faults/retry/nested/final observer effects. Derived-observer failure is source-only in the47managed +cases; its new native assertions are unexecuted. Actual missing-key whitespace behavior remains +an unexecuted runtime precondition. Private reflection wrappers are distinct from direct portable +owner exception identity. The prepared view rejects every endpoint; case code does not invoke an +operating session/queue/import or window lifecycle. Its cleanup detaches test observers and disposes +only the owned framework CTS. These statements describe inspected code, not an executed190run. + +At that technical checkpoint, fresh whole-range SOURCE review, draft publication and hosted CI +could precede runtime under the documented external-stop amendment. Native execution/retained-runtime review, +actual PR Project fields, six-section LOCAL acceptance and immediate completed/Done/readback +were mandatory and incomplete. Parents13/14/15 and earlier drafts retain their separate acceptance; +this report does not merge them or declare Task2 complete. + +The shared UI has a separately retained failed Lessons AVD process object from161, with no test +run and no full process-absence/cleanup acceptance. Explicit qualified162 was for Project-only +handoff, not future native authorization. Root163/loc165 were browser-only; future231native requires +its own fresh prelaunch scope, current peer idle and explicit grant. A separate167Lessons recovery +uses a NEW isolated VM under its own reviewed scope, not this product's verification evidence. + +After the managed/build checks, a physical user Esc stopped Computer Use during167. Root halted +all UI, native GUI launches and queue handoffs. This was a real execution stop, retained in the +original packet. A later explicit human message in peer chat01a1c049 authorized UI resumption and +the231 native/review/CI/Done scope. Root verified its user-message identity +01a1cc84-1b9f-7e11-a6ac-7647c56100f8 through the thread API. Separate explicit human messages +authorized Project14 only and the Lessons731 continuation. Those scopes are not interchangeable. +Fresh qualified167 idle, actor acknowledgements and a sole Root owner-writer protocol preceded +release168/Project14-only169/release170/Lessons171. No lease was reused after Esc. The old77492 +process qualification remains unresolved; another session owns that environment. At that resumption +checkpoint, Root had not executed the231 fixture or completed its native, actual PR Project or +acceptance gates. The later native and Project results are recorded below; final LOCAL acceptance +still requires the delivery-HEAD checks and completed/Done readback. + +## Whole-range source review and operational corrections + +Fresh independent reviewer /root/welcome_migration_source_draft_review, explicitly selected +gpt-6-astra/xhigh, reviewed b0f2c93..2879047: three commits/nine files. It reconstructed both +hosts, compared retained source/compiled/test/build evidence and actual86pins, and found no +Critical or Important product finding. The reviewed tracked range is suitable for a clearly +incomplete stacked draft and hosted CI. The reviewer ran no tests, GUI or native process. + +Two Important findings apply to supplementary operational tools. Python optimization removes +assert-based checks; the old queue helper also separates expected-byte comparison from replacement. +Both defects were reproduced ONLY under retained isolated F:/cdpiui-verify/controls directories: +two regression failures, zero errors. The optimized old request bypassed a blocked hold and a +foreign active owner; a deterministic competing write was overwritten before replacement. These +controls never addressed the shared queue or launched an executable. + +The additive native-operational-r2 packet preserves all23original packet files, including its +blocked hold, without changes. Every copied Python recipe rejects -O, -OO and PYTHONOPTIMIZE +before evidence or state access. The queue helper accepts only a read-only preflight; request, +grant and release fail before access. The runner checks an exact expected lease version and calls +this preflight twice, with its guarded verifier pinned. Four regression groups pass with no skips, +including all optimized recipes, disabled mutations, competing-owner retention and hold/foreign +lease refusal. PowerShell syntax passes. Fresh checks retain all86fixture pins,522prior files, +the normal GUI hash and the absence of runtime output. There is no reason to rebuild the identical +fixture for this operational correction. + +Actual shared owner changes use a separate, acknowledged single writer: Root alone performs +grants and releases under one named Windows mutex, with fresh owner/request/idle guards and +readback. Actors write only their own request/idle receipts. This is a cooperative protocol, not +a global filesystem compare-and-swap guarantee. Archived actors were not reactivated. A mistaken +participant flag in169 was rejected by its owner before any UI call; Root corrected the explicit +actor-to-flag mapping under the mutex and retained both records before that owner proceeded. + +Two Minor coverage observations remain deferred. The portable nine-setter theory compares the +second result with the first instead of explicitly checking every first supplied finite value; +literal setters, source reconstruction and the separate raw/nonfinite cases supply current proof. +The cold native host subscribes after construction, so its empty event list covers only the period +after subscription. Constructor coldness comes from inspected initialization/host source, not +that later observation. No claim about earlier observed notifications is made. + +The new r2 hold records verified human resumption. It grants no native authority by itself. +Original source/case/binary/resource evidence remains at productbe880. + +## Actual bounded native execution + +Independent peer01a1c049 first returned CONDITIONAL OPERATIONAL READY after checking all28r2 +inputs and the isolated controls. It then performed a separate fresh prelaunch read of released172, +canonical candidate173, current qualified Lessons171 idle, all six UI flags, no pending calls, +the verified human scope, exact fixture process absence/nonadmin context and all86pins/522files. +Its READY allowed one future exact173 run. A new PR233 Project request arrived after that read; +Root paused the grant and its owner temporarily set its own request not-ready. Fresh empty-ready +guards then passed. Only Root published173 under the mutex and verified the readback before launch. + +The r2 runner executed one owned asInvoker process, PID87792, from +2026-11-11T21:57:06.6019765Z to21:57:09.8547920Z. It returned exit0 under the45-second bound. +There are190uniquePASS, all184old labels in order and every older prefix/projection, COMPLETE1, +FAIL0 and empty stdout/stderr. Retained log SHA256: +67B3FA693A6427C86B301973969A9CCA834FB739273A024140D0684C42194688. +All six new actual Welcome groups passed, including real localized/missing-key fallback, raw +values/default equality, nested mode/derived observer faults, status/error partial retry, reflection +wrappers, late host Next tail and final observer reentry. Runtime observation starts after the +observer subscribes; constructor no-notification behavior is established by inspected source. + +Postchecks preserve all1613tracked inputs/21inherited cuts/raw old cases,86source/resource/binary +pins, all522prior output names/hashes and the normal8D46GUI. Exactly six new direct-child files +produce528total: three literal inputs16/16/15bytes, two golden reports354/260bytes and the result +log. Current report fields, all20resource hashes and forbidden-output absence pass. The runner and +separate external Get-Process/CIM check confirm PID87792 and the exact fixture EXE are absent. +Root recorded idle173/requestfalse/no pending and released174 with fresh readback under the mutex. +No retry, force, UAC or foreign process action occurred. The frozen28operational inputs are still +unchanged; a38-file retained-runtime packet pins the observed logs, process/queue receipts and +output checks. Independent peer01a1c049 returned RETAINED RUNTIME PASS, zero blocking findings. +It rehashed all38runtime inputs and28operational inputs, rebuilt all1613Git/21cut/raw-case +comparisons read-only, checked actual190corpus/prefixes/streams/process/IO, all86pins/522prior +files/exact528set/20resources/5206source values/normalGUI and the173grant/idle/release174 chain. +Its separate process read also confirms owned PID/exact EXE absence. It ran no helper, fixture, +build or UI action and made no queue write. The immutable fixture will not be rerun. + +Draft PR232 targets frozen PR230/b0. At publication a45d557, hosted libraries independently passed +2672/2672/7seconds with0failures/skips, CI43106726512 has four successful jobs, CodeQL43106726692 +and Governance43106726174 pass, and current Contribution metadata43106790714 passes. Earlier +cancelled/superseded metadata attempts remain visible; they are not current-head product failures. +A later documentation-only delivery commit must receive its own exact-head checks. Under fresh +browser-only177, the existing auto-added PR232 card was classified and read after new navigation: +one matching draft/open232row, In progress/P2/Architecture/Low/G2/lumenpearson and exactly +area:architecture+type:refactor. FullAX/JPG/JSON are retained in the shared pr232-project-intake +directory. Only this card changed. Root closed own tabs8/9, recorded idle177/requestfalse/no +pending and guarded release178/all six paused. Final delivery-HEAD checks, case-specific LOCAL +acceptance and immediate completed/Done/readback remain pending at this report checkpoint. Their +later issue/API/Project receipts do not require another product or immutable fixture execution. + +No full loaded WelcomeWindow/XAML, visual EN/RU/accessibility, real migration/session/queue/import/ +license/storage, cancellation/teardown/GC/concurrency, full metadata/native ABI, installed product, +G1/integration/release result is implied. Source-only guards and portable faults cover only their +named boundaries. Retain source refs, worktrees, archives, failed and accepted evidence; repair +through additive changes without deletion/reset/force or foreign worktree mutation. diff --git a/docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md b/docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md new file mode 100644 index 00000000..f0045a6c --- /dev/null +++ b/docs/superpowers/specs/2026-11-11-configmaker-status-presentation-design.md @@ -0,0 +1,127 @@ +# ConfigMaker Status Presentation Design + +## Intent and accepted scope + +Issue #228 continues the authorized audit decomposition after the accepted local Store stage #225. +The baseline is frozen draft PR #227 at `3afa82e3f4947ce4bef38b14d86c642c93ddbe90`. +ConfigMakerViewModel has 986 physical lines in nine partial files; its main file has 381. +Its status pipeline is a distinct responsibility among editor, document, help and test composition. +This task accepts a LOCAL presentation result. Parent #14 retains broader integration; #13/#15, +the earlier draft stack, installed-product acceptance and release keep their existing boundaries. + +Execution owner: Root, chat `01a1bc96-ea11-73a1-a4a1-5cd6db1617fa`, in the existing isolated +`audit-class-decomposition/cdpiui` worktree, branch `dev/configmaker-status-presentation`. +Actual issue intake 149 confirmed In progress/P2/Architecture/Low/G2/lumenpearson and exactly +type:refactor plus area:architecture. A fresh browser navigation verified persisted fields after +the original reload left a blank body. Both owned tabs closed; guarded release 150 follows 149. + +## Ownership and ports + +Add internal sealed `ConfigMakerStatusPresentation` in the existing ConfigMaker folder. +It owns only StatusTitle, StatusMessage, StatusSeverity, IsStatusOpen and their display sequence. +Its constructor accepts these exact ports, stores them and invokes or validates none: + +```csharp +ConfigMakerStatusPresentation( + TSeverity initialSeverity, + Func resolveTitle, + Action raiseNotice, + Func getInline) +``` + +Title and message start at string.Empty, severity uses the explicit initial argument, and open +starts false. All four public owner setters use the existing ObservableObject.SetProperty equality. +The focused owner stays below 160 lines. Public owner methods are `Show(string? message, +TSeverity severity)` and the four property setters; no alternate state or cached notification exists. +Use nullable annotations on this internal owner to describe the existing raw-string behavior. + +The host composes the closed InfoBarSeverity owner after its two existing view/dispatcher guards, +before TextChangeRelay construction. Pass InfoBarSeverity.Informational explicitly. The title port +contains the original literal severity switch: Error uses SomethingWentWrong, Warning uses Attention, +and every other value uses Information. Each branch calls the current host localizer when invoked. +The notice port dynamically evaluates the original StatusNotificationRequested optional invocation +and constructs the existing StatusNotificationRequestedEventArgs with this VM as sender. The inline +port reads the current host UseInlineStatusMessages auto-property. Subscribe one synchronous owner +PropertyChanged bridge that calls the host OnPropertyChanged with the same name and host sender. +All previous constructor statements retain their relative order. New composition stays cold. + +Keep public ShowEditorMessage as a forward. Keep StatusTitle, StatusMessage and StatusSeverity +public getters/private setters, and IsStatusOpen's public getter/setter, as owner forwards. +UseInlineStatusMessages remains the same host auto-property with default true. Keep the existing +UserControl's separate notification bridge unchanged; it intentionally changes sender to the control. +No other consumer, interface or public signature changes. + +## Exact observable sequence + +Show first obtains a local title from resolveTitle(severity), then invokes raiseNotice with the raw +severity/title/message, then reads getInline exactly once. When false, assign only IsStatusOpen=false +and return, retaining the other three current values. When true, assign StatusTitle, StatusMessage, +StatusSeverity and IsStatusOpen=true in that order, with each original equality decision at its point. + +Title resolution can change the current event subscription before the notice. The notice can change +the inline flag or invoke ShowEditorMessage recursively. If the single later flag read returns true, +property callbacks that then change that flag do not stop the outer sequence. A nested call can change +current values; the outer call continues with its own earlier title/message/severity and compares +each assignment against those current nested values. Do not snapshot old state, subscribers or flag. + +The actual EventArgs constructor normalizes null title/message to string.Empty. The owner receives +and stores raw null strings. Never normalize in the owner, reconstruct inline values from EventArgs, +or replace that existing constructor. Unknown InfoBarSeverity values use Information for the title +and retain their raw enum value in the event and inline severity. Add no enum constraint or mapping. + +All callback exceptions propagate with their identity, without wrapping, rollback, catches, finally +or extra guards. A title failure prevents notice/flag/assignments; a notice failure prevents flag and +assignments; a flag-port failure prevents assignments. Each property observer sees its new value, +and a failure stops later assignments while retaining earlier and nested effects. Retry uses that +current partial state. The production inline auto-property does not itself call arbitrary code; +managed port-fault tests establish owner ordering, without claiming a native getter failure. + +## Existing product boundary + +Only main ConfigMakerViewModel.cs changes, beside the new internal owner. Remove its four old status +backing fields, replace the four property bodies and ShowEditorMessage, and add the cold composition +and bridge. The whole original host must reconstruct under exactly those declared substitutions. +Other partials, including direct ShowHelpLoadStatus closure through IsStatusOpen, remain byte-identical. +Keep all UserControl and EventArgs source, XAML, resources, packages, background/settings, logging, +document/help/test lifecycles, timer, IO, queue, Core/AddOns/Shared/security and other worktrees unchanged. +No static root, platform stub, new framework, synchronization or lifetime change is part of this task. + +## Verification and delivery + +Write linked-source tests first and observe the missing-owner RED. Use an owned test enum with a +nonzero initial severity to detect accidental default(TSeverity). Trace raw null/unknown values, +equality, cold ports, localization before dynamic notice lookup, one late flag read, enabled/disabled +paths, nested notice/property calls, outer locals, each port/property failure, retry and instances. +Hoist the inline read before notice in a controlled mutant; require real ordering/state failures, +restore exact source bytes/hash in finally, then focused/full GREEN and a normal Release/x64 GUI build. +Check whole-host reconstruction, literal severity/notice adapters, defaults/properties/constructor/ +bridge/footprint and unchanged partials. Compare baseline 451 exported source types and compiled +452 GUI/88 Core shapes within their existing limited inventories. Run governance and redacted scans. + +Create a NEW immutable native fixture from accepted Store178 R2, retaining all 178 labels, old case +bytes and 21 cuts. Derive actual counts. Add six unique ConfigMaker groups for actual cold host/owner, +public/private setters and sender, real severity/localizer/EventArgs values, late flag/disabled carryover, +nested notice/property/current equality, observer failures/retry and independent instances/raw values. +Use the current UI dispatcher and a view that rejects operating endpoints. Keep model/view cold; +do not call Load/OnViewLoaded, help, document/test commands, file operations or add operating cuts/IO. +Native raw-null caller evidence distinguishes EventArgs.Message empty from inline StatusMessage null. +Native title-port null, mutated subscriptions during localization, and arbitrary flag-port failures +remain managed/source-only where the uncut actual localizer/auto-property cannot produce them safely. +The UserControl's second sender bridge is unchanged source, without new loaded-control evidence. + +Require independent pre-build/prelaunch READY, actual source/resource/artifact/runner/verifier pins, +a new exclusive UI grant and complete corpus/exit/streams/hash/resources/output/process/idle-release +checks. Obtain a fresh whole-range review, publish a draft stacked on frozen PR #227, verify final-head +CI and actual PR Project fields, then six-criterion local acceptance and immediate completed/Done/readback. +Full Page/UserControl, visual EN/RU/accessibility, operating workflows, GC collection, unsupported +concurrency, all metadata/native ABI, installed product, G1, integration and release remain separate. +Retain every prior ref/worktree/archive/failed or accepted artifact. Recover with additive commits. + +## Executor choices + +The three cold callbacks and typed internal owner are the executor's choice. They isolate a complete +pipeline for portable tests while keeping the existing platform adapters and their observation points. +Four state values alone would leave the critical ordered pipeline in the host; a platform-dependent +owner would require a test stub or native-only characterization. No user design approval is inferred: +the user explicitly authorized autonomous decomposition and opted out of confirmation questions. +Fresh builder review is required before product code. Dates and estimates remain unset. diff --git a/docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md b/docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md new file mode 100644 index 00000000..a339125f --- /dev/null +++ b/docs/superpowers/specs/2026-11-11-welcome-migration-presentation-design.md @@ -0,0 +1,197 @@ +# Welcome Migration Presentation Design + +## Intent, ownership and admission + +Issue #231 continues authorized decomposition from frozen draft PR230 at +`b0f2c93d66000eb02cd963cf4421173980686e95`. Actual Project intake163 confirmed In progress/P2/Architecture/Low/G2/lumenpearson/exactly +area:architecture+type:refactor after fresh navigation, fullAX/screenshot/JSON saved. Own tabs closed, +idle163/requestfalse/pendingfalse/guardedrelease164/all six UI paused verified. Fresh builder +welcome_migration_design_check returned nothing important left before product implementation. This is a LOCAL stage under14; +13/15, G1 reconciliation, integrated wizard, installed product and release remain separate. +Root chat01a1bc96-ea11-73a1-a4a1-5cd6db1617fa owns the existing isolated audit-class-decomposition +checkout. Branch: dev/welcome-migration-presentation. No other worktree is taken over. + +WelcomeViewModel has983 physical lines across four partials. Migration.cs has407. Nine display +values and two synchronous policies form a coherent responsibility beside session/queue/import. +This extraction preserves behavior, rather than changing files to meet a line-count threshold. + +## The owner + +Add internal sealed WelcomeMigrationPresentation : ObservableObject in +CDPIUI/ViewModels/Welcome/WelcomeMigrationPresentation.cs, below200 physical lines. Use the existing +MigrationComponentDisplayItem directly, without another generic item parameter or new model. +The exact constructor is: + +```csharp +WelcomeMigrationPresentation(TSeverity initialSeverity, TSeverity errorSeverity, + Func text) +``` + +Store the error severity and resource callback; assign initial severity to its backing field. +Do not invoke/validate callbacks, localize, read session/settings or emit events during construction. +There is one production closed InfoBarSeverity instance per host; no enum constraint or mapping. +Use nullable annotations on the internal owner to describe baseline raw-null behavior. Existing +public host nullable annotations/accessors remain unchanged. + +The owner exposes public getters/setters with these exact names/types/defaults: + +| Property | Type | Default | +|---|---|---| +| IsMigrationMode | bool | false | +| MigrationStatusTitle | string? | string.Empty | +| MigrationStatusMessage | string? | string.Empty | +| MigrationStatusSeverity | TSeverity | explicit initialSeverity | +| MigrationProgress | double | 0 | +| MigrationComponentItems | IReadOnlyList? | null | +| IsMigrationComponentsListVisible | bool | true | +| MigrationSummaryText | string? | string.Empty | +| IsRetryMigrationVisible | bool | false | + +All nine setters use existing SetProperty/EqualityComparer.Default. Mode additionally emits +IsReadyBundlesContentVisible only after a successful changed SetProperty returns; its read-only +derived property is !current IsMigrationMode. The other setters have no side effects. Keep raw +null strings/list, unknown severity, signed zero/NaN/Infinity and custom list equality semantics. +Do not copy, clamp, normalize, enumerate or subscribe to a list. No cached derived value exists. +Raw-value preservation includes the original equality suppression: assigning -0 to initial +0 +does not replace the stored bits, and a second equal NaN can retain the first NaN payload. An old +custom list whose Equals(newList) returns true remains the stored reference. Test those retained +values, rather than requiring replacement for assignments that baseline SetProperty suppresses. + +## Exact display policies + +Public owner ShowStatus(string? titleKey, string? messageKey, TSeverity severity) executes: +MigrationStatusTitle = text($"/WelcomeWizard/{titleKey}"); then +MigrationStatusMessage = text($"/WelcomeWizard/{messageKey}"); then severity assignment. +Keep each lookup interleaved with its own assignment and observers. A title observer can change +the message lookup result, invoke a nested status/error call or throw. Do not prefetch both texts. + +Public owner ShowError(string? message, string? errorCode) first obtains a local string from +text($"/WelcomeWizard/MigrationError_{errorCode}"). If it is not null/empty/whitespace, replace only +the local message. Then assign failed-title lookup text("/WelcomeWizard/MigrationFailedTitle"), +the raw interpolated message plus literal "\n\n" and code, errorSeverity and retry=true, in that order. +No CodedMessageLocalizer, resource-key fallback, catch, formatting normalization or validation. + +Original comparisons happen against current state after nested effects, and outer arguments/local +message remain the outer call's values. Exceptions propagate with original identity from the owner; +earlier field changes and nested effects remain and later steps stop. Retrying uses that partial state. +Mode observer failure prevents its derived notification; nested reverse mode still allows an outer +derived event after the first SetProperty returns. Do not guard against or suppress reentry. + +## Host composition and exclusions + +Replace the nine old private fields in Migration.cs with one readonly owner field. Preserve all +nine public getters/private setters as exact owner forwards, plus the derived visibility getter. +IsMigrationReadyToContinue and _migrationReadyToContinue remain host-owned and unrelated to mode. +Replace private ShowMigrationStatus with an owner forward. Private ShowMigrationError calls +owner.ShowError(message,errorCode), then the original literal IsNextEnabled=false statement. +This final eligibility assignment is host-owned, follows a successful owner return and still runs +after a nested display call. If the owner throws, the tail is not reached. Its own observer fault +retains the new Next value and all preceding display effects. Do not add a disable-next port. + +In main WelcomeViewModel.cs add Microsoft.UI.Xaml.Controls using and cold composition after the +existing _view/_dispatcherQueue assignments, before command construction. Pass explicit +InfoBarSeverity.Informational, InfoBarSeverity.Error and key=>_localizer.GetLocalizedString(key). +Subscribe exactly one synchronous owner PropertyChanged bridge to host OnPropertyChanged(name), +preserving VM sender and exception propagation. All previous constructor statements retain order. + +These are the only two existing product files allowed to change. Whole-host reconstruction must +prove every undeclared byte of normalized source unchanged. Preserve Localized and every session/ +CTS/subscription/queue/import/readiness/retry/projection/aggregate/window/license/settings/DB/IO +method exactly, including the host's existing summary-after-list late localizer and Math.Max reads. +MigrationImport.cs and MigrationQueue.cs remain byte-identical. No WelcomeWindow/XAML/resources, +Core/AddOns/Shared/package/security/G1 implementation or exported type/API changes. No new partial. +The baseline four partials/window sources match integrated main6c00c789; unpublished G1 changes +are neither adopted nor modified. A read-only utility peer confirmed no overlap with its frozen refs. +Live main subsequently advanced to21555a29ce9fba98c678c445d04ee9f6ce3c85ba with the separately +owned PR229 language-selector fix (six paths, no Welcome). This stage keeps b0/6c00 as named frozen +inputs. It does not claim equivalence to the new main composition or borrow229 installed evidence. + +## Managed verification + +Link the owner, actual ObservableObject and actual MigrationComponentDisplayItem into existing +CDPIUI.Tests with an owned non-default test severity enum. Write cases before implementation and +observe CS0246 missing owner. Cover nine defaults and changed/equal/raw values, cold null callback, +mode/derived event snapshots, nested reversal/failure, same/equal-custom/distinct/null lists, NaN/ +Infinity/signed zero, and per-instance isolation. Trace raw resource keys, title-assignment-before- +message-lookup, nested lookup/property effects, outer locals and every callback/property exception +boundary with exact sentinel identity/partial state/retry. Error fallback covers null/empty/white/ +nonempty text and raw null message/code; error sequence has title/message/severity/retry observers. +The host Next tail is actual-native/source proof, not an arbitrary owner port test. + +Controlled mutant: eagerly resolve the message before assigning title, preserving all types and +compilation. Require meaningful ordering/reentry/fault test failures, save actual exit/logs, restore +owner bytes/hash in finally and run focused GREEN, full dotnet test and normal Release/x64 GUI +sequentially. Compare451 source exported types and compiled452GUI/88Core bounded shapes against +the same normal GUI composition baseline; attributes/native ABI remain outside those inventories. +Check literal old ShowStatus/Error policy under only documented resource/severity substitutions, +exact host reconstruction/accessors/bridge/constructor/defaults/equality/footprint/untouched hashes, +governance, whitespace and redacted scans. Keep every failed harness attempt and its resolution. + +## Native and delivery verification + +After product checkpoint create a NEW immutable source-pinned fixture/archive from accepted +ConfigMaker184. Keep all old184 labels, raw case bytes,21 operating cuts (20raw plus EXE literal), +old outputs/resources and exact inherited corpus prefixes. Add six unique actual-composition groups: +1 cold constructor/closed typed owner/nine defaults/accessors/VM sender/current dispatcher; +2 raw setters/equality/mode-derived order/nested reversal/list identity/NaN/independent hosts; +3 actual resource title/message/severity and status reentry/current equality; +4 actual error-code localization, fallback/double-newline, retry and host Next tail ordering; +5 status title/message/severity observer faults/partial retry with private reflection wrappers; +6 error title/message/severity/retry/Next faults and nested error/status outer continuation. +Target190 =184+6; derive exact actual counts and labels before any build or run. + +Construct actual WelcomeViewModel with current DispatcherQueue and a rejecting IWelcomeView; each +CurrentStep/RefreshNavigation/ShowStoreLoadingButtons/AcceptLicensesAsync endpoint throws. Never +execute commands, license flow, SetMigrationSession, ApplyMigrationSessionState, queue/import or +window lifecycle. Every instance detaches external test observers and disposes only its own actual +CTS framework resource after assertions, without running migration or claiming teardown coverage. +Private setter/helper reflection can wrap observer exceptions; explicitly inspect/unwrap wrappers +and distinguish from direct owner exception identity proved in portable tests. Actual arbitrary +localizer-null/subscriber changes are managed/source-only; native uses real uncut localizer/resources. + +Require independent pre-build review of source/cases/corpus/containment, normal native build zero +warnings/errors, actual binaries/resources/source/runner/verifier pins, prior output names/hashes, +resource JSON/generated parity and independent prelaunch READY. Obtain a NEW explicit exclusive +queue grant, recheck pins/absence/actual process/nonadmin context, and launch one owned process. +Verify190uniquePASS/prefixes/COMPLETE1/FAIL0/exit0/streams0, all input/prior output/source/resource +hashes and exact new names/forbidden absence/normal GUI unchanged, then process absence/idle/ +requestfalse/pendingfalse/guarded release. Do not rerun accepted fixtures or add operating cuts. + +Obtain fresh whole-range independent review before delivery, record every ruling/deferred finding +with costs, publish a draft stacked on frozen PR230 and pass exact final-head checks. Read back +actual PR Project fields separately. Match six issue criteria, post six-section LOCAL acceptance, +immediately completed/actualDone/readback, then post-edit metadata status. Keep13/14/15 and drafts +open/unmerged. Retain all evidence/refs/worktrees; no deletion/reset/force/main merge/release. + +## Explicit limits and builder choices + +No full loaded wizard/rendering/EN-RU/accessibility or actual session/queue/import/license/storage, +cancellation/teardown/GC/concurrency, full metadata/native ABI, installed/G1/integration/release claim. +Portable callback fault permutations are distinct from the uncut native localizer. Builder may +choose private helper/test organization and assertion grouping within the named interface and six +native groups; it may not alter operating boundaries, notification order, counts or accepted corpus. +All interface/scope choices here belong to the executor under autonomous authorization, not to a +new user approval. Actual Project admission and fresh builder verdict are recorded above. At the +original design checkpoint, product implementation had not started. + +## Delivery ordering after the external UI stop + +Physical user Esc under shared lease167 stopped Computer Use after the managed product checkpoint. +At that checkpoint, all UI, native GUI execution and queue handoffs were held. Technical source preparation/build/ +pinning, read-only review and hosted CI can continue. After independent whole-range source review, +publish a clearly incomplete stacked draft to obtain exact-head CI, with native runtime and actual +PR Project readback unchecked. This changes delivery order, not acceptance. A later explicit user +UI/native scope, fresh prelaunch review/current peer idle/new grant, actual190run, retained-runtime +review and completed/Done readback remain required. Do not mark Task2 or issue231 complete from +the source draft, compiled fixture or hosted CI. Source changes require appropriate new verification. + +Later, the explicit human231 UI/native-resume message was verified by its actual user-message +record. The original stopped packet remains immutable. Additive operationalr2 rejects optimized +Python before IO and removes the native helper's queue mutation operations; isolated regressions +reproduce both old defects and pass after correction. Actual owner transitions use the separately +acknowledged sole Root coordinator under one named mutex. This is not a global filesystem CAS. +Fresh qualified peer idle and independent prelaunch READY preceded NEW173; the single190-group +run passed and Root confirmed owned PID/exact EXE absence, idle/requestfalse/release174. The +runtime receipt attributes constructor coldness to source, since its observer attaches afterwards. +Final evidence review, exact delivery-HEAD CI and actual Project/LOCAL acceptance remain separate +gates; their current results belong to the verification report and issue231 acceptance record.