From 017057836f20c2dcda0f1c5a037b88ddf1477d72 Mon Sep 17 00:00:00 2001
From: 52191314 <xianspired@gmail.com>
Date: Wed, 12 Aug 2026 08:45:22 +0700
Subject: [PATCH] fix(english): fail fast on lightnovelworld chapter fetch
 errors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- parseChapter: throw on non-OK response or empty content instead of
  returning the 'No content found.' placeholder — the app's error screen
  (Retry / refresh) handles recovery
- fetchAllChapters: throw on failed page fetches instead of swallowing
  errors into an empty list
- parseNovel: chapter-list failures now surface instead of silently
  producing an empty chapter list
- bump version to 1.0.2
---
 plugins/english/lightnovelworld.ts | 51 ++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 17 deletions(-)

diff --git a/plugins/english/lightnovelworld.ts b/plugins/english/lightnovelworld.ts
index 5b58cb581..3f966899b 100644
--- a/plugins/english/lightnovelworld.ts
+++ b/plugins/english/lightnovelworld.ts
@@ -23,7 +23,7 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
     name = "LightNovelWorld";
     icon = "src/en/lightnovelworld/icon.png";
     site = "https://lightnovelworld.org/";
-    version = "1.0.1";
+    version = "1.0.2";
 
     filters = {
         sort: {
@@ -199,6 +199,11 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
         const apiBase = `${this.site}api/novel/${slug}/chapters/?limit=${LIMIT}`;
 
         const firstRes = await fetchApi(`${apiBase}&offset=0`);
+        if (!firstRes.ok) {
+            throw new Error(
+                `Failed to fetch chapters (HTTP ${firstRes.status})`,
+            );
+        }
         const firstJson = (await firstRes.json()) as {
             chapters: { number: number; title: string }[];
             total_chapters: number;
@@ -212,17 +217,23 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
 
         const remainingResults = await Promise.all(
             offsets.map(async (offset) => {
-                try {
-                    const res = await fetchApi(`${apiBase}&offset=${offset}`);
-                    const json = (await res.json()) as { chapters: { number: number; title: string }[] };
-                    return json.chapters || [];
-                } catch {
-                    return [];
+                const res = await fetchApi(`${apiBase}&offset=${offset}`);
+                if (!res.ok) {
+                    throw new Error(
+                        `Failed to fetch chapters page ${offset} (HTTP ${res.status})`,
+                    );
                 }
+                const json = (await res.json()) as {
+                    chapters: { number: number; title: string }[];
+                };
+                return json.chapters || [];
             })
         );
 
-        const rawChapters = [...(firstJson.chapters || []), ...remainingResults.flat()];
+        const rawChapters = [
+            ...(firstJson.chapters || []),
+            ...remainingResults.flat(),
+        ];
 
         return rawChapters
             .map((ch) => ({
@@ -255,11 +266,7 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
         let chapters: Plugin.ChapterItem[] = [];
 
         if (slug) {
-            try {
-                chapters = await this.fetchAllChapters(slug);
-            } catch {
-                chapters = [];
-            }
+            chapters = await this.fetchAllChapters(slug);
         }
 
         return {
@@ -275,19 +282,29 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
     }
 
     async parseChapter(chapterPath: string): Promise<string> {
-        const html = await fetchText(`${this.site}${chapterPath}`);
+        const url = `${this.site}${chapterPath}`;
+        const res = await fetchApi(url);
+        if (!res.ok) {
+            throw new Error(`Could not load chapter (HTTP ${res.status})`);
+        }
+        const html = await res.text();
         const $ = loadCheerio(html);
 
         const container = $('#chapterText');
         if (!container.length) {
-            return '<p>No content found.</p>';
+            throw new Error('Could not load chapter');
         }
 
-        container.find('script, style, ins, iframe, .ads, .ad-container, .watermark').remove();
+        container
+            .find('script, style, ins, iframe, .ads, .ad-container, .watermark')
+            .remove();
         container.find('[style]').removeAttr('style');
 
         const content = container.html()?.trim() || '';
-        return content || '<p>No content found.</p>';
+        if (!content) {
+            throw new Error('Could not load chapter');
+        }
+        return content;
     }
 
     async searchNovels(