Skip to content
This repository was archived by the owner on May 23, 2026. It is now read-only.
This repository was archived by the owner on May 23, 2026. It is now read-only.

FOLLOW-UP: Replace WaitFor('true') with real wait condition in dialog-patterns test #60

Description

@adnaan

Context

This follow-up task was identified during the review of PR #57.

Source PR: #57
PR Title: refactor: consolidate DevMode blocks with defer, enable skipped test suites
Suggested by: @copilot-pull-request-reviewer
File: dialog-patterns/dialog_patterns_test.go:288

Task Description

e2etest.WaitFor('true', 2*time.Second) does not actually wait — the JS expression is immediately true, so the subtest can proceed before the server/WebSocket-driven DOM update has applied.

Replace it with a wait condition that reflects the expected post-submit state (e.g., wait for a validation error element/aria-invalid, or for the dialog content to re-render).


This issue was automatically created from PR review comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions