Skip to content

FOLLOW-UP: Move activeBindings from module-level to per-client instance (from PR #94) #95

Description

@adnaan

Context

This follow-up task was identified during the review of PR #94.

Source PR: #94
PR Title: feat: scroll enhancements — data-lvt-target for scroll effects, lvt-scroll-away, bottom-sticky first-run
Suggested by: @claude[bot]

Task Description

activeBindings in scroll-away.ts is a module-level array shared across all LiveTemplateClient instances. pruneDisconnectedBindings() and teardownScrollAway(wrapper) mutate bindings from all instances. In a single-instance setup this is fine, but if two clients coexist (e.g., embedded widgets), one client's teardown could affect another's bindings.

Consider moving the bindings array to the client instance and threading it into setupScrollAway/teardownScrollAway.


This issue was automatically created by prmonitor from PR review comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions