Skip to content

FOLLOW-UP: Document single-instance assumption in hash-link module #89

Description

@adnaan

Context

This follow-up task was identified during the review of PR #86.

Source PR: #86
PR Title: feat: hash-driven element activation for deep-linking
Suggested by: @claude[bot]

Task Description

The installed flag in hash-link.ts is module-scoped. If two LiveTemplateClient instances coexist on the same page, the first teardownHashLink() call silently removes the listeners for both.

This is fine for the current single-instance production path, but should be noted with a comment. If multi-instance support is ever needed, the singleton pattern would need to be refactored (e.g., reference counting or per-instance listener management).

Priority

Low


This issue was automatically created by prmonitor from PR review comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upFollow-up task from PR reviewfrom-reviewIssue originated from PR review

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions