Skip to content

Better Healthcheck Testing/Blank database name #37

Description

@reynoldsalec

We just implemented a fix to handle situations where the user specifies blank dbname/username for the db config. Ex:

services:
  database:
    type: postgres
      creds:
        user: customusername
        database: customdbname

The fix: 893831a

I put in a "test case" in the custom example to make sure a blank user wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions