From e6eed12fc15fc5036489fbced7999c951afba1bd Mon Sep 17 00:00:00 2001
From: jrd <gh26.x.jrd@xoxy.net>
Date: Sat, 18 Jul 2026 15:10:43 +0000
Subject: [PATCH] Make cross-thread audio params and channel/server flags
 std::atomic
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Second slice of #3798 (batches C, D, E — mechanical conversions only):
GUI-thread parameters read by the audio callback, client channel state
read by the socket thread, and the server disconnect flag written by
thread-pool workers. The comment at the disconnect flag claimed the
write was atomic; it now is.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 src/channel.h  | 15 ++++++++-------
 src/client.h   | 15 ++++++++-------
 src/server.cpp |  6 +++---
 src/server.h   |  9 +++++----
 4 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/src/channel.h b/src/channel.h
index eea8b0c8e2..946eae007a 100644
--- a/src/channel.h
+++ b/src/channel.h
@@ -49,6 +49,7 @@
 #include <QThread>
 #include <QDateTime>
 #include <QFile>
+#include <atomic>
 #if QT_VERSION >= QT_VERSION_CHECK( 5, 6, 0 )
 #    include <QVersionNumber>
 #endif
@@ -231,14 +232,14 @@ class CChannel : public QObject
     // network protocol
     CProtocol Protocol;
 
-    int iConTimeOut;
-    int iConTimeOutStartVal;
-    int iFadeInCnt;
-    int iFadeInCntMax;
+    std::atomic<int> iConTimeOut;
+    int              iConTimeOutStartVal;
+    int              iFadeInCnt;
+    int              iFadeInCntMax;
 
-    bool bIsEnabled;
-    bool bIsServer;
-    bool bIsIdentified;
+    std::atomic<bool> bIsEnabled;
+    bool              bIsServer;
+    bool              bIsIdentified;
 
     int iNetwFrameSizeFact;
     int iNetwFrameSize;
diff --git a/src/client.h b/src/client.h
index fb77930723..5997dfe886 100644
--- a/src/client.h
+++ b/src/client.h
@@ -51,6 +51,7 @@
 #include <QString>
 #include <QDateTime>
 #include <QMutex>
+#include <atomic>
 #ifdef USE_OPUS_SHARED_LIB
 #    include "opus/opus_custom.h"
 #else
@@ -390,8 +391,8 @@ class CClient : public QObject
     EAudChanConf           eAudioChannelConf;
     int                    iNumAudioChannels;
     bool                   bIsInitializationPhase;
-    bool                   bMuteOutStream;
-    float                  fMuteOutStreamGain;
+    std::atomic<bool>      bMuteOutStream;
+    std::atomic<float>     fMuteOutStreamGain;
     CVector<unsigned char> vecCeltData;
 
     bool            bIPv6Available; // must be before Socket - passed by reference to Socket
@@ -402,11 +403,11 @@ class CClient : public QObject
 
     CVector<uint8_t> vecbyNetwData;
 
-    int          iAudioInFader;
-    bool         bReverbOnLeftChan;
-    int          iReverbLevel;
-    CAudioReverb AudioReverb;
-    int          iInputBoost;
+    std::atomic<int>  iAudioInFader;
+    std::atomic<bool> bReverbOnLeftChan;
+    std::atomic<int>  iReverbLevel;
+    CAudioReverb      AudioReverb;
+    std::atomic<int>  iInputBoost;
 
     int iSndCrdPrefFrameSizeFactor;
     int iSndCrdFrameSizeFactor;
diff --git a/src/server.cpp b/src/server.cpp
index 2fd6b2a9bf..8daca7f0fd 100644
--- a/src/server.cpp
+++ b/src/server.cpp
@@ -944,9 +944,9 @@ void CServer::DecodeReceiveData ( const int iChanCnt, const int iNumClients )
 
                 FreeChannel ( iCurChanID ); // note that the channel is now not in use
 
-                // note that no mutex is needed for this shared resource since it is not a
-                // read-modify-write operation but an atomic write and also each thread can
-                // only set it to true and never to false
+                // note that no mutex is needed for this shared resource since it is a
+                // std::atomic write (not a read-modify-write operation) and also each
+                // thread can only set it to true and never to false
                 bChannelIsNowDisconnected = true;
 
                 // since the channel is no longer in use, we should return
diff --git a/src/server.h b/src/server.h
index 3e99ebb3dc..c2617a17ce 100644
--- a/src/server.h
+++ b/src/server.h
@@ -51,6 +51,7 @@
 #include <QHostAddress>
 #include <QFileInfo>
 #include <algorithm>
+#include <atomic>
 #ifdef USE_OPUS_SHARED_LIB
 #    include "opus/opus_custom.h"
 #else
@@ -254,10 +255,10 @@ class CServer : public QObject, public CServerSlots<MAX_NUM_CHANNELS>
     int    vecChannelOrder[MAX_NUM_CHANNELS];
     QMutex MutexChanOrder;
 
-    CProtocol ConnLessProtocol;
-    QMutex    Mutex;
-    QMutex    MutexWelcomeMessage;
-    bool      bChannelIsNowDisconnected;
+    CProtocol         ConnLessProtocol;
+    QMutex            Mutex;
+    QMutex            MutexWelcomeMessage;
+    std::atomic<bool> bChannelIsNowDisconnected;
 
     // audio encoder/decoder
     OpusCustomMode*    Opus64Mode[MAX_NUM_CHANNELS];