Repository navigation
DisjunctionSet - #140
Merged
Merged
DisjunctionSet#140
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 99.51% 99.52% +0.01%
==========================================
Files 17 19 +2
Lines 2061 2112 +51
==========================================
+ Hits 2051 2102 +51
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dnguyen227
force-pushed
the
gdp_optimizer
branch
from
August 7, 2026 19:36
f36bd26 to
9361d9c
Compare
Contributor
Author
|
@pulsipher ready for review. This one is related to DisjunctiveAlgorithms.jl |
pulsipher
requested changes
Sep 11, 2026
pulsipher
left a comment
pulsipher
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one minor update needed.
pulsipher
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a different way to implement #137. Instead #71 is implemented as well as an optimizer layer where the LOA algorithm will run. DP.jl own the DisjunctionSet that DA.jl unpacks to solve LOA.
This was tested on some problems from the SECQUOIA/gdplib, as well as the existing InfiniteGDP case studies we have (
InfiniteDisjunctiveProgramming.jlworks out of the box).