Skip to content

Multiple dependencies to Fabric Samples #776

Description

@mbrandenburger

The current repo contains three references to the Fabric Samples repository.

  • go.mod: which is via the sample of the asset-transfer-basic. It refers to commit 84f9ba1dc4ec.
  • samples/deployment/test-network: which contains setup.sh, a script to clone fabric samples repo to use the test-network. It refers to commit 50b69f6
  • integration/deployment_test.sh: which clones the latest version of fabric samples to package and install the asset-transfer-basic/chaincode-go during the integration test. It refers to the latest commit during test execution.

This inconsistency may render in potential issues when playing, building, and testing FPC. We may want to explore ways to keep these dependency in sync.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependenciesPull requests that update a dependency file

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions