Skip to content

CI, Golint Check before building PR #729

Description

@chenchanglew

Is your feature request related to a problem? Please describe.
I had a Golang lint error after 20 minutes of docker build. Maybe we can add a new Golint checking before building docker image in CI.

Describe the solution you'd like
Current CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
build dev image
fetch dev image
run make inside dev container
....

Suggest CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
golint checking
build dev image
fetch dev image
run make inside dev container
....

Describe alternatives you've considered
Or any step before run make inside dev container

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions