From ab387ef0bd10de48366013b38a5d91e871bc26b7 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sun, 15 Nov 2026 16:43:29 +0100 Subject: [PATCH] go 1.27.4 for GO-2026-6859, and the CI pin reads go.mod instead of an env var MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GO-2026-6859, published 2026-11-11, CVE-2026-97054: "HTTP/1 server crash due to MaxBytesReader header race in net/http", standard library, fixed in 1.26.11 and 1.27.4. Read at https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes. The `go` directive is the only one of the three Go pins a CONSUMER reads, and `modfloor --floor 1.27.4` read the directive this module PUBLISHED at v0.3.1 as `go 1.27.3`, reported PUBLISHED: a consumer installing it under GOTOOLCHAIN=local built against an unpatched standard library. ⚠ Reachability is govulncheck's question, not this line's, and this repository is NOT in the fleet's network-facing list. The floor is raised because a consumer is entitled to build against the patched library. ⛔ AND THE CI PIN HAD TO MOVE IN THE SAME CHANGE. The workflow held `GO_VERSION: "1.27.3"` and its only setup-go step read `${{ env.GO_VERSION }}` — a hard-coded pin one indirection away. `setup-go` sets GOTOOLCHAIN=local, so a pin under the directive does not build an older toolchain quietly, it REFUSES with `go.mod requires go >= 1.27.4`. Measured the same day on five of six go-filesystems repositories: every job red at once for a one-line change. ⚠ AND THE INDIRECTION HID IT FROM THE AUDITOR. `gofloor` reports a hard-coded `go-version` as a finding and classifies `${{ … }}` merely as "expression", so this repository read as clean while its pin sat two patch releases behind the floor the fleet was moving to. Three of the five Go repositories in this organisation have that shape — browserproxy (fixed today), engine (current but invisible at the next raise), and this one. Being filed against gofloor separately. The step now reads `go-version-file: go.mod`, so the toolchain is the declared floor by construction. ⚠ Worth recording about the method rather than the change: this clone was FOUR COMMITS STALE (1585 insertions, cmd/webtest and driver/ added), and an edit made before fetching would have produced a pull request reverting all of it. Fetched and fast-forwarded to e5b0f39 before touching anything. actionlint clean, gofmt silent, go build and go test ./... pass, and the only `go-version` text left in the workflow is this change's own explanation. MINOR, not patch: a raised floor is a genuine break for a consumer pinned below it with GOTOOLCHAIN=local — their build stops instead of quietly producing a vulnerable binary. Co-Authored-By: Claude Opus 5 --- .github/workflows/ci.yml | 20 +++++++++++++++++--- go.mod | 27 ++++++++++++++++++++++++++- 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d94df6d..cd46af3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,8 +12,22 @@ on: permissions: contents: read -env: - GO_VERSION: "1.27.3" +# ⛔ GO_VERSION IS GONE ON PURPOSE. It held the literal "1.27.3" and the only +# setup-go step read it as `${{ env.GO_VERSION }}`, which is a hard-coded pin +# one indirection away: it drifts from go.mod exactly as a literal does, and +# `setup-go` sets GOTOOLCHAIN=local, so a pin UNDER the directive does not build +# an older toolchain quietly — it REFUSES with `go.mod requires go >= X`. +# Measured 2026-11-15 on five of six go-filesystems repositories: every job red +# at once, for a one-line change to go.mod. +# +# ⚠ And the indirection hid it from the auditor: `gofloor` reports a hard-coded +# `go-version` as a finding but classifies `${{ … }}` merely as "expression", so +# this repository read as clean while its pin sat two patch releases behind the +# floor the fleet was moving to. Three of the five Go repositories in this +# organisation had the same shape. +# +# The step now reads `go-version-file: go.mod`, so the toolchain is the declared +# floor by construction and the next raise needs no edit here. jobs: test: @@ -24,7 +38,7 @@ jobs: - uses: actions/setup-go@v7 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - name: Build diff --git a/go.mod b/go.mod index 77c44a0..0e60339 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,31 @@ module github.com/go-webengine/webtest -go 1.27.3 +// ⛔ THE PATCH, BECAUSE THIS LINE IS THE ONLY ONE OF THE THREE GO PINS A +// CONSUMER HONOURS: `go install` with GOTOOLCHAIN=local obeys it, while the CI +// pin merely builds our artefacts and the toolchain stamped in a binary +// describes one executable. +// +// Raised to 1.27.4 on 2026-11-15 for GO-2026-6859 — published 2026-11-11, +// CVE-2026-97054, "HTTP/1 server crash due to MaxBytesReader header race in +// net/http", stdlib, fixed in 1.26.11 and 1.27.4. Read at +// https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes. +// +// Measured, not assumed: `modfloor --floor 1.27.4` read the directive this +// module PUBLISHED at v0.3.1 from the module proxy as `go 1.27.3`, and reported +// it PUBLISHED — so a consumer installing it under GOTOOLCHAIN=local built +// against an unpatched standard library. +// +// ⚠ Reachability is govulncheck's question, not this line's. This repository is +// NOT in the fleet's network-facing list; the floor is raised because a +// consumer is entitled to build against the patched library. +// +// ⛔ AND THE CI PIN MOVED WITH IT, in the same change, because it had to: the +// workflow held `GO_VERSION: "1.27.3"` and the step read it as an expression — +// a hard-coded pin one indirection away. Raising this line alone would have +// made the lane REFUSE (`go.mod requires go >= 1.27.4`, since setup-go sets +// GOTOOLCHAIN=local), which is what happened to five of six go-filesystems +// repositories the same day. The step now reads `go-version-file: go.mod`. +go 1.27.4 require ( github.com/go-webengine/engine v0.47.0